Add input validation to ensure the function only accept valid card values and update the test case.

Author: ahmadehsas

Sprint-3/2-mandatory-rewrite/3-get-card-value.js

@@ -1,13 +1,39 @@
 function getCardValue(card) {
-  const rank = card.slice(0, -1); // get the value part: A, 2–10, J, Q, K
+  if (typeof card !== "string") {
+    throw new Error("Card must be a string");
+  }
+
+  card = card.trim().toUpperCase();
+
+  // Extract rank (everything except last char, assuming last is suit)
+  const rank = card.slice(0, -1);
+
+  // Define allowed ranks exactly — no fuzzy matching
+  const validRanks = [
+    "2",
+    "3",
+    "4",
+    "5",
+    "6",
+    "7",
+    "8",
+    "9",
+    "10",
+    "J",
+    "Q",
+    "K",
+    "A",
+  ];
+
+  if (!validRanks.includes(rank)) {
+    throw new Error("Invalid card rank");
+  }
 
   if (rank === "A") return 11;
   if (["K", "Q", "J"].includes(rank)) return 10;
 
-  const number = parseInt(rank);
-  if (!isNaN(number) && number >= 2 && number <= 10) return number;
-
-  throw new Error("Invalid card");
+  // If rank is numeric (2-10), safely convert to number
+  return parseInt(rank, 10);
 }
 
 module.exports = getCardValue;

Sprint-3/2-mandatory-rewrite/3-get-card-value.test.js

@@ -20,6 +20,26 @@ test("throws an error or invalid card", () => {
   expect(() => getCardValue("Z♠")).toThrow("Invalid card");
 });
 
+test("should throw error for malformed numeric input", () => {
+  expect(() => getCardValue("2.9999♠")).toThrow("Invalid card rank");
+});
+
+test("should throw error for repeated characters in rank", () => {
+  expect(() => getCardValue("3AAAA♠")).toThrow("Invalid card rank");
+});
+
+test("should throw error for number beyond valid range", () => {
+  expect(() => getCardValue("11♠")).toThrow("Invalid card rank");
+});
+
+test("should throw error for missing suit", () => {
+  expect(() => getCardValue("Q")).toThrow("Invalid card rank");
+});
+
+test("should throw error for non-string input", () => {
+  expect(() => getCardValue(5)).toThrow("Card must be a string");
+});
+
 // try {
 // getCardValue("Z♠");
 //} catch (error) {