WM | 25-ITP-May | Nahom Mesfin | Sprint 3 coursework #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nahommesfin77
added
the
Needs Review
LonMcGregor
added
Review in progress
LonMcGregor
reviewed
Jul 22, 2025
| @@ -9,6 +9,7 @@ | |||
|
|
|||
| function isProperFraction(numerator, denominator) { | |||
| if (numerator < denominator) return true; | |||
There was a problem hiding this comment.
What happens if I call isProperFraction(-70,5)?
-70/5 is not a proper fraction.
| if (rank === "A") return 11; | ||
| if (rank >= '2' && rank <= '9') return Number(rank); |
There was a problem hiding this comment.
What happens if I call getCardValue("222♥")?
| @@ -1,5 +1,11 @@ | |||
| function countChar(stringOfCharacters, findCharacter) { | |||
| return 5 | |||
| let count = 0; | |||
There was a problem hiding this comment.
This is very minor - try to keep the indentation the same for all the code. here your first declaration is indented further.
| @@ -1,5 +1,8 @@ | |||
| function getOrdinalNumber(num) { | |||
There was a problem hiding this comment.
In english we would say "21st" - can you make your code work in these general cases too?
| function repeat() { | ||
| return "hellohellohello"; | ||
| function repeat(str, count) { | ||
| return str.repeat(count); |
There was a problem hiding this comment.
What about your error condition you are testing for?
LonMcGregor
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
In Implement, I wrote functions step-by-step with assertions to cover different cases. In Rewrite, I converted previous assertions to use Jest syntax for clearer and easier testing. In Practice I built and ran tests using Jest and vscode's code runner to ensure all functions meet requirements.