-
-
Notifications
You must be signed in to change notification settings - Fork 240
Glasgow | 25-ITP-SEP | Alaa Tagi | Sprint 2 | coursework/sprint-2 #729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 11 commits
e3dd609
7f96fdf
4e3088e
ce8b66d
0a2d800
eb2af74
7a1579c
61620bc
5711722
544cb83
8c774bc
472c56d
24c915a
812128c
3865600
bfafdef
0671c48
3b782df
d059399
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,20 @@ | ||
| // Predict and explain first... | ||
| // =============> write your prediction here | ||
| // =============> write your prediction here : There will be an error. | ||
|
|
||
| // call the function capitalise with a string input | ||
| // interpret the error message and figure out why an error is occurring | ||
|
|
||
| function capitalise(str) { | ||
| let str = `${str[0].toUpperCase()}${str.slice(1)}`; | ||
| return str; | ||
| } | ||
| let str = `${str[0].toUpperCase()}${str.slice(1)}`; | ||
| return str; | ||
|
|
||
| // =============> write your explanation here : Because str has been used(declared) twice. As an input(parameter) to the function(capitalise) and with let. We should used a different variable. | ||
|
|
||
| // =============> write your explanation here | ||
| // =============> write your new code here | ||
| // =============> write your new code here : | ||
| /* | ||
| function capitalise(str) { | ||
| let cap = `${str[0].toUpperCase()}${str.slice(1)}`; | ||
|
||
| return cap; | ||
| } | ||
| console.log(capitalise("str")); | ||
| */ | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,12 @@ | ||
| // Predict and explain first... | ||
|
|
||
| // Why will an error occur when this program runs? | ||
| // =============> write your prediction here | ||
| // =============> write your prediction here : The variable decimalNumber has been declared. | ||
|
|
||
| // Try playing computer with the example to work out what is going on | ||
|
|
||
| // The old code : | ||
| /* | ||
| function convertToPercentage(decimalNumber) { | ||
| const decimalNumber = 0.5; | ||
| const percentage = `${decimalNumber * 100}%`; | ||
|
|
@@ -13,8 +15,22 @@ function convertToPercentage(decimalNumber) { | |
| } | ||
|
|
||
| console.log(decimalNumber); | ||
| */ | ||
|
|
||
| // =============> write your explanation here | ||
|
|
||
| // =============> write your explanation here : | ||
| /* | ||
| -The variable decimalNumber has been declared within the function as a parameter then declared again using const. | ||
| - The variable decimalNumber should be defined first. | ||
| */ | ||
| // Finally, correct the code to fix the problem | ||
| // =============> write your new code here | ||
|
|
||
| //The correct code : | ||
| const decimalNumber = 0.5; | ||
|
|
||
| function convertToPercentage(decimalNumber) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This works nicely but as an optional exercise, could you think of a way to simplify the code within this function? |
||
| const percentage = `${decimalNumber * 100}%`; | ||
| return percentage; | ||
| } | ||
|
|
||
| console.log(convertToPercentage(decimalNumber)); | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,22 @@ | ||
|
|
||
| // Predict and explain first BEFORE you run any code... | ||
|
|
||
| // this function should square any number but instead we're going to get an error | ||
|
|
||
| // =============> write your prediction of the error here | ||
| // =============> write your prediction of the error here : There will be a syntax error because the parameter name cannot be a number. | ||
|
|
||
| function square(3) { | ||
| return num * num; | ||
| function square(3) { | ||
| return num * num; | ||
| } | ||
|
|
||
| // =============> write the error message here | ||
| // =============> write the error message here : SyntaxError: Unexpected number. | ||
|
|
||
| // =============> explain this error message here | ||
| // =============> explain this error message here : /*The error message shows that there is an unexpected number in the function parameter name. Function parameters must be valid identifiers (like variable names) and cannot be numeric literals.*/ | ||
|
|
||
| // Finally, correct the code to fix the problem | ||
|
|
||
| // =============> write your new code here | ||
|
|
||
|
|
||
| function square(num) { | ||
| return num * num; | ||
| } | ||
| console.log(square(3)); |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,19 @@ | ||
| // Predict and explain first... | ||
|
|
||
| // =============> write your prediction here | ||
| // =============> write your prediction here : There is no return statement for the parameters. | ||
|
||
|
|
||
| function multiply(a, b) { | ||
| console.log(a * b); | ||
| } | ||
|
|
||
| console.log(`The result of multiplying 10 and 32 is ${multiply(10, 32)}`); | ||
|
|
||
| // =============> write your explanation here | ||
| // =============> write your explanation here : /* The function multiply does not return any value, it only logs the result to the console. It returns undefined. To fix this, we need to add a return statement in the multiply function. */ | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. excellent explanation! |
||
|
|
||
| // Finally, correct the code to fix the problem | ||
| // =============> write your new code here | ||
|
|
||
| function multiply(a, b) { | ||
| return a * b; | ||
| } | ||
| console.log(`The result of multiplying 10 and 32 is ${multiply(10, 32)}`); | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| // Predict and explain first... | ||
| // =============> write your prediction here | ||
| // =============> write your prediction here : A syntax error for the semicolon after return. | ||
|
|
||
| function sum(a, b) { | ||
| return; | ||
|
|
@@ -8,6 +8,11 @@ function sum(a, b) { | |
|
|
||
| console.log(`The sum of 10 and 32 is ${sum(10, 32)}`); | ||
|
|
||
| // =============> write your explanation here | ||
| // =============> write your explanation here : The semicolon after return at end of the statement. So there will be no value returned from the function. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think you are moving in the right direction but the explanation is not entirely correct. Think about this -- would just removing semicolon fix the function? |
||
|
|
||
| // Finally, correct the code to fix the problem | ||
| // =============> write your new code here | ||
| function sum(a, b) { | ||
| return a + b; | ||
| } | ||
| console.log(`The sum of 10 and 32 is ${sum(10, 32)}`); | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,5 +15,8 @@ | |
| // It should return their Body Mass Index to 1 decimal place | ||
|
|
||
| function calculateBMI(weight, height) { | ||
| // return the BMI of someone based off their weight and height | ||
| } | ||
| const bmi = weight / (height * height); | ||
| return bmi.toFixed(1); | ||
|
||
| // return the BMI of someone based off their weight and height | ||
| } | ||
| console.log(calculateBMI(75, 1.74)); | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,3 +14,9 @@ | |
| // You will need to come up with an appropriate name for the function | ||
| // Use the MDN string documentation to help you find a solution | ||
| // This might help https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/toUpperCase | ||
|
|
||
| function toUpperSnake(name) { | ||
| const upperCase = name.toUpperCase(); // Convert the string to uppercase | ||
| return upperCase.replaceAll(" ", "_"); // Replace all spaces with underscores | ||
| } | ||
| console.log(snakeItUp("alaa tagi is my name")); | ||
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,3 +4,23 @@ | |
| // You will need to declare a function called toPounds with an appropriately named parameter. | ||
|
|
||
| // You should call this function a number of times to check it works for different inputs | ||
|
|
||
| function toPounds(penceToPound) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Very cleanly written code with super descriptive variable names. Great job! |
||
| const penceStringWithoutTrailingP = penceToPound.substring(0, penceToPound.length - 1); // Remove the P at the end. | ||
| const paddedPenceNumberString = penceStringWithoutTrailingP.padStart(3, "0"); // Make sure there 3 digits at least. | ||
| const pounds = paddedPenceNumberString.substring( | ||
| 0, | ||
| paddedPenceNumberString.length - 2 | ||
| ); // get the pounds part( - the last two digits). | ||
| const pence = paddedPenceNumberString | ||
| .substring(paddedPenceNumberString.length - 2) | ||
| .padEnd(2, "0"); // get the pence part( they should be 2 digits). | ||
| return `£${pounds}.${pence}`; // The final format. | ||
| } | ||
| console.log(toPounds("3990p")); | ||
| console.log(toPounds("1500p")); | ||
| console.log(toPounds("150p")); | ||
| console.log(toPounds("100p")); | ||
| console.log(toPounds("70p")); | ||
| console.log(toPounds("50p")); | ||
| console.log(toPounds("0p")); | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,18 +17,18 @@ function formatTimeDisplay(seconds) { | |
| // Questions | ||
|
|
||
| // a) When formatTimeDisplay is called how many times will pad be called? | ||
| // =============> write your answer here | ||
| // =============> write your answer here : three times in Line 11 with return. | ||
|
|
||
| // Call formatTimeDisplay with an input of 61, now answer the following: | ||
|
|
||
| // b) What is the value assigned to num when pad is called for the first time? | ||
| // =============> write your answer here | ||
| // =============> write your answer here : 0, because totalHours is 0. | ||
|
|
||
| // c) What is the return value of pad is called for the first time? | ||
| // =============> write your answer here | ||
| // =============> write your answer here : "00", because num is converted to string and padded to 2 characters with "0". | ||
|
|
||
| // d) What is the value assigned to num when pad is called for the last time in this program? Explain your answer | ||
| // =============> write your answer here | ||
| // =============> write your answer here : 1, because remainingSeconds is 1 on python tutor. | ||
|
|
||
| // e) What is the return value assigned to num when pad is called for the last time in this program? Explain your answer | ||
| // =============> write your answer here | ||
| // =============> write your answer here : "00", because num is converted to string and padded to 2 characters with "0". That's mean "1" becomes "01". | ||
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,6 +2,7 @@ | |
| // Make sure to do the prep before you do the coursework | ||
| // Your task is to write tests for as many different groups of input data or edge cases as you can, and fix any bugs you find. | ||
|
|
||
| // The main function: | ||
| function formatAs12HourClock(time) { | ||
| const hours = Number(time.slice(0, 2)); | ||
| if (hours > 12) { | ||
|
|
@@ -10,16 +11,106 @@ function formatAs12HourClock(time) { | |
| return `${time} am`; | ||
| } | ||
|
|
||
| // Tests: | ||
| const currentOutput = formatAs12HourClock("08:00"); | ||
| const targetOutput = "08:00 am"; | ||
| console.assert( | ||
| currentOutput === targetOutput, | ||
| `current output: ${currentOutput}, target output: ${targetOutput}` | ||
| ); | ||
| ); // It's output is correct | ||
|
|
||
| const currentOutput2 = formatAs12HourClock("23:00"); | ||
| const targetOutput2 = "11:00 pm"; | ||
| console.assert( | ||
| currentOutput2 === targetOutput2, | ||
| `current output: ${currentOutput2}, target output: ${targetOutput2}` | ||
| ); | ||
| ); // It's output is correct | ||
|
|
||
| const currentOutput3 = formatAs12HourClock("12:00"); | ||
| const targetOutput3 = "12:00 pm"; | ||
| console.assert( | ||
| currentOutput3 === targetOutput3, | ||
| `current output: ${currentOutput3}, target output: ${targetOutput3}` | ||
| ); // It's output is incorrect because it returns "12:00 am" instead of "12:00 pm" | ||
|
|
||
| const currentOutput4 = formatAs12HourClock("00:00"); | ||
| const targetOutput4 = "12:00 am"; | ||
| console.assert( | ||
| currentOutput4 === targetOutput4, | ||
| `current output: ${currentOutput4}, target output: ${targetOutput4}` | ||
| ); // It's output is incorrect because it returns "00:00 am" instead of "12:00 am" | ||
|
|
||
| const currentOutput5 = formatAs12HourClock("15:30"); | ||
| const targetOutput5 = "3:30 pm"; | ||
| console.assert( | ||
| currentOutput5 === targetOutput5, | ||
| `current output: ${currentOutput5}, target output: ${targetOutput5}` | ||
| ); // It's output is incorrect because it returns "15:00 pm" instead of "3:30 pm" | ||
|
|
||
| const currentOutput6 = formatAs12HourClock("11:45"); | ||
| const targetOutput6 = "11:45 am"; | ||
| console.assert( | ||
| currentOutput6 === targetOutput6, | ||
| `current output: ${currentOutput6}, target output: ${targetOutput6}` | ||
| ); // It's output is correct | ||
|
|
||
| //Fixing the function: | ||
| function formatAs12HourClockFixed(time) { | ||
|
||
| const hours = Number(time.slice(0, 2)); | ||
| const minutes = time.slice(3, 5); | ||
| let period = "am"; | ||
|
|
||
| if (hours === 0) { | ||
| return `12:${minutes} am`; | ||
| } | ||
| if (hours === 12) { | ||
| period = "pm"; | ||
| } | ||
| if (hours > 12) { | ||
| return `${hours - 12}:${minutes} pm`; | ||
| } | ||
| return `${hours}:${minutes} ${period}`; | ||
| } | ||
|
|
||
| // Re-testing : | ||
| const currentOutput1 = formatAs12HourClockFixed("08:00"); | ||
| const targetOutput1 = "8:00 am"; | ||
| console.assert( | ||
| currentOutput1 === targetOutput1, | ||
| `current output: ${currentOutput1}, target output: ${targetOutput1}` | ||
| ); // It's output is correct | ||
|
|
||
| const currentOutput2 = formatAs12HourClockFixed("23:00"); | ||
| const targetOutput2 = "11:00 pm"; | ||
| console.assert( | ||
| currentOutput2 === targetOutput2, | ||
| `current output: ${currentOutput2}, target output: ${targetOutput2}` | ||
| ); // It's output is correct | ||
|
|
||
| const currentOutput3 = formatAs12HourClockFixed("12:00"); | ||
| const targetOutput3 = "12:00 pm"; | ||
| console.assert( | ||
| currentOutput3 === targetOutput3, | ||
| `current output: ${currentOutput3}, target output: ${targetOutput3}` | ||
| ); // It's output is correct | ||
|
|
||
| const currentOutput4 = formatAs12HourClockFixed("00:00"); | ||
| const targetOutput4 = "12:00 am"; | ||
| console.assert( | ||
| currentOutput4 === targetOutput4, | ||
| `current output: ${currentOutput4}, target output: ${targetOutput4}` | ||
| ); // It's output is correct | ||
|
|
||
| const currentOutput5 = formatAs12HourClockFixed("15:30"); | ||
| const targetOutput5 = "3:30 pm"; | ||
| console.assert( | ||
| currentOutput5 === targetOutput5, | ||
| `current output: ${currentOutput5}, target output: ${targetOutput5}` | ||
| ); // It's output is correct | ||
|
|
||
| const currentOutput6 = formatAs12HourClockFixed("11:45"); | ||
| const targetOutput6 = "11:45 am"; | ||
| console.assert( | ||
| currentOutput6 === targetOutput6, | ||
| `current output: ${currentOutput6}, target output: ${targetOutput6}` | ||
| ); // It's output is correct | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function has another syntax error after you made some changes. Could you please fix it?