From b5de08b92f56bc5424c222b51101f87db10599ef Mon Sep 17 00:00:00 2001
From: Alaa Tagi <alaa3litagi1994@gmail.com>
Date: Thu, 9 Oct 2025 19:31:45 +0100
Subject: [PATCH 01/18] build up getAngleType case by case

---
 .../implement/1-get-angle-type.js             | 40 ++++++++++++++++---
 1 file changed, 35 insertions(+), 5 deletions(-)

diff --git a/Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js b/Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js
index ca1dfe7f2..207ff21da 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js
@@ -11,8 +11,19 @@ function getAngleType(angle) {
   if (angle === 90) {
     return "Right angle";
   }
-   // Run the tests, work out what Case 2 is testing, and implement the required code here.
-   // Then keep going for the other cases, one at a time.
+  if (angle < 90 && angle > 0) {
+    return "Acute angle";
+  }
+  if (angle > 90 && angle < 180) {
+    return "Obtuse angle";
+  }
+  if (angle === 180) {
+    return "Straight angle";
+  }
+  if (angle > 180 && angle < 360) {
+    return "Reflex angle";
+  }
+  return "Invalid angle";
 }
 
 // The line below allows us to load the getAngleType function into tests in other files.
@@ -50,14 +61,33 @@ assertEquals(acute, "Acute angle");
 // When the angle is greater than 90 degrees and less than 180 degrees,
 // Then the function should return "Obtuse angle"
 const obtuse = getAngleType(120);
-// ====> write your test here, and then add a line to pass the test in the function above
+assertEquals(obtuse, "Obtuse angle");
 
 // Case 4: Identify Straight Angles:
 // When the angle is exactly 180 degrees,
 // Then the function should return "Straight angle"
 // ====> write your test here, and then add a line to pass the test in the function above
-
+const straight = getAngleType(180);
+assertEquals(straight, "Straight angle");
 // Case 5: Identify Reflex Angles:
 // When the angle is greater than 180 degrees and less than 360 degrees,
 // Then the function should return "Reflex angle"
-// ====> write your test here, and then add a line to pass the test in the function above
\ No newline at end of file
+// ====> write your test here, and then add a line to pass the test in the function above
+const reflex = getAngleType(270);
+assertEquals(reflex, "Reflex angle");
+
+let angle = 120;
+console.log(angle + " degrees is a " + getAngleType(angle));
+angle = 45;
+console.log(angle + " degrees is a " + getAngleType(angle));
+angle = 90;
+console.log(angle + " degrees is a " + getAngleType(angle));
+angle = 180;
+console.log(angle + " degrees is a " + getAngleType(angle));
+angle = 270;
+console.log(angle + " degrees is a " + getAngleType(angle));
+angle = -10;
+console.log(angle + " degrees is a " + getAngleType(angle));
+angle = 400;
+console.log(angle + " degrees is a " + getAngleType(angle));
+// Case 6: Handle Invalid Angles:
\ No newline at end of file

From b5fa5623635ba04455f2530d92a8c18a8d9f11f4 Mon Sep 17 00:00:00 2001
From: Alaa Tagi <alaa3litagi1994@gmail.com>
Date: Thu, 9 Oct 2025 20:08:09 +0100
Subject: [PATCH 02/18] Editing is-proper-fraction code

---
 .../implement/2-is-proper-fraction.js         | 49 +++++++++++++++++++
 1 file changed, 49 insertions(+)

diff --git a/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js b/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js
index a4739af77..18ccba064 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js
@@ -11,6 +11,13 @@ function isProperFraction(numerator, denominator) {
   if (numerator < denominator) {
     return true;
   }
+  if (numerator < 0 && Math.abs(numerator) < denominator) {
+    return true;
+  } 
+  if (numerator >= denominator) {
+    return false;
+  }
+  // we could add more checks here for invalid input, but not required for this exercise
 }
 
 // The line below allows us to load the isProperFraction function into tests in other files.
@@ -47,6 +54,7 @@ assertEquals(improperFraction, false);
 // Explanation: The fraction -4/7 is a proper fraction because the absolute value of the numerator (4) is less than the denominator (7). The function should return true.
 const negativeFraction = isProperFraction(-4, 7);
 // ====> complete with your assertion
+assertEquals(negativeFraction, true);
 
 // Equal Numerator and Denominator check:
 // Input: numerator = 3, denominator = 3
@@ -54,6 +62,47 @@ const negativeFraction = isProperFraction(-4, 7);
 // Explanation: The fraction 3/3 is not a proper fraction because the numerator is equal to the denominator. The function should return false.
 const equalFraction = isProperFraction(3, 3);
 // ====> complete with your assertion
+assertEquals(equalFraction, false);
 
 // Stretch:
 // What other scenarios could you test for?
+
+
+// Zero Numerator check:
+// Input: numerator = 0, denominator = 5
+// target output: true
+// Explanation: The fraction 0/5 is a proper fraction because the numerator (0) is less than the denominator (5). The function should return true.
+const zeroNumerator = isProperFraction(0, 5);
+assertEquals(zeroNumerator, true);
+
+// Negative Denominator check:
+// Input: numerator = 2, denominator = -3
+// target output: false
+// Explanation: The fraction 2/-3 is not a proper fraction because the denominator is negative. The function should return false.
+const negativeDenominator = isProperFraction(2, -3);
+assertEquals(negativeDenominator, false);
+
+let numerator= 1;
+let denominator= 7;
+console.log(numerator + "/" + denominator + " check =", isProperFraction(numerator, denominator));
+numerator= 5;
+denominator= 1;
+console.log(numerator + "/" + denominator + " check =", isProperFraction(numerator, denominator));
+numerator= -4;
+denominator= 9;
+console.log(numerator + "/" + denominator + " check =", isProperFraction(numerator, denominator));
+numerator= 0;
+denominator= 6;
+console.log(numerator + "/" + denominator + " check =", isProperFraction(numerator, denominator));   
+numerator= 4;
+denominator= 4;
+console.log(numerator + "/" + denominator + " check =", isProperFraction(numerator, denominator));
+numerator= -5;
+denominator= 8;
+console.log(numerator + "/" + denominator + " check =", isProperFraction(numerator, denominator));
+numerator= 4;
+denominator= -2;
+console.log(numerator + "/" + denominator + " check =", isProperFraction(numerator, denominator));
+numerator= -3;
+denominator= -7;
+console.log(numerator + "/" + denominator + " check =", isProperFraction(numerator, denominator));
\ No newline at end of file

From 3898643f5caa0672cdb6664c7944405dcb13250c Mon Sep 17 00:00:00 2001
From: Alaa Tagi <alaa3litagi1994@gmail.com>
Date: Sun, 12 Oct 2025 15:19:22 +0100
Subject: [PATCH 03/18] Editing getcardvalue code

---
 .../implement/3-get-card-value.js             | 41 ++++++++++++++++++-
 1 file changed, 40 insertions(+), 1 deletion(-)

diff --git a/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js b/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js
index 266525d1b..8c9901688 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js
@@ -8,9 +8,17 @@
 // write one test at a time, and make it pass, build your solution up methodically
 // just make one change at a time -- don't rush -- programmers are deep and careful thinkers
 function getCardValue(card) {
+  const rank = card.slice(0, -1); 
   if (rank === "A") {
     return 11;
   }
+  if (["10", "J", "Q", "K"].includes(rank)) {
+    return 10;
+  }
+  if (["2", "3", "4", "5", "6", "7", "8", "9"].includes(rank)) {
+    return parseInt(rank, 10);
+  }
+  return "Invalid card rank";
 }
 
 // The line below allows us to load the getCardValue function into tests in other files.
@@ -38,20 +46,51 @@ assertEquals(aceofSpades, 11);
 // Given a card with a rank between "2" and "9",
 // When the function is called with such a card,
 // Then it should return the numeric value corresponding to the rank (e.g., "5" should return 5).
-const fiveofHearts = getCardValue("5♥");
+const fiveofHearts = getCardValue("5♥"); 
 // ====> write your test here, and then add a line to pass the test in the function above
+assertEquals(fiveofHearts, 5);
 
 // Handle Face Cards (J, Q, K):
 // Given a card with a rank of "10," "J," "Q," or "K",
 // When the function is called with such a card,
 // Then it should return the value 10, as these cards are worth 10 points each in blackjack.
+const kingofDiamonds = getCardValue("K♦");
+assertEquals(kingofDiamonds, 10);
+
+const jackofHearts = getCardValue("J♥");
+assertEquals(jackofHearts, 10);
+
+const queenofSpades = getCardValue("Q♠");
+assertEquals(queenofSpades, 10);
+
+const tenofClubs = getCardValue("10♣");
+assertEquals(tenofClubs, 10);
 
 // Handle Ace (A):
 // Given a card with a rank of "A",
 // When the function is called with an Ace,
 // Then it should, by default, assume the Ace is worth 11 points, which is a common rule in blackjack.
+const aceofClubs = getCardValue("A♣");
+assertEquals(aceofClubs, 11);
 
 // Handle Invalid Cards:
 // Given a card with an invalid rank (neither a number nor a recognized face card),
 // When the function is called with such a card,
 // Then it should throw an error indicating "Invalid card rank."
+const invalidCard = getCardValue("1♠");
+assertEquals(invalidCard, "Invalid card rank"); 
+const invalidCard2 = getCardValue("11♠");
+assertEquals(invalidCard2, "Invalid card rank");
+const invalidCard3 = getCardValue("B♠");
+assertEquals(invalidCard3, "Invalid card rank");
+
+
+console.log( getCardValue("1♠"));
+console.log( getCardValue("11♠"));
+console.log( getCardValue("B♠"));
+console.log( getCardValue("3♠"));
+console.log( getCardValue("10♠"));
+console.log( getCardValue("J♠"));
+console.log( getCardValue("Q♠"));
+console.log( getCardValue("K♠"));
+console.log( getCardValue("A♠"));
\ No newline at end of file

From 78d374ace8edd4e7856b187dfe94da58b9ee7998 Mon Sep 17 00:00:00 2001
From: Alaa Tagi <alaa3litagi1994@gmail.com>
Date: Sun, 12 Oct 2025 16:01:55 +0100
Subject: [PATCH 04/18] rewrite test with jest for getangletype code

---
 .../1-get-angle-type.test.js                      | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js
index 4a92a3e82..43c137184 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js
@@ -12,15 +12,24 @@ test("should identify right angle (90°)", () => {
 // Case 2: Identify Acute Angles:
 // When the angle is less than 90 degrees,
 // Then the function should return "Acute angle"
-
+test("should identify acute angle (<90°)", () => {
+  expect(getAngleType(45)).toEqual("Acute angle");
+});
 // Case 3: Identify Obtuse Angles:
 // When the angle is greater than 90 degrees and less than 180 degrees,
 // Then the function should return "Obtuse angle"
-
+test("should identify obtuse angle (90°<angle<180°)", () => {
+  expect(getAngleType(120)).toEqual("Obtuse angle");
+});
 // Case 4: Identify Straight Angles:
 // When the angle is exactly 180 degrees,
 // Then the function should return "Straight angle"
-
+test("should identify straight angle (180°)", () => {
+  expect(getAngleType(180)).toEqual("Straight angle");
+});
 // Case 5: Identify Reflex Angles:
 // When the angle is greater than 180 degrees and less than 360 degrees,
 // Then the function should return "Reflex angle"
+test("should identify reflex angle (180°<angle<360°)", () => {
+  expect(getAngleType(270)).toEqual("Reflex angle");
+});

From d07dd99cfb4c188ecb87a1f87c92561857c1a57b Mon Sep 17 00:00:00 2001
From: Alaa Tagi <alaa3litagi1994@gmail.com>
Date: Sun, 12 Oct 2025 16:35:13 +0100
Subject: [PATCH 05/18] update isproperfraction code

---
 .../implement/2-is-proper-fraction.js                    | 4 ++--
 .../rewrite-tests-with-jest/2-is-proper-fraction.test.js | 9 +++++++++
 2 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js b/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js
index 18ccba064..06354d58e 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js
@@ -12,7 +12,7 @@ function isProperFraction(numerator, denominator) {
     return true;
   }
   if (numerator < 0 && Math.abs(numerator) < denominator) {
-    return true;
+    return false;
   } 
   if (numerator >= denominator) {
     return false;
@@ -80,7 +80,7 @@ assertEquals(zeroNumerator, true);
 // target output: false
 // Explanation: The fraction 2/-3 is not a proper fraction because the denominator is negative. The function should return false.
 const negativeDenominator = isProperFraction(2, -3);
-assertEquals(negativeDenominator, false);
+assertEquals(negativeDenominator, true);
 
 let numerator= 1;
 let denominator= 7;
diff --git a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
index caf08d15b..c82369945 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
@@ -7,7 +7,16 @@ test("should return true for a proper fraction", () => {
 });
 
 // Case 2: Identify Improper Fractions:
+test("should return false for an improper fraction", () => {
+  expect(isProperFraction(5, 2)).toEqual(false);
+});
 
 // Case 3: Identify Negative Fractions:
+test("should return false for a negative fraction", () => {
+  expect(isProperFraction(-1, 2)).toEqual(false);
+});
 
 // Case 4: Identify Equal Numerator and Denominator:
+test("should return false for equal numerator and denominator", () => {
+  expect(isProperFraction(3, 3)).toEqual(false);
+});

From a223e457ffc4061f588d7a96b9e1d57f9abe3039 Mon Sep 17 00:00:00 2001
From: Alaa Tagi <alaa3litagi1994@gmail.com>
Date: Sun, 12 Oct 2025 16:38:37 +0100
Subject: [PATCH 06/18] Rewrite test with jest for isproperfraction code

---
 .../rewrite-tests-with-jest/2-is-proper-fraction.test.js        | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
index c82369945..e5708a95a 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
@@ -13,7 +13,7 @@ test("should return false for an improper fraction", () => {
 
 // Case 3: Identify Negative Fractions:
 test("should return false for a negative fraction", () => {
-  expect(isProperFraction(-1, 2)).toEqual(false);
+  expect(isProperFraction(-1, 2)).toEqual(true);
 });
 
 // Case 4: Identify Equal Numerator and Denominator:

From 17435c8dc741f1e426e208505817aff8fb393bca Mon Sep 17 00:00:00 2001
From: Alaa-Tagi <alaa3litagi1994@gmail.com>
Date: Thu, 23 Oct 2025 19:59:33 +0100
Subject: [PATCH 07/18] update the code

---
 .../1-implement-and-rewrite-tests/implement/1-get-angle-type.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js b/Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js
index 207ff21da..8665ab246 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js
@@ -14,7 +14,7 @@ function getAngleType(angle) {
   if (angle < 90 && angle > 0) {
     return "Acute angle";
   }
-  if (angle > 90 && angle < 180) {
+  if (angle < 180) {
     return "Obtuse angle";
   }
   if (angle === 180) {

From 63246cad03d5df9f29f7fb2205451ba3fc1842ed Mon Sep 17 00:00:00 2001
From: Alaa-Tagi <alaa3litagi1994@gmail.com>
Date: Thu, 23 Oct 2025 20:39:00 +0100
Subject: [PATCH 08/18] Editing the code

---
 .../implement/2-is-proper-fraction.js                | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js b/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js
index 06354d58e..03e692348 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js
@@ -8,16 +8,10 @@
 // write one test at a time, and make it pass, build your solution up methodically
 
 function isProperFraction(numerator, denominator) {
-  if (numerator < denominator) {
-    return true;
-  }
-  if (numerator < 0 && Math.abs(numerator) < denominator) {
-    return false;
+  if (denominator === 0) {
+    return false; 
   } 
-  if (numerator >= denominator) {
-    return false;
-  }
-  // we could add more checks here for invalid input, but not required for this exercise
+  return Math.abs(numerator) < Math.abs(denominator);
 }
 
 // The line below allows us to load the isProperFraction function into tests in other files.

From b5c55bd9d8bb5f9f8fa7fecfa6c9f8c9aad46623 Mon Sep 17 00:00:00 2001
From: Alaa-Tagi <alaa3litagi1994@gmail.com>
Date: Thu, 23 Oct 2025 20:50:32 +0100
Subject: [PATCH 09/18] edit the code

---
 .../rewrite-tests-with-jest/2-is-proper-fraction.test.js        | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
index e5708a95a..2c079bb22 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
@@ -4,6 +4,8 @@ const isProperFraction = require("../implement/2-is-proper-fraction");
 
 test("should return true for a proper fraction", () => {
   expect(isProperFraction(2, 3)).toEqual(true);
+  
+
 });
 
 // Case 2: Identify Improper Fractions:

From a3c8fc886400003969d6a928f566bed1624d38b7 Mon Sep 17 00:00:00 2001
From: Alaa-Tagi <alaa3litagi1994@gmail.com>
Date: Thu, 23 Oct 2025 20:53:00 +0100
Subject: [PATCH 10/18] editing the code

---
 .../rewrite-tests-with-jest/2-is-proper-fraction.test.js      | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
index 2c079bb22..f628bdb66 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
@@ -5,7 +5,6 @@ const isProperFraction = require("../implement/2-is-proper-fraction");
 test("should return true for a proper fraction", () => {
   expect(isProperFraction(2, 3)).toEqual(true);
   
-
 });
 
 // Case 2: Identify Improper Fractions:
@@ -21,4 +20,7 @@ test("should return false for a negative fraction", () => {
 // Case 4: Identify Equal Numerator and Denominator:
 test("should return false for equal numerator and denominator", () => {
   expect(isProperFraction(3, 3)).toEqual(false);
+  expect(isProperFraction(-3, 3)).toEqual(false);
+  expect(isProperFraction(3, -3)).toEqual(false);
+  expect(isProperFraction(-3, -3)).toEqual(false);
 });

From 991832ef801d09431da9f9f89da65e25c5f9f467 Mon Sep 17 00:00:00 2001
From: Alaa-Tagi <alaa3litagi1994@gmail.com>
Date: Fri, 24 Oct 2025 20:05:37 +0100
Subject: [PATCH 11/18] Enhance Jest tests for isProperFraction function

Expanded test cases for isProperFraction function to include various scenarios such as negative fractions, zero numerator, negative denominator, and large numbers.
---
 .../2-is-proper-fraction.test.js              | 49 +++++++++++++++----
 1 file changed, 39 insertions(+), 10 deletions(-)

diff --git a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
index f628bdb66..199180358 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
@@ -1,26 +1,55 @@
-// This statement loads the isProperFraction function you wrote in the implement directory.
-// We will use the same function, but write tests for it using Jest in this file.
 const isProperFraction = require("../implement/2-is-proper-fraction");
 
+// Case 1: Proper fraction
+// When numerator < denominator, it should return true.
 test("should return true for a proper fraction", () => {
   expect(isProperFraction(2, 3)).toEqual(true);
-  
 });
 
-// Case 2: Identify Improper Fractions:
+// Case 2: Improper fraction
+// When numerator > denominator, it should return false.
 test("should return false for an improper fraction", () => {
   expect(isProperFraction(5, 2)).toEqual(false);
 });
 
-// Case 3: Identify Negative Fractions:
-test("should return false for a negative fraction", () => {
+// Case 3: Negative proper fraction
+// When numerator is negative but |numerator| < |denominator|, it should return true.
+test("should return true for a negative proper fraction", () => {
   expect(isProperFraction(-1, 2)).toEqual(true);
 });
 
-// Case 4: Identify Equal Numerator and Denominator:
+// Case 4: Equal numerator and denominator
+// When numerator === denominator, it should return false.
 test("should return false for equal numerator and denominator", () => {
   expect(isProperFraction(3, 3)).toEqual(false);
-  expect(isProperFraction(-3, 3)).toEqual(false);
-  expect(isProperFraction(3, -3)).toEqual(false);
-  expect(isProperFraction(-3, -3)).toEqual(false);
+});
+
+// Case 5: Zero numerator
+// 0 divided by any non-zero denominator is a proper fraction.
+test("should return true for zero numerator", () => {
+  expect(isProperFraction(0, 5)).toEqual(true);
+});
+
+// Case 6: Negative denominator
+// When denominator is negative, the fraction is still valid, so check absolute values.
+test("should return true when denominator is negative but |numerator| < |denominator|", () => {
+  expect(isProperFraction(2, -3)).toEqual(true);
+});
+
+// Case 7: Denominator is zero
+// Division by zero is undefined, should return false.
+test("should return false when denominator is zero", () => {
+  expect(isProperFraction(3, 0)).toEqual(false);
+});
+
+// Case 8: Both numerator and denominator are negative but |numerator| < |denominator|
+// Negative/negative cancels out, still a proper fraction.
+test("should return true when both numerator and denominator are negative and |numerator| < |denominator|", () => {
+  expect(isProperFraction(-3, -7)).toEqual(true);
+});
+
+// Case 9: Large numbers
+// It should handle large numbers correctly.
+test("should return true for large proper fractions", () => {
+  expect(isProperFraction(999, 1000)).toEqual(true);
 });

From f52bd8ddf8b2cd3e8b400f93aabc0c8426a36915 Mon Sep 17 00:00:00 2001
From: Alaa-Tagi <alaa3litagi1994@gmail.com>
Date: Fri, 24 Oct 2025 20:13:07 +0100
Subject: [PATCH 12/18] Fix the code

Refactor isProperFraction function to include input type checks and handle division by zero. Update logic to determine if a fraction is proper based on the value of the numerator and denominator.
---
 .../implement/2-is-proper-fraction.js         | 23 ++++++++-----------
 1 file changed, 10 insertions(+), 13 deletions(-)

diff --git a/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js b/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js
index 03e692348..76bcfa4c8 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js
@@ -8,23 +8,20 @@
 // write one test at a time, and make it pass, build your solution up methodically
 
 function isProperFraction(numerator, denominator) {
+  if (typeof numerator !== "number" || typeof denominator !== "number") {
+    return false; // Invalid input types
+  }
+
   if (denominator === 0) {
-    return false; 
-  } 
-  return Math.abs(numerator) < Math.abs(denominator);
+    return false; // Division by zero is undefined
+  }
+
+  const value = numerator / denominator;
+  return Math.abs(value) < 1; // Proper fraction if the value is between -1 and 1
 }
 
-// The line below allows us to load the isProperFraction function into tests in other files.
-// This will be useful in the "rewrite tests with jest" step.
 module.exports = isProperFraction;
 
-// here's our helper again
-function assertEquals(actualOutput, targetOutput) {
-  console.assert(
-    actualOutput === targetOutput,
-    `Expected ${actualOutput} to equal ${targetOutput}`
-  );
-}
 
 // Acceptance criteria:
 
@@ -99,4 +96,4 @@ denominator= -2;
 console.log(numerator + "/" + denominator + " check =", isProperFraction(numerator, denominator));
 numerator= -3;
 denominator= -7;
-console.log(numerator + "/" + denominator + " check =", isProperFraction(numerator, denominator));
\ No newline at end of file
+console.log(numerator + "/" + denominator + " check =", isProperFraction(numerator, denominator));

From 52740052fb0ad97a2c7253a04978b14a15b9e763 Mon Sep 17 00:00:00 2001
From: Alaa-Tagi <alaa3litagi1994@gmail.com>
Date: Fri, 24 Oct 2025 20:14:18 +0100
Subject: [PATCH 13/18] Editing the jest code

Updated test cases for isProperFraction function to improve clarity and coverage. Added detailed descriptions for each test case.
---
 .../2-is-proper-fraction.test.js              | 78 +++++++++++--------
 1 file changed, 44 insertions(+), 34 deletions(-)

diff --git a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
index 199180358..574dfd5d7 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
@@ -1,55 +1,65 @@
 const isProperFraction = require("../implement/2-is-proper-fraction");
 
-// Case 1: Proper fraction
-// When numerator < denominator, it should return true.
-test("should return true for a proper fraction", () => {
+// Case 1: Proper Fraction
+// Given a numerator smaller than denominator (2/3),
+// When the function is called,
+// Then it should return true because it's a proper fraction.
+test("should return true for a proper fraction (2/3)", () => {
   expect(isProperFraction(2, 3)).toEqual(true);
 });
 
-// Case 2: Improper fraction
-// When numerator > denominator, it should return false.
-test("should return false for an improper fraction", () => {
+// Case 2: Improper Fraction
+// Given a numerator greater than denominator (5/2),
+// When the function is called,
+// Then it should return false because it's an improper fraction.
+test("should return false for an improper fraction (5/2)", () => {
   expect(isProperFraction(5, 2)).toEqual(false);
 });
 
-// Case 3: Negative proper fraction
-// When numerator is negative but |numerator| < |denominator|, it should return true.
-test("should return true for a negative proper fraction", () => {
+// Case 3: Negative Proper Fraction
+// Given a negative proper fraction (-1/2),
+// When the function is called,
+// Then it should return true because the value is between -1 and 1.
+test("should return true for a negative proper fraction (-1/2)", () => {
   expect(isProperFraction(-1, 2)).toEqual(true);
 });
 
-// Case 4: Equal numerator and denominator
-// When numerator === denominator, it should return false.
-test("should return false for equal numerator and denominator", () => {
+// Case 4: Equal Numerator and Denominator
+// Given a numerator equal to denominator (3/3),
+// When the function is called,
+// Then it should return false because it's equal to 1 (not proper).
+test("should return false for equal numerator and denominator (3/3)", () => {
   expect(isProperFraction(3, 3)).toEqual(false);
 });
 
-// Case 5: Zero numerator
-// 0 divided by any non-zero denominator is a proper fraction.
-test("should return true for zero numerator", () => {
-  expect(isProperFraction(0, 5)).toEqual(true);
-});
-
-// Case 6: Negative denominator
-// When denominator is negative, the fraction is still valid, so check absolute values.
-test("should return true when denominator is negative but |numerator| < |denominator|", () => {
-  expect(isProperFraction(2, -3)).toEqual(true);
+// Case 5: Negative Improper Fraction
+// Given a negative improper fraction (-4/3),
+// When the function is called,
+// Then it should return false because the absolute value is greater than 1.
+test("should return false for a negative improper fraction (-4/3)", () => {
+  expect(isProperFraction(-4, 3)).toEqual(false);
 });
 
-// Case 7: Denominator is zero
-// Division by zero is undefined, should return false.
-test("should return false when denominator is zero", () => {
-  expect(isProperFraction(3, 0)).toEqual(false);
+// Case 6: Both Negative (Proper Fraction)
+// Given both numerator and denominator negative (-2/-3),
+// When the function is called,
+// Then it should return true because the value is positive and less than 1.
+test("should return true for both negative proper fraction (-2/-3)", () => {
+  expect(isProperFraction(-2, -3)).toEqual(true);
 });
 
-// Case 8: Both numerator and denominator are negative but |numerator| < |denominator|
-// Negative/negative cancels out, still a proper fraction.
-test("should return true when both numerator and denominator are negative and |numerator| < |denominator|", () => {
-  expect(isProperFraction(-3, -7)).toEqual(true);
+// Case 7: Zero Numerator
+// Given a numerator of 0 (0/5),
+// When the function is called,
+// Then it should return true because 0 is less than any nonzero denominator.
+test("should return true for zero numerator (0/5)", () => {
+  expect(isProperFraction(0, 5)).toEqual(true);
 });
 
-// Case 9: Large numbers
-// It should handle large numbers correctly.
-test("should return true for large proper fractions", () => {
-  expect(isProperFraction(999, 1000)).toEqual(true);
+// Case 8: Zero Denominator
+// Given a denominator of 0 (5/0),
+// When the function is called,
+// Then it should return false because division by zero is undefined.
+test("should return false for zero denominator (5/0)", () => {
+  expect(isProperFraction(5, 0)).toEqual(false);
 });

From 7bc1534d886a613974eb21da7d4911b52e3a91fd Mon Sep 17 00:00:00 2001
From: Alaa-Tagi <alaa3litagi1994@gmail.com>
Date: Sat, 25 Oct 2025 17:56:30 +0100
Subject: [PATCH 14/18] Editing code

---
 .../implement/2-is-proper-fraction.js         |  5 ++
 .../2-is-proper-fraction.test.js              | 58 +++++++++++++++++++
 .../3-get-card-value.test.js                  | 33 +++++++++++
 3 files changed, 96 insertions(+)

diff --git a/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js b/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js
index 76bcfa4c8..97de90d81 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js
@@ -8,8 +8,13 @@
 // write one test at a time, and make it pass, build your solution up methodically
 
 function isProperFraction(numerator, denominator) {
+<<<<<<< HEAD
+  if (denominator) {
+    return true;
+=======
   if (typeof numerator !== "number" || typeof denominator !== "number") {
     return false; // Invalid input types
+>>>>>>> 52740052fb0ad97a2c7253a04978b14a15b9e763
   }
 
   if (denominator === 0) {
diff --git a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
index 574dfd5d7..d23ebd24b 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
@@ -1,37 +1,93 @@
 const isProperFraction = require("../implement/2-is-proper-fraction");
 
+<<<<<<< HEAD
+// Case 1: Proper fraction
+// When numerator < denominator, it should return true.
+test("should return true for a proper fraction", () => {
+=======
 // Case 1: Proper Fraction
 // Given a numerator smaller than denominator (2/3),
 // When the function is called,
 // Then it should return true because it's a proper fraction.
 test("should return true for a proper fraction (2/3)", () => {
+>>>>>>> 52740052fb0ad97a2c7253a04978b14a15b9e763
   expect(isProperFraction(2, 3)).toEqual(true);
 });
 
+<<<<<<< HEAD
+// Case 2: Improper fraction
+// When numerator > denominator, it should return false.
+test("should return false for an improper fraction", () => {
+=======
 // Case 2: Improper Fraction
 // Given a numerator greater than denominator (5/2),
 // When the function is called,
 // Then it should return false because it's an improper fraction.
 test("should return false for an improper fraction (5/2)", () => {
+>>>>>>> 52740052fb0ad97a2c7253a04978b14a15b9e763
   expect(isProperFraction(5, 2)).toEqual(false);
 });
 
+<<<<<<< HEAD
+// Case 3: Negative proper fraction
+// When numerator is negative but |numerator| < |denominator|, it should return true.
+test("should return true for a negative proper fraction", () => {
+=======
 // Case 3: Negative Proper Fraction
 // Given a negative proper fraction (-1/2),
 // When the function is called,
 // Then it should return true because the value is between -1 and 1.
 test("should return true for a negative proper fraction (-1/2)", () => {
+>>>>>>> 52740052fb0ad97a2c7253a04978b14a15b9e763
   expect(isProperFraction(-1, 2)).toEqual(true);
 });
 
+<<<<<<< HEAD
+// Case 4: Equal numerator and denominator
+// When numerator === denominator, it should return false.
+test("should return false for equal numerator and denominator", () => {
+=======
 // Case 4: Equal Numerator and Denominator
 // Given a numerator equal to denominator (3/3),
 // When the function is called,
 // Then it should return false because it's equal to 1 (not proper).
 test("should return false for equal numerator and denominator (3/3)", () => {
+>>>>>>> 52740052fb0ad97a2c7253a04978b14a15b9e763
   expect(isProperFraction(3, 3)).toEqual(false);
 });
 
+<<<<<<< HEAD
+// Case 5: Zero numerator
+// 0 divided by any non-zero denominator is a proper fraction.
+test("should return true for zero numerator", () => {
+  expect(isProperFraction(0, 5)).toEqual(true);
+});
+
+// Case 6: Negative denominator
+// When denominator is negative, the fraction is still valid, so check absolute values.
+test("should return true when denominator is negative but |numerator| < |denominator|", () => {
+  expect(isProperFraction(2, -3)).toEqual(true);
+});
+
+// Case 7: Denominator is zero
+// Division by zero is undefined, should return false.
+test("should return false when denominator is zero", () => {
+  expect(isProperFraction(3, 0)).toEqual(false);
+});
+
+// Case 8: Both numerator and denominator are negative but |numerator| < |denominator|
+// Negative/negative cancels out, still a proper fraction.
+test("should return true when both numerator and denominator are negative and |numerator| < |denominator|", () => {
+  expect(isProperFraction(-3, -7)).toEqual(true);
+});
+
+// Case 9: Large numbers
+// It should handle large numbers correctly.
+test("should return true for large proper fractions", () => {
+  expect(isProperFraction(999, 1000)).toEqual(true);
+});
+
+=======
 // Case 5: Negative Improper Fraction
 // Given a negative improper fraction (-4/3),
 // When the function is called,
@@ -63,3 +119,5 @@ test("should return true for zero numerator (0/5)", () => {
 test("should return false for zero denominator (5/0)", () => {
   expect(isProperFraction(5, 0)).toEqual(false);
 });
+
+>>>>>>> 52740052fb0ad97a2c7253a04978b14a15b9e763
\ No newline at end of file
diff --git a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js
index 04418ff72..31fa848f3 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js
@@ -8,6 +8,39 @@ test("should return 11 for Ace of Spades", () => {
 });
 
 // Case 2: Handle Number Cards (2-10):
+test("should return 7 for 7 of Hearts", () => {
+  const sevenOfHearts = getCardValue("7♥");
+  expect(sevenOfHearts).toEqual(7);
+});
 // Case 3: Handle Face Cards (J, Q, K):
+test("should return 10 for Jack of Diamonds", () => {
+  const jackOfDiamonds = getCardValue("J♦");
+  expect(jackOfDiamonds).toEqual(10);
+});
+
+//Case 4
+test("should return 10 for Queen of Clubs", () => {
+  const queenOfClubs = getCardValue("Q♣");
+  expect(queenOfClubs).toEqual(10);
+});
+
+test("should return 10 for King of Spades", () => {
+  const kingOfSpades = getCardValue("K♠");
+  expect(kingOfSpades).toEqual(10);
+});
+
 // Case 4: Handle Ace (A):
+test("should return 11 for Ace of Diamonds", () => {
+  const aceOfDiamonds = getCardValue("A♦");
+  expect(aceOfDiamonds).toEqual(11);
+});
 // Case 5: Handle Invalid Cards:
+test("should return null for invalid card '1X'", () => {
+  const invalidCard1 = getCardValue("1X");
+  expect(invalidCard1).toBe("Invalid card rank");
+});
+test("should return null for invalid card '11H'", () => {
+  const invalidCard2 = getCardValue("11H");
+  expect(invalidCard2).toBe("Invalid card rank");
+});
+

From 5e63f6863649fd5ba9d756b8a9eab2d5af39a649 Mon Sep 17 00:00:00 2001
From: Alaa-Tagi <alaa3litagi1994@gmail.com>
Date: Sun, 26 Oct 2025 15:20:44 +0000
Subject: [PATCH 15/18] update the jest code

---
 .../3-get-card-value.test.js                  | 46 +++++++------------
 1 file changed, 16 insertions(+), 30 deletions(-)

diff --git a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js
index 31fa848f3..89cef94da 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js
@@ -8,39 +8,25 @@ test("should return 11 for Ace of Spades", () => {
 });
 
 // Case 2: Handle Number Cards (2-10):
-test("should return 7 for 7 of Hearts", () => {
-  const sevenOfHearts = getCardValue("7♥");
-  expect(sevenOfHearts).toEqual(7);
+test("should return correct value for numbered cards (2-10)", () => {
+  expect(getCardValue("5♥")).toBe(5);
+  expect(getCardValue("10♦")).toBe(10);
 });
 // Case 3: Handle Face Cards (J, Q, K):
-test("should return 10 for Jack of Diamonds", () => {
-  const jackOfDiamonds = getCardValue("J♦");
-  expect(jackOfDiamonds).toEqual(10);
+test("should return 'Invalid card rank' for invalid cards", () => {
+  ["1♣", "B♦", "Z♠"].forEach((card) => {
+    expect(getCardValue(card)).toBe("Invalid card rank");
+  });
 });
-
-//Case 4
-test("should return 10 for Queen of Clubs", () => {
-  const queenOfClubs = getCardValue("Q♣");
-  expect(queenOfClubs).toEqual(10);
-});
-
-test("should return 10 for King of Spades", () => {
-  const kingOfSpades = getCardValue("K♠");
-  expect(kingOfSpades).toEqual(10);
-});
-
 // Case 4: Handle Ace (A):
-test("should return 11 for Ace of Diamonds", () => {
-  const aceOfDiamonds = getCardValue("A♦");
-  expect(aceOfDiamonds).toEqual(11);
+test("should return 11 for Ace (A)", () => {
+  ["A♠", "A♥"].forEach((card) => {
+    expect(getCardValue(card)).toBe(11);
+  });
 });
 // Case 5: Handle Invalid Cards:
-test("should return null for invalid card '1X'", () => {
-  const invalidCard1 = getCardValue("1X");
-  expect(invalidCard1).toBe("Invalid card rank");
-});
-test("should return null for invalid card '11H'", () => {
-  const invalidCard2 = getCardValue("11H");
-  expect(invalidCard2).toBe("Invalid card rank");
-});
-
+test("should return 'Invalid card rank' for invalid cards", () => {
+  ["1♣", "B♦", "Z♠"].forEach((card) => {
+    expect(getCardValue(card)).toBe("Invalid card rank");
+  });
+});
\ No newline at end of file

From 27f970ff0b56ed031a70bba1f738808dc1c3dd1f Mon Sep 17 00:00:00 2001
From: Alaa-Tagi <alaa3litagi1994@gmail.com>
Date: Sun, 26 Oct 2025 21:32:28 +0000
Subject: [PATCH 16/18] manually deletinh all the unwanted content and the
 markers

---
 .../2-is-proper-fraction.test.js              | 20 ++++---------------
 1 file changed, 4 insertions(+), 16 deletions(-)

diff --git a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
index d23ebd24b..63d1c6e77 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
@@ -1,62 +1,53 @@
 const isProperFraction = require("../implement/2-is-proper-fraction");
 
-<<<<<<< HEAD
 // Case 1: Proper fraction
 // When numerator < denominator, it should return true.
 test("should return true for a proper fraction", () => {
-=======
+
 // Case 1: Proper Fraction
 // Given a numerator smaller than denominator (2/3),
 // When the function is called,
 // Then it should return true because it's a proper fraction.
 test("should return true for a proper fraction (2/3)", () => {
->>>>>>> 52740052fb0ad97a2c7253a04978b14a15b9e763
   expect(isProperFraction(2, 3)).toEqual(true);
 });
 
-<<<<<<< HEAD
 // Case 2: Improper fraction
 // When numerator > denominator, it should return false.
 test("should return false for an improper fraction", () => {
-=======
+
 // Case 2: Improper Fraction
 // Given a numerator greater than denominator (5/2),
 // When the function is called,
 // Then it should return false because it's an improper fraction.
 test("should return false for an improper fraction (5/2)", () => {
->>>>>>> 52740052fb0ad97a2c7253a04978b14a15b9e763
   expect(isProperFraction(5, 2)).toEqual(false);
 });
 
-<<<<<<< HEAD
 // Case 3: Negative proper fraction
 // When numerator is negative but |numerator| < |denominator|, it should return true.
 test("should return true for a negative proper fraction", () => {
-=======
+
 // Case 3: Negative Proper Fraction
 // Given a negative proper fraction (-1/2),
 // When the function is called,
 // Then it should return true because the value is between -1 and 1.
 test("should return true for a negative proper fraction (-1/2)", () => {
->>>>>>> 52740052fb0ad97a2c7253a04978b14a15b9e763
   expect(isProperFraction(-1, 2)).toEqual(true);
 });
 
-<<<<<<< HEAD
 // Case 4: Equal numerator and denominator
 // When numerator === denominator, it should return false.
 test("should return false for equal numerator and denominator", () => {
-=======
+
 // Case 4: Equal Numerator and Denominator
 // Given a numerator equal to denominator (3/3),
 // When the function is called,
 // Then it should return false because it's equal to 1 (not proper).
 test("should return false for equal numerator and denominator (3/3)", () => {
->>>>>>> 52740052fb0ad97a2c7253a04978b14a15b9e763
   expect(isProperFraction(3, 3)).toEqual(false);
 });
 
-<<<<<<< HEAD
 // Case 5: Zero numerator
 // 0 divided by any non-zero denominator is a proper fraction.
 test("should return true for zero numerator", () => {
@@ -87,7 +78,6 @@ test("should return true for large proper fractions", () => {
   expect(isProperFraction(999, 1000)).toEqual(true);
 });
 
-=======
 // Case 5: Negative Improper Fraction
 // Given a negative improper fraction (-4/3),
 // When the function is called,
@@ -119,5 +109,3 @@ test("should return true for zero numerator (0/5)", () => {
 test("should return false for zero denominator (5/0)", () => {
   expect(isProperFraction(5, 0)).toEqual(false);
 });
-
->>>>>>> 52740052fb0ad97a2c7253a04978b14a15b9e763
\ No newline at end of file

From 583780891e7adf38865fdf936b638bf2cc36494f Mon Sep 17 00:00:00 2001
From: Alaa-Tagi <alaa3litagi1994@gmail.com>
Date: Sun, 26 Oct 2025 23:13:01 +0000
Subject: [PATCH 17/18] deleting the markers

---
 .../implement/2-is-proper-fraction.js                       | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js b/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js
index 97de90d81..e4238b59f 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js
@@ -8,13 +8,13 @@
 // write one test at a time, and make it pass, build your solution up methodically
 
 function isProperFraction(numerator, denominator) {
-<<<<<<< HEAD
+
   if (denominator) {
     return true;
-=======
+
   if (typeof numerator !== "number" || typeof denominator !== "number") {
     return false; // Invalid input types
->>>>>>> 52740052fb0ad97a2c7253a04978b14a15b9e763
+
   }
 
   if (denominator === 0) {

From 28455efd185324dd1f2eea53b65a9ac83ac0488f Mon Sep 17 00:00:00 2001
From: Alaa-Tagi <alaa3litagi1994@gmail.com>
Date: Sun, 26 Oct 2025 23:18:38 +0000
Subject: [PATCH 18/18] deleting the doubled cases inside the code

---
 .../2-is-proper-fraction.test.js              | 44 -------------------
 1 file changed, 44 deletions(-)

diff --git a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
index 63d1c6e77..8e6c74deb 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
@@ -1,8 +1,5 @@
 const isProperFraction = require("../implement/2-is-proper-fraction");
 
-// Case 1: Proper fraction
-// When numerator < denominator, it should return true.
-test("should return true for a proper fraction", () => {
 
 // Case 1: Proper Fraction
 // Given a numerator smaller than denominator (2/3),
@@ -12,9 +9,6 @@ test("should return true for a proper fraction (2/3)", () => {
   expect(isProperFraction(2, 3)).toEqual(true);
 });
 
-// Case 2: Improper fraction
-// When numerator > denominator, it should return false.
-test("should return false for an improper fraction", () => {
 
 // Case 2: Improper Fraction
 // Given a numerator greater than denominator (5/2),
@@ -24,9 +18,6 @@ test("should return false for an improper fraction (5/2)", () => {
   expect(isProperFraction(5, 2)).toEqual(false);
 });
 
-// Case 3: Negative proper fraction
-// When numerator is negative but |numerator| < |denominator|, it should return true.
-test("should return true for a negative proper fraction", () => {
 
 // Case 3: Negative Proper Fraction
 // Given a negative proper fraction (-1/2),
@@ -36,10 +27,6 @@ test("should return true for a negative proper fraction (-1/2)", () => {
   expect(isProperFraction(-1, 2)).toEqual(true);
 });
 
-// Case 4: Equal numerator and denominator
-// When numerator === denominator, it should return false.
-test("should return false for equal numerator and denominator", () => {
-
 // Case 4: Equal Numerator and Denominator
 // Given a numerator equal to denominator (3/3),
 // When the function is called,
@@ -78,34 +65,3 @@ test("should return true for large proper fractions", () => {
   expect(isProperFraction(999, 1000)).toEqual(true);
 });
 
-// Case 5: Negative Improper Fraction
-// Given a negative improper fraction (-4/3),
-// When the function is called,
-// Then it should return false because the absolute value is greater than 1.
-test("should return false for a negative improper fraction (-4/3)", () => {
-  expect(isProperFraction(-4, 3)).toEqual(false);
-});
-
-// Case 6: Both Negative (Proper Fraction)
-// Given both numerator and denominator negative (-2/-3),
-// When the function is called,
-// Then it should return true because the value is positive and less than 1.
-test("should return true for both negative proper fraction (-2/-3)", () => {
-  expect(isProperFraction(-2, -3)).toEqual(true);
-});
-
-// Case 7: Zero Numerator
-// Given a numerator of 0 (0/5),
-// When the function is called,
-// Then it should return true because 0 is less than any nonzero denominator.
-test("should return true for zero numerator (0/5)", () => {
-  expect(isProperFraction(0, 5)).toEqual(true);
-});
-
-// Case 8: Zero Denominator
-// Given a denominator of 0 (5/0),
-// When the function is called,
-// Then it should return false because division by zero is undefined.
-test("should return false for zero denominator (5/0)", () => {
-  expect(isProperFraction(5, 0)).toEqual(false);
-});