Skip to content
This repository has been archived by the owner on Aug 17, 2024. It is now read-only.

Style guide violation, please update #570

Open
SallyMcGrath opened this issue Jan 14, 2023 · 7 comments
Open

Style guide violation, please update #570

SallyMcGrath opened this issue Jan 14, 2023 · 7 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@SallyMcGrath
Copy link
Member

const arr = [1, 2, 3];

const newArr = arr.concat(4);

Improper use of arr, newArr
https://syllabus.codeyourfuture.io/guides/code-style-guide

Please update to follow our own advice

@MohitBansal321
Copy link

i can you assgin this issue to me

@SallyMcGrath SallyMcGrath moved this from Backlog to Selected for triage in Syllabus Planning ARCHIVED Jan 14, 2023
@MohitBansal321
Copy link

okay i will replace it with this
const array=[1,2,3];
const newArray=array.concat(4);

@MohitBansal321
Copy link

i created pull request

@SallyMcGrath
Copy link
Member Author

Hi @MohitBansal321 . You can connect tickets and PRs on GitHub with a hashtag. Type #572 here or on your PR type fixes #570

https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

@SallyMcGrath SallyMcGrath moved this from Selected for triage to In progress in Syllabus Planning ARCHIVED Jan 15, 2023
@MohitBansal321
Copy link

#572

@MohitBansal321
Copy link

I done the changes
let me know is it okay

@MohitBansal321
Copy link

MohitBansal321 commented Jan 16, 2023

@SallyMcGrath
Hey I am not getting any feedback from you
kindly respond me so i can work on another issues here

@SallyMcGrath SallyMcGrath moved this from In progress to Review in progress in Syllabus Planning ARCHIVED Mar 13, 2023
@SallyMcGrath SallyMcGrath moved this from Review in progress to In progress in Syllabus Planning ARCHIVED Mar 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
No open projects
Status: In progress
Development

No branches or pull requests

2 participants