Skip to content

Commit 0c40829

Browse files
committed
Remove redundant PROJECT_SOURCE_DIR usage from CMake config.
Inspired by google/crc32c#32 PiperOrigin-RevId: 278718726
1 parent 5abdf4c commit 0c40829

File tree

1 file changed

+142
-142
lines changed

1 file changed

+142
-142
lines changed

CMakeLists.txt

+142-142
Original file line numberDiff line numberDiff line change
@@ -92,13 +92,13 @@ set(LEVELDB_PUBLIC_INCLUDE_DIR "include/leveldb")
9292
set(LEVELDB_PORT_CONFIG_DIR "include/port")
9393

9494
configure_file(
95-
"${PROJECT_SOURCE_DIR}/port/port_config.h.in"
95+
"port/port_config.h.in"
9696
"${PROJECT_BINARY_DIR}/${LEVELDB_PORT_CONFIG_DIR}/port_config.h"
9797
)
9898

9999
include_directories(
100100
"${PROJECT_BINARY_DIR}/include"
101-
"${PROJECT_SOURCE_DIR}"
101+
"."
102102
)
103103

104104
if(BUILD_SHARED_LIBS)
@@ -113,75 +113,75 @@ add_library(leveldb "")
113113
target_sources(leveldb
114114
PRIVATE
115115
"${PROJECT_BINARY_DIR}/${LEVELDB_PORT_CONFIG_DIR}/port_config.h"
116-
"${PROJECT_SOURCE_DIR}/db/builder.cc"
117-
"${PROJECT_SOURCE_DIR}/db/builder.h"
118-
"${PROJECT_SOURCE_DIR}/db/c.cc"
119-
"${PROJECT_SOURCE_DIR}/db/db_impl.cc"
120-
"${PROJECT_SOURCE_DIR}/db/db_impl.h"
121-
"${PROJECT_SOURCE_DIR}/db/db_iter.cc"
122-
"${PROJECT_SOURCE_DIR}/db/db_iter.h"
123-
"${PROJECT_SOURCE_DIR}/db/dbformat.cc"
124-
"${PROJECT_SOURCE_DIR}/db/dbformat.h"
125-
"${PROJECT_SOURCE_DIR}/db/dumpfile.cc"
126-
"${PROJECT_SOURCE_DIR}/db/filename.cc"
127-
"${PROJECT_SOURCE_DIR}/db/filename.h"
128-
"${PROJECT_SOURCE_DIR}/db/log_format.h"
129-
"${PROJECT_SOURCE_DIR}/db/log_reader.cc"
130-
"${PROJECT_SOURCE_DIR}/db/log_reader.h"
131-
"${PROJECT_SOURCE_DIR}/db/log_writer.cc"
132-
"${PROJECT_SOURCE_DIR}/db/log_writer.h"
133-
"${PROJECT_SOURCE_DIR}/db/memtable.cc"
134-
"${PROJECT_SOURCE_DIR}/db/memtable.h"
135-
"${PROJECT_SOURCE_DIR}/db/repair.cc"
136-
"${PROJECT_SOURCE_DIR}/db/skiplist.h"
137-
"${PROJECT_SOURCE_DIR}/db/snapshot.h"
138-
"${PROJECT_SOURCE_DIR}/db/table_cache.cc"
139-
"${PROJECT_SOURCE_DIR}/db/table_cache.h"
140-
"${PROJECT_SOURCE_DIR}/db/version_edit.cc"
141-
"${PROJECT_SOURCE_DIR}/db/version_edit.h"
142-
"${PROJECT_SOURCE_DIR}/db/version_set.cc"
143-
"${PROJECT_SOURCE_DIR}/db/version_set.h"
144-
"${PROJECT_SOURCE_DIR}/db/write_batch_internal.h"
145-
"${PROJECT_SOURCE_DIR}/db/write_batch.cc"
146-
"${PROJECT_SOURCE_DIR}/port/port_stdcxx.h"
147-
"${PROJECT_SOURCE_DIR}/port/port.h"
148-
"${PROJECT_SOURCE_DIR}/port/thread_annotations.h"
149-
"${PROJECT_SOURCE_DIR}/table/block_builder.cc"
150-
"${PROJECT_SOURCE_DIR}/table/block_builder.h"
151-
"${PROJECT_SOURCE_DIR}/table/block.cc"
152-
"${PROJECT_SOURCE_DIR}/table/block.h"
153-
"${PROJECT_SOURCE_DIR}/table/filter_block.cc"
154-
"${PROJECT_SOURCE_DIR}/table/filter_block.h"
155-
"${PROJECT_SOURCE_DIR}/table/format.cc"
156-
"${PROJECT_SOURCE_DIR}/table/format.h"
157-
"${PROJECT_SOURCE_DIR}/table/iterator_wrapper.h"
158-
"${PROJECT_SOURCE_DIR}/table/iterator.cc"
159-
"${PROJECT_SOURCE_DIR}/table/merger.cc"
160-
"${PROJECT_SOURCE_DIR}/table/merger.h"
161-
"${PROJECT_SOURCE_DIR}/table/table_builder.cc"
162-
"${PROJECT_SOURCE_DIR}/table/table.cc"
163-
"${PROJECT_SOURCE_DIR}/table/two_level_iterator.cc"
164-
"${PROJECT_SOURCE_DIR}/table/two_level_iterator.h"
165-
"${PROJECT_SOURCE_DIR}/util/arena.cc"
166-
"${PROJECT_SOURCE_DIR}/util/arena.h"
167-
"${PROJECT_SOURCE_DIR}/util/bloom.cc"
168-
"${PROJECT_SOURCE_DIR}/util/cache.cc"
169-
"${PROJECT_SOURCE_DIR}/util/coding.cc"
170-
"${PROJECT_SOURCE_DIR}/util/coding.h"
171-
"${PROJECT_SOURCE_DIR}/util/comparator.cc"
172-
"${PROJECT_SOURCE_DIR}/util/crc32c.cc"
173-
"${PROJECT_SOURCE_DIR}/util/crc32c.h"
174-
"${PROJECT_SOURCE_DIR}/util/env.cc"
175-
"${PROJECT_SOURCE_DIR}/util/filter_policy.cc"
176-
"${PROJECT_SOURCE_DIR}/util/hash.cc"
177-
"${PROJECT_SOURCE_DIR}/util/hash.h"
178-
"${PROJECT_SOURCE_DIR}/util/logging.cc"
179-
"${PROJECT_SOURCE_DIR}/util/logging.h"
180-
"${PROJECT_SOURCE_DIR}/util/mutexlock.h"
181-
"${PROJECT_SOURCE_DIR}/util/no_destructor.h"
182-
"${PROJECT_SOURCE_DIR}/util/options.cc"
183-
"${PROJECT_SOURCE_DIR}/util/random.h"
184-
"${PROJECT_SOURCE_DIR}/util/status.cc"
116+
"db/builder.cc"
117+
"db/builder.h"
118+
"db/c.cc"
119+
"db/db_impl.cc"
120+
"db/db_impl.h"
121+
"db/db_iter.cc"
122+
"db/db_iter.h"
123+
"db/dbformat.cc"
124+
"db/dbformat.h"
125+
"db/dumpfile.cc"
126+
"db/filename.cc"
127+
"db/filename.h"
128+
"db/log_format.h"
129+
"db/log_reader.cc"
130+
"db/log_reader.h"
131+
"db/log_writer.cc"
132+
"db/log_writer.h"
133+
"db/memtable.cc"
134+
"db/memtable.h"
135+
"db/repair.cc"
136+
"db/skiplist.h"
137+
"db/snapshot.h"
138+
"db/table_cache.cc"
139+
"db/table_cache.h"
140+
"db/version_edit.cc"
141+
"db/version_edit.h"
142+
"db/version_set.cc"
143+
"db/version_set.h"
144+
"db/write_batch_internal.h"
145+
"db/write_batch.cc"
146+
"port/port_stdcxx.h"
147+
"port/port.h"
148+
"port/thread_annotations.h"
149+
"table/block_builder.cc"
150+
"table/block_builder.h"
151+
"table/block.cc"
152+
"table/block.h"
153+
"table/filter_block.cc"
154+
"table/filter_block.h"
155+
"table/format.cc"
156+
"table/format.h"
157+
"table/iterator_wrapper.h"
158+
"table/iterator.cc"
159+
"table/merger.cc"
160+
"table/merger.h"
161+
"table/table_builder.cc"
162+
"table/table.cc"
163+
"table/two_level_iterator.cc"
164+
"table/two_level_iterator.h"
165+
"util/arena.cc"
166+
"util/arena.h"
167+
"util/bloom.cc"
168+
"util/cache.cc"
169+
"util/coding.cc"
170+
"util/coding.h"
171+
"util/comparator.cc"
172+
"util/crc32c.cc"
173+
"util/crc32c.h"
174+
"util/env.cc"
175+
"util/filter_policy.cc"
176+
"util/hash.cc"
177+
"util/hash.h"
178+
"util/logging.cc"
179+
"util/logging.h"
180+
"util/mutexlock.h"
181+
"util/no_destructor.h"
182+
"util/options.cc"
183+
"util/random.h"
184+
"util/status.cc"
185185

186186
# Only CMake 3.3+ supports PUBLIC sources in targets exported by "install".
187187
$<$<VERSION_GREATER:CMAKE_VERSION,3.2>:PUBLIC>
@@ -205,22 +205,22 @@ target_sources(leveldb
205205
if (WIN32)
206206
target_sources(leveldb
207207
PRIVATE
208-
"${PROJECT_SOURCE_DIR}/util/env_windows.cc"
209-
"${PROJECT_SOURCE_DIR}/util/windows_logger.h"
208+
"util/env_windows.cc"
209+
"util/windows_logger.h"
210210
)
211211
else (WIN32)
212212
target_sources(leveldb
213213
PRIVATE
214-
"${PROJECT_SOURCE_DIR}/util/env_posix.cc"
215-
"${PROJECT_SOURCE_DIR}/util/posix_logger.h"
214+
"util/env_posix.cc"
215+
"util/posix_logger.h"
216216
)
217217
endif (WIN32)
218218

219219
# MemEnv is not part of the interface and could be pulled to a separate library.
220220
target_sources(leveldb
221221
PRIVATE
222-
"${PROJECT_SOURCE_DIR}/helpers/memenv/memenv.cc"
223-
"${PROJECT_SOURCE_DIR}/helpers/memenv/memenv.h"
222+
"helpers/memenv/memenv.cc"
223+
"helpers/memenv/memenv.h"
224224
)
225225

226226
target_include_directories(leveldb
@@ -275,7 +275,7 @@ find_package(Threads REQUIRED)
275275
target_link_libraries(leveldb Threads::Threads)
276276

277277
add_executable(leveldbutil
278-
"${PROJECT_SOURCE_DIR}/db/leveldbutil.cc"
278+
"db/leveldbutil.cc"
279279
)
280280
target_link_libraries(leveldbutil leveldb)
281281

@@ -289,10 +289,10 @@ if(LEVELDB_BUILD_TESTS)
289289
target_sources("${test_target_name}"
290290
PRIVATE
291291
"${PROJECT_BINARY_DIR}/${LEVELDB_PORT_CONFIG_DIR}/port_config.h"
292-
"${PROJECT_SOURCE_DIR}/util/testharness.cc"
293-
"${PROJECT_SOURCE_DIR}/util/testharness.h"
294-
"${PROJECT_SOURCE_DIR}/util/testutil.cc"
295-
"${PROJECT_SOURCE_DIR}/util/testutil.h"
292+
"util/testharness.cc"
293+
"util/testharness.h"
294+
"util/testutil.cc"
295+
"util/testutil.h"
296296

297297
"${test_file}"
298298
)
@@ -311,49 +311,49 @@ if(LEVELDB_BUILD_TESTS)
311311
add_test(NAME "${test_target_name}" COMMAND "${test_target_name}")
312312
endfunction(leveldb_test)
313313

314-
leveldb_test("${PROJECT_SOURCE_DIR}/db/c_test.c")
315-
leveldb_test("${PROJECT_SOURCE_DIR}/db/fault_injection_test.cc")
314+
leveldb_test("db/c_test.c")
315+
leveldb_test("db/fault_injection_test.cc")
316316

317-
leveldb_test("${PROJECT_SOURCE_DIR}/issues/issue178_test.cc")
318-
leveldb_test("${PROJECT_SOURCE_DIR}/issues/issue200_test.cc")
319-
leveldb_test("${PROJECT_SOURCE_DIR}/issues/issue320_test.cc")
317+
leveldb_test("issues/issue178_test.cc")
318+
leveldb_test("issues/issue200_test.cc")
319+
leveldb_test("issues/issue320_test.cc")
320320

321-
leveldb_test("${PROJECT_SOURCE_DIR}/util/env_test.cc")
322-
leveldb_test("${PROJECT_SOURCE_DIR}/util/status_test.cc")
323-
leveldb_test("${PROJECT_SOURCE_DIR}/util/no_destructor_test.cc")
321+
leveldb_test("util/env_test.cc")
322+
leveldb_test("util/status_test.cc")
323+
leveldb_test("util/no_destructor_test.cc")
324324

325325
if(NOT BUILD_SHARED_LIBS)
326-
leveldb_test("${PROJECT_SOURCE_DIR}/db/autocompact_test.cc")
327-
leveldb_test("${PROJECT_SOURCE_DIR}/db/corruption_test.cc")
328-
leveldb_test("${PROJECT_SOURCE_DIR}/db/db_test.cc")
329-
leveldb_test("${PROJECT_SOURCE_DIR}/db/dbformat_test.cc")
330-
leveldb_test("${PROJECT_SOURCE_DIR}/db/filename_test.cc")
331-
leveldb_test("${PROJECT_SOURCE_DIR}/db/log_test.cc")
332-
leveldb_test("${PROJECT_SOURCE_DIR}/db/recovery_test.cc")
333-
leveldb_test("${PROJECT_SOURCE_DIR}/db/skiplist_test.cc")
334-
leveldb_test("${PROJECT_SOURCE_DIR}/db/version_edit_test.cc")
335-
leveldb_test("${PROJECT_SOURCE_DIR}/db/version_set_test.cc")
336-
leveldb_test("${PROJECT_SOURCE_DIR}/db/write_batch_test.cc")
337-
338-
leveldb_test("${PROJECT_SOURCE_DIR}/helpers/memenv/memenv_test.cc")
339-
340-
leveldb_test("${PROJECT_SOURCE_DIR}/table/filter_block_test.cc")
341-
leveldb_test("${PROJECT_SOURCE_DIR}/table/table_test.cc")
342-
343-
leveldb_test("${PROJECT_SOURCE_DIR}/util/arena_test.cc")
344-
leveldb_test("${PROJECT_SOURCE_DIR}/util/bloom_test.cc")
345-
leveldb_test("${PROJECT_SOURCE_DIR}/util/cache_test.cc")
346-
leveldb_test("${PROJECT_SOURCE_DIR}/util/coding_test.cc")
347-
leveldb_test("${PROJECT_SOURCE_DIR}/util/crc32c_test.cc")
348-
leveldb_test("${PROJECT_SOURCE_DIR}/util/hash_test.cc")
349-
leveldb_test("${PROJECT_SOURCE_DIR}/util/logging_test.cc")
326+
leveldb_test("db/autocompact_test.cc")
327+
leveldb_test("db/corruption_test.cc")
328+
leveldb_test("db/db_test.cc")
329+
leveldb_test("db/dbformat_test.cc")
330+
leveldb_test("db/filename_test.cc")
331+
leveldb_test("db/log_test.cc")
332+
leveldb_test("db/recovery_test.cc")
333+
leveldb_test("db/skiplist_test.cc")
334+
leveldb_test("db/version_edit_test.cc")
335+
leveldb_test("db/version_set_test.cc")
336+
leveldb_test("db/write_batch_test.cc")
337+
338+
leveldb_test("helpers/memenv/memenv_test.cc")
339+
340+
leveldb_test("table/filter_block_test.cc")
341+
leveldb_test("table/table_test.cc")
342+
343+
leveldb_test("util/arena_test.cc")
344+
leveldb_test("util/bloom_test.cc")
345+
leveldb_test("util/cache_test.cc")
346+
leveldb_test("util/coding_test.cc")
347+
leveldb_test("util/crc32c_test.cc")
348+
leveldb_test("util/hash_test.cc")
349+
leveldb_test("util/logging_test.cc")
350350

351351
# TODO(costan): This test also uses
352-
# "${PROJECT_SOURCE_DIR}/util/env_{posix|windows}_test_helper.h"
352+
# "util/env_{posix|windows}_test_helper.h"
353353
if (WIN32)
354-
leveldb_test("${PROJECT_SOURCE_DIR}/util/env_windows_test.cc")
354+
leveldb_test("util/env_windows_test.cc")
355355
else (WIN32)
356-
leveldb_test("${PROJECT_SOURCE_DIR}/util/env_posix_test.cc")
356+
leveldb_test("util/env_posix_test.cc")
357357
endif (WIN32)
358358
endif(NOT BUILD_SHARED_LIBS)
359359
endif(LEVELDB_BUILD_TESTS)
@@ -366,12 +366,12 @@ if(LEVELDB_BUILD_BENCHMARKS)
366366
target_sources("${bench_target_name}"
367367
PRIVATE
368368
"${PROJECT_BINARY_DIR}/${LEVELDB_PORT_CONFIG_DIR}/port_config.h"
369-
"${PROJECT_SOURCE_DIR}/util/histogram.cc"
370-
"${PROJECT_SOURCE_DIR}/util/histogram.h"
371-
"${PROJECT_SOURCE_DIR}/util/testharness.cc"
372-
"${PROJECT_SOURCE_DIR}/util/testharness.h"
373-
"${PROJECT_SOURCE_DIR}/util/testutil.cc"
374-
"${PROJECT_SOURCE_DIR}/util/testutil.h"
369+
"util/histogram.cc"
370+
"util/histogram.h"
371+
"util/testharness.cc"
372+
"util/testharness.h"
373+
"util/testutil.cc"
374+
"util/testutil.h"
375375

376376
"${bench_file}"
377377
)
@@ -389,12 +389,12 @@ if(LEVELDB_BUILD_BENCHMARKS)
389389
endfunction(leveldb_benchmark)
390390

391391
if(NOT BUILD_SHARED_LIBS)
392-
leveldb_benchmark("${PROJECT_SOURCE_DIR}/benchmarks/db_bench.cc")
392+
leveldb_benchmark("benchmarks/db_bench.cc")
393393
endif(NOT BUILD_SHARED_LIBS)
394394

395395
check_library_exists(sqlite3 sqlite3_open "" HAVE_SQLITE3)
396396
if(HAVE_SQLITE3)
397-
leveldb_benchmark("${PROJECT_SOURCE_DIR}/benchmarks/db_bench_sqlite3.cc")
397+
leveldb_benchmark("benchmarks/db_bench_sqlite3.cc")
398398
target_link_libraries(db_bench_sqlite3 sqlite3)
399399
endif(HAVE_SQLITE3)
400400

@@ -414,7 +414,7 @@ int main() {
414414
" HAVE_KYOTOCABINET)
415415
set(CMAKE_REQUIRED_LIBRARIES ${OLD_CMAKE_REQURED_LIBRARIES})
416416
if(HAVE_KYOTOCABINET)
417-
leveldb_benchmark("${PROJECT_SOURCE_DIR}/benchmarks/db_bench_tree_db.cc")
417+
leveldb_benchmark("benchmarks/db_bench_tree_db.cc")
418418
target_link_libraries(db_bench_tree_db kyotocabinet)
419419
endif(HAVE_KYOTOCABINET)
420420
endif(LEVELDB_BUILD_BENCHMARKS)
@@ -428,21 +428,21 @@ if(LEVELDB_INSTALL)
428428
)
429429
install(
430430
FILES
431-
"${PROJECT_SOURCE_DIR}/${LEVELDB_PUBLIC_INCLUDE_DIR}/c.h"
432-
"${PROJECT_SOURCE_DIR}/${LEVELDB_PUBLIC_INCLUDE_DIR}/cache.h"
433-
"${PROJECT_SOURCE_DIR}/${LEVELDB_PUBLIC_INCLUDE_DIR}/comparator.h"
434-
"${PROJECT_SOURCE_DIR}/${LEVELDB_PUBLIC_INCLUDE_DIR}/db.h"
435-
"${PROJECT_SOURCE_DIR}/${LEVELDB_PUBLIC_INCLUDE_DIR}/dumpfile.h"
436-
"${PROJECT_SOURCE_DIR}/${LEVELDB_PUBLIC_INCLUDE_DIR}/env.h"
437-
"${PROJECT_SOURCE_DIR}/${LEVELDB_PUBLIC_INCLUDE_DIR}/export.h"
438-
"${PROJECT_SOURCE_DIR}/${LEVELDB_PUBLIC_INCLUDE_DIR}/filter_policy.h"
439-
"${PROJECT_SOURCE_DIR}/${LEVELDB_PUBLIC_INCLUDE_DIR}/iterator.h"
440-
"${PROJECT_SOURCE_DIR}/${LEVELDB_PUBLIC_INCLUDE_DIR}/options.h"
441-
"${PROJECT_SOURCE_DIR}/${LEVELDB_PUBLIC_INCLUDE_DIR}/slice.h"
442-
"${PROJECT_SOURCE_DIR}/${LEVELDB_PUBLIC_INCLUDE_DIR}/status.h"
443-
"${PROJECT_SOURCE_DIR}/${LEVELDB_PUBLIC_INCLUDE_DIR}/table_builder.h"
444-
"${PROJECT_SOURCE_DIR}/${LEVELDB_PUBLIC_INCLUDE_DIR}/table.h"
445-
"${PROJECT_SOURCE_DIR}/${LEVELDB_PUBLIC_INCLUDE_DIR}/write_batch.h"
431+
"${LEVELDB_PUBLIC_INCLUDE_DIR}/c.h"
432+
"${LEVELDB_PUBLIC_INCLUDE_DIR}/cache.h"
433+
"${LEVELDB_PUBLIC_INCLUDE_DIR}/comparator.h"
434+
"${LEVELDB_PUBLIC_INCLUDE_DIR}/db.h"
435+
"${LEVELDB_PUBLIC_INCLUDE_DIR}/dumpfile.h"
436+
"${LEVELDB_PUBLIC_INCLUDE_DIR}/env.h"
437+
"${LEVELDB_PUBLIC_INCLUDE_DIR}/export.h"
438+
"${LEVELDB_PUBLIC_INCLUDE_DIR}/filter_policy.h"
439+
"${LEVELDB_PUBLIC_INCLUDE_DIR}/iterator.h"
440+
"${LEVELDB_PUBLIC_INCLUDE_DIR}/options.h"
441+
"${LEVELDB_PUBLIC_INCLUDE_DIR}/slice.h"
442+
"${LEVELDB_PUBLIC_INCLUDE_DIR}/status.h"
443+
"${LEVELDB_PUBLIC_INCLUDE_DIR}/table_builder.h"
444+
"${LEVELDB_PUBLIC_INCLUDE_DIR}/table.h"
445+
"${LEVELDB_PUBLIC_INCLUDE_DIR}/write_batch.h"
446446
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/leveldb
447447
)
448448

@@ -458,7 +458,7 @@ if(LEVELDB_INSTALL)
458458
)
459459
install(
460460
FILES
461-
"${PROJECT_SOURCE_DIR}/cmake/leveldbConfig.cmake"
461+
"cmake/leveldbConfig.cmake"
462462
"${PROJECT_BINARY_DIR}/leveldbConfigVersion.cmake"
463463
DESTINATION "${CMAKE_INSTALL_LIBDIR}/cmake/leveldb"
464464
)

0 commit comments

Comments
 (0)