Skip to content

PR #387 remediation: unresolved review comments on Qt transcript overlay #388

@Coldaine

Description

@Coldaine

Summary

PR #387 (feat(gui): surface live partial and final transcripts in Qt overlay) still has unresolved reviewer feedback on correctness and lifecycle handling. The work-queue worker also incorrectly logged this PR as merged even though GitHub still shows it open/conflicting.

This issue is the cleanup handoff for Jules. Fix the unresolved review items, push onto the existing PR branch if practical, or replace the PR with a narrower follow-up if the branch is no longer salvageable.

PR: #387

Highest-priority unresolved items

  • Fix the GuiBridgeRust type path in crates/coldvox-gui/src/bridge.rs so the binding resolves correctly.
  • Remove the invalid thread::spawn / self capture pattern and the Arc<AppHandle>::stt_rx.take() mutation issue.
  • Align property setter types in bridge.rs: do not pass QString into setters backed by String fields.
  • Make cmd_stop and cmd_clear actually stop the runtime/pipeline, or narrow the command names/behavior so the UI does not claim the pipeline stopped when it did not.
  • Ensure the runtime stays alive for the background tasks instead of dropping immediately after setup.
  • Provide a real STT selection/config path instead of starting from defaults that leave STT disabled.

Important follow-ups

  • Avoid leading newline insertion on the first finalized transcript append.
  • Recheck cmd_clear_error, cmd_clear, and other setter calls for the same QString/String mismatch pattern.
  • Re-run the relevant Qt/Rust validation path, not just frontend tests.
  • Resolve or explicitly close the still-open Copilot/Qodo/Codex review threads on PR feat(gui): surface live partial and final transcripts in Qt overlay #387.

Validation expected

  • cargo check (or stronger project-standard Rust validation for coldvox-gui)
  • Any Qt/UI-specific validation available in repo
  • Existing frontend test coverage for transcript/overlay behavior

Notes

  • The current worker prompt in zo-workqueue explicitly says workers should not work on existing PRs, so this PR entered an unsupported state machine. Treat this as a manual remediation issue, not an endorsement of the worker flow.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions