Summary
PR #387 (feat(gui): surface live partial and final transcripts in Qt overlay) still has unresolved reviewer feedback on correctness and lifecycle handling. The work-queue worker also incorrectly logged this PR as merged even though GitHub still shows it open/conflicting.
This issue is the cleanup handoff for Jules. Fix the unresolved review items, push onto the existing PR branch if practical, or replace the PR with a narrower follow-up if the branch is no longer salvageable.
PR: #387
Highest-priority unresolved items
Important follow-ups
Validation expected
cargo check (or stronger project-standard Rust validation for coldvox-gui)
- Any Qt/UI-specific validation available in repo
- Existing frontend test coverage for transcript/overlay behavior
Notes
- The current worker prompt in
zo-workqueue explicitly says workers should not work on existing PRs, so this PR entered an unsupported state machine. Treat this as a manual remediation issue, not an endorsement of the worker flow.
Summary
PR #387 (
feat(gui): surface live partial and final transcripts in Qt overlay) still has unresolved reviewer feedback on correctness and lifecycle handling. The work-queue worker also incorrectly logged this PR as merged even though GitHub still shows it open/conflicting.This issue is the cleanup handoff for Jules. Fix the unresolved review items, push onto the existing PR branch if practical, or replace the PR with a narrower follow-up if the branch is no longer salvageable.
PR: #387
Highest-priority unresolved items
GuiBridgeRusttype path incrates/coldvox-gui/src/bridge.rsso the binding resolves correctly.thread::spawn/selfcapture pattern and theArc<AppHandle>::stt_rx.take()mutation issue.bridge.rs: do not passQStringinto setters backed byStringfields.cmd_stopandcmd_clearactually stop the runtime/pipeline, or narrow the command names/behavior so the UI does not claim the pipeline stopped when it did not.Important follow-ups
cmd_clear_error,cmd_clear, and other setter calls for the sameQString/Stringmismatch pattern.Validation expected
cargo check(or stronger project-standard Rust validation forcoldvox-gui)Notes
zo-workqueueexplicitly says workers should not work on existing PRs, so this PR entered an unsupported state machine. Treat this as a manual remediation issue, not an endorsement of the worker flow.