Skip to content

feat: auto select Reference from solvent metadata when unset #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 7, 2025
Merged

feat: auto select Reference from solvent metadata when unset #263

merged 2 commits into from
Nov 7, 2025

Conversation

@Nicolass67
Copy link
Contributor

@Nicolass67 Nicolass67 commented Oct 27, 2025

PR description

What

  • Auto select the Reference in the top bar when a matching solvent is found
  • Use a robust matcher on solvent label and name
  • Keep manual choice if a Reference is already set

Why

Restores expected behavior where the solvent reference is preselected

How

  • Build a normalized solvent key from feature metadata
  • Score each candidate and choose the best one
  • Select value is now ref.name

@PiTrem PiTrem requested review from PiTrem and Copilot November 5, 2025 15:42
@Nicolass67 Nicolass67 force-pushed the feat/auto-select-solvent-reference branch from 5ee13de to 0c9e0a6 Compare November 5, 2025 15:49
@Nicolass67 Nicolass67 marked this pull request as ready for review November 5, 2025 15:57
Copilot AI reviewed Nov 5, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@PiTrem PiTrem linked an issue Nov 7, 2025 that may be closed by this pull request
Solvent not automatically selected in reference dropdown #262
Closed
@PiTrem PiTrem merged commit 55cbb6b into master Nov 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@PiTrem PiTrem PiTrem approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Solvent not automatically selected in reference dropdown

3 participants

@Nicolass67 @PiTrem