Skip to content

Conversation

@mpurg
Copy link
Contributor

@mpurg mpurg commented Nov 20, 2025

Description:

The rule audit_rules_privileged_commands_kmod uses the template audit_rules_privileged_commands which uses the new watch format (-a always,exit -F path=/bin/kmod ...) whereas Ubuntu STIGs suggest the old format (-w /bin/kmod ...).

This change aligns the content to the Ubuntu STIGs by allowing both formats.

Rationale:

Automatus results

$ python3 tests/automatus.py rule --libvirt qemu:///system sec-noble-amd64  --datastream build/ssg-ubuntu2404-ds.xml --remove-fips-certified --remediate-using bash --profile "(all)" --dontclean audit_rules_privileged_commands_kmod

Setting console output to log level INFO
INFO - The base image option has not been specified, choosing libvirt-based test environment.
WARNING - Script 'auditctl_missing_arch.fail.sh' is not applicable on 'ubuntu2404' target because its platform is 'Red Hat Enterprise Linux 10'
WARNING - Script 'augenrules_missing_arch.fail.sh' is not applicable on 'ubuntu2404' target because its platform is 'Red Hat Enterprise Linux 10'
INFO - xccdf_org.ssgproject.content_rule_audit_rules_privileged_commands_kmod
INFO - Script auditctl_comented_value.fail.sh using profile (all) OK
INFO - Script auditctl_missing_auid.fail.sh using profile (all) OK
INFO - Script augenrules_missing_auid.fail.sh using profile (all) OK
INFO - Script auditctl_missing_perm_x.fail.sh using profile (all) OK
INFO - Script augenrules_missing_perm_x.fail.sh using profile (all) OK
INFO - Script augenrules_comented_value.fail.sh using profile (all) OK
INFO - Script auditctl_correct_value.pass.sh using profile (all) OK
INFO - Script augenrules_correct_value.pass.sh using profile (all) OK
INFO - Script augenrules_correct_old_format.pass.sh using profile (all) OK
INFO - Script auditctl_correct_old_format.pass.sh using profile (all) OK

The rule audit_rules_privileged_commands_kmod uses the template
audit_rules_privileged_commands which uses the new watch
format (-a always,exit -F path=/bin/kmod ...) whereas Ubuntu
STIGs suggest the old format (-w /bin/kmod ...).

This change aligns the content to the Ubuntu STIGs by allowing
both formats.
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Nov 20, 2025
@openshift-ci
Copy link

openshift-ci bot commented Nov 20, 2025

Hi @mpurg. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dodys dodys requested a review from a team November 24, 2025 10:01
@dodys dodys self-assigned this Nov 24, 2025
@dodys dodys added the Ubuntu Ubuntu product related. label Nov 24, 2025
@dodys dodys added this to the 0.1.80 milestone Nov 24, 2025
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@Mab879 Mab879 merged commit 9f022f1 into ComplianceAsCode:master Nov 24, 2025
127 of 130 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ubuntu OpenSCAP kernel module audit rule bug

3 participants