Fix basic auth parser #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

toanalien wants to merge 1 commit into Consensys:main from toanalien:main

toanalien commented Jun 1, 2022 •

edited

Loading

PR description

The Basic Auth parser is not correct. It includes a colon in the password.

password: thisissuperpassword
raw payload: :thisissuperpassword
Header with base64 encoded: Authorization: Basic OnRoaXNpc3N1cGVycGFzc3dvcmQ=

Fixed Issue(s)

Use http.Request.BasicAuth() parses authentication header.


          Fix basic auth parser

29429a1

CLAassistant commented Jun 1, 2022 •

edited

Loading

All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet