Test against various versions of GraphQL-Ruby and ActiveRecord

Author: Envek

.gitignore

@@ -8,3 +8,4 @@
 /spec/reports/
 /tmp/
 .rspec_status
+/gemfiles/*.lock

.travis.yml

@@ -1,9 +1,41 @@
 ---
-sudo: false
 language: ruby
 cache: bundler
-rvm:
-  - 2.5.1
-  - 2.4.4
-  - 2.3.7
-before_install: gem install bundler -v 2.0.2
+before_install: gem install bundler -v '~> 2.0'
+
+jobs:
+  include:
+    - rvm: 2.7.0
+      gemfile: gemfiles/graphql_1.10.gemfile
+      env:
+        - GRAPHQL_RUBY_INTERPRETER=yes
+        - RAILS_VERSION=6.0
+    - rvm: 2.7.0
+      gemfile: gemfiles/graphql_1.10.gemfile
+      env:
+        - GRAPHQL_RUBY_INTERPRETER=no
+        - RAILS_VERSION=6.0
+    - rvm: 2.6.5
+      gemfile: gemfiles/graphql_1.9.gemfile
+      env:
+        - GRAPHQL_RUBY_INTERPRETER=yes
+        - RAILS_VERSION=6.0
+    - rvm: 2.6.5
+      gemfile: gemfiles/graphql_1.9.gemfile
+      env:
+        - GRAPHQL_RUBY_INTERPRETER=no
+        - RAILS_VERSION=6.0
+    - rvm: 2.5.7
+      gemfile: gemfiles/graphql_1.9.gemfile
+      env:
+        - GRAPHQL_RUBY_INTERPRETER=yes
+        - RAILS_VERSION=5.2
+    - rvm: 2.5.7
+      gemfile: gemfiles/graphql_1.9.gemfile
+      env:
+        - GRAPHQL_RUBY_INTERPRETER=no
+        - RAILS_VERSION=5.2
+    - rvm: 2.4.9
+      gemfile: gemfiles/graphql_1.8.gemfile
+      env:
+        - RAILS_VERSION=5.1

Appraisals

@@ -0,0 +1,11 @@
+appraise "graphql-1.8" do
+  gem "graphql", "~> 1.8.0"
+end
+
+appraise "graphql-1.9" do
+  gem "graphql", "~> 1.9.0"
+end
+
+appraise "graphql-1.10" do
+  gem "graphql", "~> 1.10.0"
+end

Gemfile

@@ -2,3 +2,5 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in graphql-preload.gemspec
 gemspec
+
+gem 'activerecord', ENV['RAILS_VERSION'] && "~> #{ENV['RAILS_VERSION']}.0"

gemfiles/.bundle/config

@@ -0,0 +1,2 @@
+---
+BUNDLE_RETRY: "1"

gemfiles/graphql_1.10.gemfile

@@ -0,0 +1,8 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "activerecord", nil
+gem "graphql", "~> 1.10.0"
+
+gemspec path: "../"

gemfiles/graphql_1.8.gemfile

@@ -0,0 +1,8 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "activerecord", nil
+gem "graphql", "~> 1.8.0"
+
+gemspec path: "../"

gemfiles/graphql_1.9.gemfile

@@ -0,0 +1,8 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "activerecord", nil
+gem "graphql", "~> 1.9.0"
+
+gemspec path: "../"

graphql-preload.gemspec

@@ -28,9 +28,10 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency 'bundler', '~> 2.0'
   spec.add_development_dependency 'pry', '~> 0.10'
-  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'rake', '~> 13.0'
   spec.add_development_dependency 'rspec', '~> 3.8'
   spec.add_development_dependency 'rspec-sqlimit'
   spec.add_development_dependency 'sqlite3'
   spec.add_development_dependency 'yard', '~> 0.9'
+  spec.add_development_dependency "appraisal"
 end

spec/graphql/preload_spec.rb

@@ -4,45 +4,61 @@
 RSpec.describe GraphQL::Preload do
   subject do
     @result ||=
-      PreloadSchema.execute(query: query_string, context: {}, variables: {})
+      schema.execute(query: query_string, context: {}, variables: {})
   end
 
-  context "without associations" do
-    let(:query_string) { "query { products { title } }" }
+  shared_examples "test suite" do
+    context "without associations" do
+      let(:query_string) { "query { products { title } }" }
 
-    it "doesn't load associations at all" do
-      expect { subject }.not_to exceed_query_limit 1
+      it "doesn't load associations at all" do
+        expect { subject }.not_to exceed_query_limit 1
+      end
     end
-  end
 
-  context "with associations" do
-    let(:query_string) do
-      <<~QRAPHQL
+    context "with associations" do
+      let(:query_string) do
+        <<~QRAPHQL
         query { posts { title comments { text } } }
-      QRAPHQL
-    end
+        QRAPHQL
+      end
 
-    it "preloads associations by single query" do
-      expect { subject }.to exceed_query_limit 1 # to ensure that GraphQL query at least works
-      expect { subject }.not_to exceed_query_limit 2
-      posts = subject.dig("data", "posts")
-      expect(posts.size).to eq(4)
-      expect(posts.flat_map { |p| p["comments"] }.size).to eq(8)
+      it "preloads associations by single query" do
+        expect { subject }.to exceed_query_limit 1 # to ensure that GraphQL query at least works
+        expect { subject }.not_to exceed_query_limit 2
+        posts = subject.dig("data", "posts")
+        expect(posts.size).to eq(4)
+        expect(posts.flat_map { |p| p["comments"] }.size).to eq(8)
+      end
     end
-  end
 
-  context "with associations with custom scopes" do
-    let(:query_string) do
-      <<~QRAPHQL
+    context "with associations with custom scopes" do
+      let(:query_string) do
+        <<~QRAPHQL
         query { users { name posts { title } } }
-      QRAPHQL
-    end
+        QRAPHQL
+      end
 
-    it "preloads associations by single query and given order" do
-      expect { subject }.not_to exceed_query_limit 2
-      posts = subject.dig("data", "users").flat_map { |p| p["posts"] }
-      # Posts for every user should be from greater rating to lower
-      expect(posts.map { |p| p["title"] }).to eq(%w[Bar Foo Baz Huh])
+      it "preloads associations by single query and given order" do
+        expect { subject }.not_to exceed_query_limit 2
+        posts = subject.dig("data", "users").flat_map { |p| p["posts"] }
+        # Posts for every user should be from greater rating to lower
+        expect(posts.map { |p| p["title"] }).to eq(%w[Bar Foo Baz Huh])
+      end
     end
   end
+
+  context "modern class-based GraphQL schema" do
+    let(:schema) { PreloadSchema }
+
+    include_examples "test suite"
+  end
+
+  context "legacy define-based GraphQL schema" do
+    next if TESTING_GRAPHQL_RUBY_INTERPRETER # No interpreter runtime these days
+
+    let(:schema) { Legacy::PreloadSchema }
+
+    include_examples "test suite"
+  end
 end