Skip to content

Commit 15d1b35

Browse files
authored
Rewrite 'Split Aggregate by Entity' and removed Henshin dependency (Eclipse 2021-06 compatibility) (#299)
1 parent 4f88f88 commit 15d1b35

File tree

19 files changed

+126
-800
lines changed

19 files changed

+126
-800
lines changed

org.contextmapper.dsl.ide/src/org/contextmapper/dsl/ide/commands/impl/refactoring/SplitAggregateByEntitiesRefactoringCommand.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
import org.contextmapper.dsl.ide.edit.WorkspaceEditRecorder;
1919
import org.contextmapper.dsl.refactoring.SemanticCMLRefactoring;
20-
import org.contextmapper.dsl.refactoring.henshin.SplitAggregateByEntitiesRefactoring;
20+
import org.contextmapper.dsl.refactoring.SplitAggregateByEntitiesRefactoring;
2121
import org.eclipse.lsp4j.ExecuteCommandParams;
2222

2323
import com.google.gson.JsonPrimitive;

org.contextmapper.dsl.repository/category.xml

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -18,23 +18,7 @@
1818
<feature id="contextmapper.freemarker">
1919
<category name="main"/>
2020
</feature>
21-
<bundle id="org.eclipse.emf.henshin.interpreter" version="1.6.0.202001052147">
22-
<category name="main"/>
23-
</bundle>
24-
<bundle id="org.eclipse.emf.henshin.model" version="1.6.0.202001052147">
25-
<category name="main"/>
26-
</bundle>
27-
<bundle id="org.eclipse.emf.henshin.diagram" version="1.6.0.202001052147">
28-
<category name="main"/>
29-
</bundle>
30-
<bundle id="org.eclipse.emf.henshin.edit" version="1.6.0.202001052147">
31-
<category name="main"/>
32-
</bundle>
33-
<bundle id="org.eclipse.emf.henshin.editor" version="1.6.0.202001052147">
34-
<category name="main"/>
35-
</bundle>
3621
<category-def name="main" label="Context Mapper"/>
37-
<repository-reference location="https://download.eclipse.org/modeling/emft/henshin/updates/1.6.0/" enabled="true" />
3822
<repository-reference location="https://contextmapper.jfrog.io/artifactory/context-map-generator-releases/" enabled="true" />
3923
<repository-reference location="https://contextmapper.jfrog.io/artifactory/service-cutter-library-releases/" enabled="true" />
4024
<repository-reference location="https://contextmapper.jfrog.io/artifactory/context-mapper-osgi-bundles/1.0.0/" enabled="true" />

org.contextmapper.dsl.target/org.contextmapper.dsl.target.target

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,6 @@
3535
<unit id="io.github.classgraph" version="4.8.35.v20190528-1517"/>
3636
<repository location="https://download.eclipse.org/tools/orbit/downloads/2020-09"/>
3737
</location>
38-
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
39-
<unit id="org.eclipse.emf.henshin.sdk.feature.group" version="1.6.0.202001052147"/>
40-
<repository location="https://download.eclipse.org/modeling/emft/henshin/updates/1.6.0/"/>
41-
</location>
4238
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
4339
<repository location="https://contextmapper.jfrog.io/artifactory/context-map-generator-releases/"/>
4440
<unit id="org.contextmapper.contextmap.generator.feature.feature.group" version="1.2.1"/>
@@ -60,4 +56,4 @@
6056
<unit id="org.yaml.snakeyaml" version="1.14.0.v201604211500"/>
6157
</location>
6258
</locations>
63-
</target>
59+
</target>
Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package org.contextmapper.dsl.refactoring.henshin;
1+
package org.contextmapper.dsl.refactoring;
22

33
import static org.junit.jupiter.api.Assertions.assertEquals;
44
import static org.junit.jupiter.api.Assertions.assertTrue;
@@ -15,8 +15,6 @@
1515
import org.contextmapper.dsl.contextMappingDSL.ContextMappingModel;
1616
import org.contextmapper.dsl.contextMappingDSL.SculptorModule;
1717
import org.contextmapper.dsl.contextMappingDSL.UpstreamDownstreamRelationship;
18-
import org.contextmapper.dsl.refactoring.AbstractRefactoringTest;
19-
import org.contextmapper.dsl.refactoring.henshin.SplitAggregateByEntitiesRefactoring;
2018
import org.contextmapper.tactic.dsl.tacticdsl.DomainObject;
2119
import org.contextmapper.tactic.dsl.tacticdsl.SimpleDomainObject;
2220
import org.eclipse.emf.ecore.resource.ResourceSet;
@@ -45,7 +43,7 @@ void canSplitWithTwoAggregates() throws IOException {
4543

4644
List<String> aggregateNames = bc.getAggregates().stream().map(a -> a.getName()).collect(Collectors.toList());
4745
assertTrue(aggregateNames.contains("Customers"));
48-
assertTrue(aggregateNames.contains("NewAggregate1"));
46+
assertTrue(aggregateNames.contains("Account"));
4947

5048
for (Aggregate aggregate : bc.getAggregates()) {
5149
SimpleDomainObject obj = aggregate.getDomainObjects().get(0);
@@ -95,7 +93,7 @@ void canSplitInModule() throws IOException {
9593

9694
List<String> aggregateNames = testModule.getAggregates().stream().map(a -> a.getName()).collect(Collectors.toList());
9795
assertTrue(aggregateNames.contains("Customers"));
98-
assertTrue(aggregateNames.contains("NewAggregate1"));
96+
assertTrue(aggregateNames.contains("Account"));
9997
}
10098

10199
@Test
@@ -119,12 +117,12 @@ void canFixExposedAggregatesInContextMap() throws IOException {
119117
assertEquals(2, customerBC.getAggregates().size());
120118
List<String> aggregateNames = customerBC.getAggregates().stream().map(a -> a.getName()).collect(Collectors.toList());
121119
assertTrue(aggregateNames.contains("Customers"));
122-
assertTrue(aggregateNames.contains("NewAggregate1"));
120+
assertTrue(aggregateNames.contains("Account"));
123121

124122
UpstreamDownstreamRelationship relationship = (UpstreamDownstreamRelationship) model.getMap().getRelationships().get(0);
125123
List<String> upstreamExposedAggregates = relationship.getUpstreamExposedAggregates().stream().map(a -> a.getName()).collect(Collectors.toList());
126124
assertTrue(upstreamExposedAggregates.contains("Customers"));
127-
assertTrue(upstreamExposedAggregates.contains("NewAggregate1"));
125+
assertTrue(upstreamExposedAggregates.contains("Account"));
128126
}
129127

130128
@Test

org.contextmapper.dsl.tests/src/org/contextmapper/dsl/refactoring/henshin/HenshinTransformationFileProviderTest.java

Lines changed: 0 additions & 80 deletions
This file was deleted.

org.contextmapper.dsl.ui/plugin.xml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -937,9 +937,6 @@
937937
</menu>
938938
</menuContribution>
939939
</extension>
940-
<extension point="org.eclipse.ui.startup">
941-
<startup class="org.contextmapper.dsl.ui.startup.ContextMapperPluginStartup"/>
942-
</extension>
943940
<extension point="org.eclipse.ui.newWizards">
944941
<wizard
945942
icon="icons/cml-dialog-image.png"

org.contextmapper.dsl.ui/src/org/contextmapper/dsl/ui/handler/SplitAggregateByEntitiesRefactoringHandler.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
import org.contextmapper.dsl.cml.CMLResource;
2222
import org.contextmapper.dsl.contextMappingDSL.Aggregate;
2323
import org.contextmapper.dsl.refactoring.SemanticCMLRefactoring;
24-
import org.contextmapper.dsl.refactoring.henshin.SplitAggregateByEntitiesRefactoring;
24+
import org.contextmapper.dsl.refactoring.SplitAggregateByEntitiesRefactoring;
2525
import org.contextmapper.tactic.dsl.tacticdsl.Entity;
2626
import org.contextmapper.tactic.dsl.tacticdsl.SimpleDomainObject;
2727
import org.eclipse.core.commands.ExecutionEvent;

org.contextmapper.dsl.ui/src/org/contextmapper/dsl/ui/startup/ContextMapperPluginStartup.java

Lines changed: 0 additions & 19 deletions
This file was deleted.

org.contextmapper.dsl/META-INF/MANIFEST.MF

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ Require-Bundle: org.eclipse.xtext,
1515
org.eclipse.emf.common,
1616
org.eclipse.xtend.lib;bundle-version="2.14.0",
1717
org.antlr.runtime;bundle-version="[3.2.0,3.2.1)",
18-
org.eclipse.emf.henshin.interpreter;bundle-version="1.4.0",
1918
org.apache.commons.io;bundle-version="2.2.0",
2019
org.contextmapper.contextmap.generator;bundle-version="1.2.1",
2120
org.apache.commons.lang3;bundle-version="3.9.0",
@@ -61,7 +60,6 @@ Export-Package: org.contextmapper.dsl,
6160
org.contextmapper.dsl.quickfixes.tactic,
6261
org.contextmapper.dsl.refactoring,
6362
org.contextmapper.dsl.refactoring.exception,
64-
org.contextmapper.dsl.refactoring.henshin,
6563
org.contextmapper.dsl.scoping,
6664
org.contextmapper.dsl.serializer,
6765
org.contextmapper.dsl.services,

org.contextmapper.dsl/build.gradle

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ dependencies {
1010
compile group: 'com.fasterxml.jackson.core', name: 'jackson-databind', version: '2.9.9'
1111
compile group: 'com.fasterxml.jackson.core', name: 'jackson-annotations', version: '2.9.9'
1212
compile group: 'org.yaml', name: 'snakeyaml', version: '1.14'
13-
compile group: 'org.contextmapper', name: 'henshin-interpreter', version: '1.6.0'
1413
compile group: 'org.contextmapper', name: 'context-map-generator', version: '1.2.1'
1514
compile group: 'org.contextmapper', name: 'service-cutter-library', version: '1.2.1'
1615
}

0 commit comments

Comments
 (0)