Reject node labels with shell metacharacters in CLI validate (#251)

Author: avinxshKD

concore_cli/commands/validate.py

@@ -84,6 +84,11 @@ def validate_workflow(workflow_file, console):
                     label = label_tag.text.strip()
                     node_labels.append(label)
 
+                    # reject shell metacharacters to prevent command injection (#251)
+                    if re.search(r'[;&|`$\'"()\\]', label):
+                        errors.append(f"Node '{label}' contains unsafe shell characters")
+                        continue
+
                     if ':' not in label:
                         warnings.append(f"Node '{label}' missing format 'ID:filename'")
                     else:

tests/test_graph.py

@@ -112,6 +112,23 @@ def test_validate_node_missing_filename(self):
         self.assertIn('Validation failed', result.output)
         self.assertIn('has no filename', result.output)
 
+    def test_validate_unsafe_node_label(self):
+        content = '''
+        <graphml xmlns:y="http://www.yworks.com/xml/graphml">
+            <graph id="G" edgedefault="directed">
+                <node id="n0">
+                    <data key="d0"><y:NodeLabel>n0;rm -rf /:script.py</y:NodeLabel></data>
+                </node>
+            </graph>
+        </graphml>
+        '''
+        filepath = self.create_graph_file('injection.graphml', content)
+
+        result = self.runner.invoke(cli, ['validate', filepath])
+
+        self.assertIn('Validation failed', result.output)
+        self.assertIn('unsafe shell characters', result.output)
+
     def test_validate_valid_graph(self):
         content = '''
         <graphml xmlns:y="http://www.yworks.com/xml/graphml">