Merge pull request #1000 from Scriptwonder/feat/manage-profiler

feat: add manage_profiler tool with session control, counters, memory snapshots, and Frame Debugger

Author: Scriptwonder

.claude/skills/unity-mcp-skill/references/tools-reference.md

@@ -70,7 +70,7 @@ from services.registry import mcp_for_unity_tool
 
 @mcp_for_unity_tool(
     description="Does something in Unity.",
-    group="core",  # core (default), vfx, animation, ui, scripting_ext, testing, probuilder
+    group="core",  # core (default), vfx, animation, ui, scripting_ext, testing, probuilder, profiling, docs
 )
 async def manage_something(
     ctx: Context,

CLAUDE.md

@@ -10,8 +10,9 @@ namespace MCPForUnity.Editor.Helpers
 {
     internal static class McpLogRecord
     {
-        private static readonly string LogPath = Path.Combine(Application.dataPath, "mcp.log");
-        private static readonly string ErrorLogPath = Path.Combine(Application.dataPath, "mcpError.log");
+        private static readonly string LogDir = Path.Combine(Application.dataPath, "UnityMCP", "Log");
+        private static readonly string LogPath = Path.Combine(LogDir, "mcp.log");
+        private static readonly string ErrorLogPath = Path.Combine(LogDir, "mcpError.log");
         private const long MaxLogSizeBytes = 1024 * 1024; // 1 MB
         private static bool _sessionStarted;
         private static readonly object _logLock = new();
@@ -79,6 +80,7 @@ internal static void Log(string commandType, JObject parameters, string type, st
 
         private static void RotateAndAppend(string path, string line)
         {
+            Directory.CreateDirectory(LogDir);
             RotateIfNeeded(path);
             File.AppendAllText(path, line + Environment.NewLine);
         }

MCPForUnity/Editor/Helpers/McpLogRecord.cs

@@ -24,6 +24,12 @@ public interface IPackageUpdateService
         /// </summary>
         UpdateCheckResult FetchAndCompare(string currentVersion);
 
+        /// <summary>
+        /// Performs only the network fetch and version comparison using pre-computed installation info.
+        /// Use this overload when calling from a background thread to avoid main-thread-only API calls.
+        /// </summary>
+        UpdateCheckResult FetchAndCompare(string currentVersion, bool isGitInstallation, string gitBranch);
+
         /// <summary>
         /// Caches a successful fetch result in EditorPrefs. Must be called from the main thread.
         /// </summary>
@@ -43,6 +49,12 @@ public interface IPackageUpdateService
         /// <returns>True if installed via Git, false if Asset Store or unknown</returns>
         bool IsGitInstallation();
 
+        /// <summary>
+        /// Determines the Git branch to check for updates (e.g. "main" or "beta").
+        /// Must be called from the main thread (uses Unity PackageManager APIs).
+        /// </summary>
+        string GetGitUpdateBranch(string currentVersion);
+
         /// <summary>
         /// Clears the cached update check data, forcing a fresh check on next request
         /// </summary>

MCPForUnity/Editor/Services/IPackageUpdateService.cs

@@ -118,7 +118,12 @@ public UpdateCheckResult FetchAndCompare(string currentVersion)
         {
             bool isGitInstallation = IsGitInstallation();
             string gitBranch = isGitInstallation ? GetGitUpdateBranch(currentVersion) : "main";
+            return FetchAndCompare(currentVersion, isGitInstallation, gitBranch);
+        }
 
+        /// <inheritdoc/>
+        public UpdateCheckResult FetchAndCompare(string currentVersion, bool isGitInstallation, string gitBranch)
+        {
             string latestVersion = isGitInstallation
                 ? FetchLatestVersionFromGitHub(gitBranch)
                 : FetchLatestVersionFromAssetStoreJson();
@@ -279,7 +284,8 @@ private static bool IsPreReleaseVersion(string version)
             return version.IndexOf('-', StringComparison.Ordinal) >= 0;
         }
 
-        private static string GetGitUpdateBranch(string currentVersion)
+        /// <inheritdoc/>
+        public string GetGitUpdateBranch(string currentVersion)
         {
             try
             {

MCPForUnity/Editor/Services/PackageUpdateService.cs

@@ -8,6 +8,7 @@
 using Unity.Profiling;
 using Unity.Profiling.LowLevel.Unsafe;
 using UnityEngine.Profiling;
+using UProfiler = UnityEngine.Profiling.Profiler;
 
 namespace MCPForUnity.Editor.Tools.Graphics
 {
@@ -126,12 +127,12 @@ internal static object GetMemory(JObject @params)
         {
             var data = new Dictionary<string, object>
             {
-                ["totalAllocatedMB"] = Math.Round(Profiler.GetTotalAllocatedMemoryLong() / (1024.0 * 1024.0), 2),
-                ["totalReservedMB"] = Math.Round(Profiler.GetTotalReservedMemoryLong() / (1024.0 * 1024.0), 2),
-                ["totalUnusedReservedMB"] = Math.Round(Profiler.GetTotalUnusedReservedMemoryLong() / (1024.0 * 1024.0), 2),
-                ["monoUsedMB"] = Math.Round(Profiler.GetMonoUsedSizeLong() / (1024.0 * 1024.0), 2),
-                ["monoHeapMB"] = Math.Round(Profiler.GetMonoHeapSizeLong() / (1024.0 * 1024.0), 2),
-                ["graphicsDriverMB"] = Math.Round(Profiler.GetAllocatedMemoryForGraphicsDriver() / (1024.0 * 1024.0), 2),
+                ["totalAllocatedMB"] = Math.Round(UProfiler.GetTotalAllocatedMemoryLong() / (1024.0 * 1024.0), 2),
+                ["totalReservedMB"] = Math.Round(UProfiler.GetTotalReservedMemoryLong() / (1024.0 * 1024.0), 2),
+                ["totalUnusedReservedMB"] = Math.Round(UProfiler.GetTotalUnusedReservedMemoryLong() / (1024.0 * 1024.0), 2),
+                ["monoUsedMB"] = Math.Round(UProfiler.GetMonoUsedSizeLong() / (1024.0 * 1024.0), 2),
+                ["monoHeapMB"] = Math.Round(UProfiler.GetMonoHeapSizeLong() / (1024.0 * 1024.0), 2),
+                ["graphicsDriverMB"] = Math.Round(UProfiler.GetAllocatedMemoryForGraphicsDriver() / (1024.0 * 1024.0), 2),
             };
 
             return new

MCPForUnity/Editor/Tools/Graphics/RenderingStatsOps.cs

@@ -0,0 +1,85 @@
+using System;
+using System.Threading.Tasks;
+using MCPForUnity.Editor.Helpers;
+using Newtonsoft.Json.Linq;
+
+namespace MCPForUnity.Editor.Tools.Profiler
+{
+    [McpForUnityTool("manage_profiler", AutoRegister = false, Group = "profiling")]
+    public static class ManageProfiler
+    {
+        public static async Task<object> HandleCommand(JObject @params)
+        {
+            if (@params == null)
+                return new ErrorResponse("Parameters cannot be null.");
+
+            var p = new ToolParams(@params);
+            string action = p.Get("action")?.ToLowerInvariant();
+
+            if (string.IsNullOrEmpty(action))
+                return new ErrorResponse("'action' parameter is required.");
+
+            try
+            {
+                switch (action)
+                {
+                    // Session
+                    case "profiler_start":
+                        return SessionOps.Start(@params);
+                    case "profiler_stop":
+                        return SessionOps.Stop(@params);
+                    case "profiler_status":
+                        return SessionOps.Status(@params);
+                    case "profiler_set_areas":
+                        return SessionOps.SetAreas(@params);
+
+                    // Counters
+                    case "get_frame_timing":
+                        return FrameTimingOps.GetFrameTiming(@params);
+                    case "get_counters":
+                        return await CounterOps.GetCountersAsync(@params);
+                    case "get_object_memory":
+                        return ObjectMemoryOps.GetObjectMemory(@params);
+
+                    // Memory Snapshot
+                    case "memory_take_snapshot":
+                        return await MemorySnapshotOps.TakeSnapshotAsync(@params);
+                    case "memory_list_snapshots":
+                        return MemorySnapshotOps.ListSnapshots(@params);
+                    case "memory_compare_snapshots":
+                        return MemorySnapshotOps.CompareSnapshots(@params);
+
+                    // Frame Debugger
+                    case "frame_debugger_enable":
+                        return FrameDebuggerOps.Enable(@params);
+                    case "frame_debugger_disable":
+                        return FrameDebuggerOps.Disable(@params);
+                    case "frame_debugger_get_events":
+                        return FrameDebuggerOps.GetEvents(@params);
+
+                    // Utility
+                    case "ping":
+                        return new SuccessResponse("manage_profiler is available.", new
+                        {
+                            tool = "manage_profiler",
+                            group = "profiling"
+                        });
+
+                    default:
+                        return new ErrorResponse(
+                            $"Unknown action: '{action}'. Valid actions: "
+                            + "profiler_start, profiler_stop, profiler_status, profiler_set_areas, "
+                            + "get_frame_timing, get_counters, get_object_memory, "
+                            + "memory_take_snapshot, memory_list_snapshots, memory_compare_snapshots, "
+                            + "frame_debugger_enable, frame_debugger_disable, frame_debugger_get_events, "
+                            + "ping.");
+                }
+            }
+            catch (Exception ex)
+            {
+                McpLog.Error($"[ManageProfiler] Action '{action}' failed: {ex}");
+                return new ErrorResponse($"Error in action '{action}': {ex.Message}");
+            }
+        }
+    }
+}