Remove support for by-reference server

Author: donatj

src/ProxyAwareSchemer.php

@@ -40,14 +40,14 @@ class ProxyAwareSchemer {
 	 */
 	public function __construct(
 		?array $proxyServerValues = null,
-		?array &$server = null
+		?array $server = null
 	) {
 		$this->proxyServerValues = $proxyServerValues ?? self::HTTPS_EXPECTED_SERVER_VALUES;
 
 		if( is_array($server) ) {
-			$this->server =& $server;
+			$this->server = $server;
 		} else {
-			$this->server =& $_SERVER;
+			$this->server = $_SERVER;
 		}
 	}
 

test/ProxyAwareSchemerTest.php

@@ -14,15 +14,13 @@ class ProxyAwareSchemerTest extends TestCase {
 	public function test_withDetectedScheme_https( string $key, string $value ) : void {
 		$request = new ServerRequest('GET', 'http://localhost');
 
-		$server                = [$key => $value];
+		$server                = [ $key => $value ];
 		$schemerManuallyPassed = new ProxyAwareSchemer(null, $server);
 		$this->assertSame('https', $schemerManuallyPassed->withUriWithDetectedScheme($request)->getUri()->getScheme());
 
-		$schemerPre  = new ProxyAwareSchemer;
 		$_SERVER     = [ $key => $value ];
 		$schemerPost = new ProxyAwareSchemer;
 
-		$this->assertSame('https', $schemerPre->withUriWithDetectedScheme($request)->getUri()->getScheme());
 		$this->assertSame('https', $schemerPost->withUriWithDetectedScheme($request)->getUri()->getScheme());
 	}
 
@@ -33,11 +31,9 @@ public function test_withDetectedScheme_http() : void {
 		$schemerManuallyPassed = new ProxyAwareSchemer(null, $server);
 		$this->assertSame('http', $schemerManuallyPassed->withUriWithDetectedScheme($request)->getUri()->getScheme());
 
-		$schemerPre  = new ProxyAwareSchemer;
 		$_SERVER     = [];
 		$schemerPost = new ProxyAwareSchemer;
 
-		$this->assertSame('http', $schemerPre->withUriWithDetectedScheme($request)->getUri()->getScheme());
 		$this->assertSame('http', $schemerPost->withUriWithDetectedScheme($request)->getUri()->getScheme());
 	}