Skip to content

Commit c6d0061

Browse files
Fixed a bug where view duration was reported in ms and not s. (#36)
1 parent 59b1589 commit c6d0061

File tree

3 files changed

+14
-6
lines changed

3 files changed

+14
-6
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
* ! Minor breaking change ! The module override functionality is being removed from the SDK.
3131
* ! Minor breaking change ! It is not possible to set the logging tag anymore.
3232
* Fixed a bug where the wrong platform field value was being sent in the view request.
33+
* Fixed a bug where view duration was reported in ms and not s.
3334
* Updated JSON library version from "20180813" to "20230227".
3435

3536
20.11.5

app-java/src/main/java/ly/count/java/demo/Sample.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,8 @@ public void LogHappened(String logMessage, Config.LoggingLevel logLevel) {
148148
System.out.println("9) Set user profile");
149149
System.out.println("10) Set user custom profile");
150150
System.out.println("11) Record an exception");
151+
System.out.println("12) Start a view called 'example_view'");
152+
System.out.println("13) End a view called 'example_view'");
151153
System.out.println("0) Exit ");
152154

153155

@@ -189,6 +191,12 @@ public void LogHappened(String logMessage, Config.LoggingLevel logLevel) {
189191
case 11:
190192
recordCrash();
191193
break;
194+
case 12:
195+
Countly.session().view("example_view").start(true);
196+
break;
197+
case 13:
198+
Countly.session().view("example_view").stop(false);
199+
break;
192200
default:
193201
break;
194202
}

sdk-java/src/main/java/ly/count/sdk/java/internal/ViewImpl.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,7 @@ public void start(boolean firstView) {
4949
this.started = true;
5050
this.firstView = firstView;
5151

52-
start = (EventImpl) session.event(EVENT).addSegments(NAME, this.name,
53-
VISIT, VISIT_VALUE,
54-
SEGMENT, Device.dev.getOS());
52+
start = (EventImpl) session.event(EVENT).addSegments(NAME, this.name, VISIT, VISIT_VALUE, SEGMENT, Device.dev.getOS());
5553

5654
if (firstView) {
5755
start.addSegment(START, START_VALUE);
@@ -79,10 +77,11 @@ public void stop(boolean lastView) {
7977
}
8078
ended = true;
8179

82-
EventImpl event = (EventImpl) session.event(EVENT).addSegments(NAME, this.name,
83-
SEGMENT, SEGMENT_VALUE);
80+
EventImpl event = (EventImpl) session.event(EVENT).addSegments(NAME, this.name, SEGMENT, SEGMENT_VALUE);
8481

85-
event.setDuration(Device.dev.uniqueTimestamp() - start.getTimestamp());
82+
long viewDurationSeconds = (Device.dev.uniqueTimestamp() - start.getTimestamp()) / 1000;
83+
84+
event.setDuration(viewDurationSeconds);
8685

8786
if (lastView) {
8887
event.addSegment(EXIT, EXIT_VALUE);

0 commit comments

Comments
 (0)