Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'visit' method for expressions #11

Open
nobeh opened this issue Jun 13, 2015 · 2 comments
Open

Add 'visit' method for expressions #11

nobeh opened this issue Jun 13, 2015 · 2 comments
Assignees
@vlad-serbanescu
Labels
compiler
Milestone
0.5.0

Comments

@nobeh
Copy link
Member

nobeh commented Jun 13, 2015

We have a challenge here.

The AST that is generated for ABS by bnf actually does not have a 1-to-1 mapping to JavaWriter API methods. For example, we have left && right in ABS but JavaWriter does not provide an API to write && in the middle of two expressions.

Workaround, we might extend/copy JavaWriter and allow specific API methods added to be able to continue development. In due time, we need to revisit the API and fix compatibility issues.
@nobeh nobeh added the compiler label Jun 13, 2015
@nobeh nobeh added this to the 0.5.0 milestone Jun 13, 2015
nobeh added a commit that referenced this issue Jun 13, 2015
@nobeh
Initial commit for expressions
b498133 
Rel #11
@vlad-serbanescu
Copy link
Contributor

Issue #9 is related to this one, only its for assigning "right" expression to a "left" type

@nobeh
Copy link
Member Author

nobeh commented Jun 21, 2015

Is #28 duplicate of this one @vlad-serbanescu ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vlad-serbanescu vlad-serbanescu

Labels
compiler
Projects
None yet
Milestone
0.5.0
Development

No branches or pull requests
2 participants
@nobeh @vlad-serbanescu