Skip to content

Commit 88ffff1

Browse files
author
Jesse Eichar
committed
added forgotten code quality files
1 parent 466ff4c commit 88ffff1

7 files changed

+524
-0
lines changed

code_quality/checkstyle_checks.xml

+114
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,114 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.3//EN" "http://www.puppycrawl.com/dtds/configuration_1_3.dtd">
3+
4+
<!--
5+
Checkstyle-Configuration: Geonetwork
6+
Description: This configuration was created by eclipse and can be easily edited with eclipse as well.
7+
-->
8+
<module name="Checker">
9+
<property name="severity" value="warning"/>
10+
<module name="TreeWalker">
11+
<property name="tabWidth" value="4"/>
12+
<module name="FileContentsHolder"/>
13+
<module name="JavadocMethod">
14+
<property name="scope" value="protected"/>
15+
<property name="allowMissingThrowsTags" value="true"/>
16+
<property name="allowMissingReturnTag" value="true"/>
17+
<property name="suppressLoadErrors" value="true"/>
18+
</module>
19+
<module name="JavadocType"/>
20+
<module name="JavadocVariable">
21+
<property name="scope" value="protected"/>
22+
</module>
23+
<module name="JavadocStyle"/>
24+
<module name="ConstantName"/>
25+
<module name="LocalFinalVariableName"/>
26+
<module name="LocalVariableName"/>
27+
<module name="MemberName">
28+
<property name="format" value="^_[a-zA-Z0-9]*$"/>
29+
</module>
30+
<module name="MethodName"/>
31+
<module name="PackageName"/>
32+
<module name="ParameterName"/>
33+
<module name="StaticVariableName"/>
34+
<module name="TypeName"/>
35+
<module name="AvoidStarImport"/>
36+
<module name="IllegalImport"/>
37+
<module name="RedundantImport"/>
38+
<module name="UnusedImports"/>
39+
<module name="LineLength">
40+
<property name="max" value="140"/>
41+
</module>
42+
<module name="MethodLength"/>
43+
<module name="ParameterNumber"/>
44+
<module name="EmptyForIteratorPad"/>
45+
<module name="MethodParamPad"/>
46+
<module name="NoWhitespaceAfter">
47+
<property name="tokens" value="BNOT,DEC,DOT,INC,LNOT,UNARY_MINUS,UNARY_PLUS"/>
48+
</module>
49+
<module name="NoWhitespaceBefore"/>
50+
<module name="OperatorWrap"/>
51+
<module name="ParenPad"/>
52+
<module name="TypecastParenPad"/>
53+
<module name="WhitespaceAfter"/>
54+
<module name="WhitespaceAround"/>
55+
<module name="ModifierOrder"/>
56+
<module name="RedundantModifier"/>
57+
<module name="AvoidNestedBlocks"/>
58+
<module name="EmptyBlock"/>
59+
<module name="LeftCurly"/>
60+
<module name="NeedBraces"/>
61+
<module name="RightCurly"/>
62+
<module name="AvoidInlineConditionals"/>
63+
<module name="EmptyStatement"/>
64+
<module name="EqualsHashCode"/>
65+
<module name="HiddenField"/>
66+
<module name="IllegalInstantiation"/>
67+
<module name="InnerAssignment"/>
68+
<module name="MagicNumber"/>
69+
<module name="MissingSwitchDefault"/>
70+
<module name="RedundantThrows">
71+
<property name="suppressLoadErrors" value="true"/>
72+
</module>
73+
<module name="SimplifyBooleanExpression"/>
74+
<module name="SimplifyBooleanReturn"/>
75+
<module name="DesignForExtension"/>
76+
<module name="FinalClass"/>
77+
<module name="HideUtilityClassConstructor"/>
78+
<module name="InterfaceIsType"/>
79+
<module name="VisibilityModifier"/>
80+
<module name="ArrayTypeStyle"/>
81+
<module name="FinalParameters"/>
82+
<module name="TodoComment">
83+
<property name="severity" value="ignore"/>
84+
<metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit"/>
85+
</module>
86+
<module name="UpperEll"/>
87+
</module>
88+
<module name="JavadocPackage"/>
89+
<module name="NewlineAtEndOfFile">
90+
<property name="severity" value="ignore"/>
91+
<metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit"/>
92+
</module>
93+
<module name="Translation"/>
94+
<module name="FileLength"/>
95+
<module name="FileTabCharacter">
96+
<property name="severity" value="ignore"/>
97+
<metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit"/>
98+
</module>
99+
<module name="RegexpSingleline">
100+
<property name="severity" value="ignore"/>
101+
<property name="format" value="\s+$"/>
102+
<property name="message" value="Line has trailing spaces."/>
103+
<metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit"/>
104+
</module>
105+
<module name="SuppressionFilter">
106+
<property name="file" value="${samedir}/checkstyle_suppressions.xml"/>
107+
</module>
108+
<module name="SuppressionCommentFilter"/>
109+
<module name="SuppressionCommentFilter">
110+
<property name="offCommentFormat" value="CSOFF\: ([\w\|]+)"/>
111+
<property name="onCommentFormat" value="CSON\: ([\w\|]+)"/>
112+
<property name="checkFormat" value="$1"/>
113+
</module>
114+
</module>
+11
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
<?xml version="1.0"?>
2+
3+
<!DOCTYPE suppressions PUBLIC
4+
"-//Puppy Crawl//DTD Suppressions 1.1//EN"
5+
"http://www.puppycrawl.com/dtds/suppressions_1_1.dtd">
6+
7+
<suppressions>
8+
<suppress files=".*Test.*\.java" checks="[a-zA-Z0-9]*"/>
9+
<suppress files=".*DummyGraph\.java" checks="[a-zA-Z0-9]*"/>
10+
<suppress files=".*" checks="[a-zA-Z0-9]*"/>
11+
</suppressions>

code_quality/cleanup.xml

+56
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,56 @@
1+
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
2+
<profiles version="2">
3+
<profile kind="CleanUpProfile" name="Caltar cleanup" version="2">
4+
<setting id="cleanup.remove_unused_private_fields" value="true"/>
5+
<setting id="cleanup.always_use_parentheses_in_expressions" value="false"/>
6+
<setting id="cleanup.never_use_blocks" value="false"/>
7+
<setting id="cleanup.remove_unused_private_methods" value="true"/>
8+
<setting id="cleanup.add_missing_deprecated_annotations" value="true"/>
9+
<setting id="cleanup.convert_to_enhanced_for_loop" value="true"/>
10+
<setting id="cleanup.remove_unnecessary_nls_tags" value="true"/>
11+
<setting id="cleanup.sort_members" value="false"/>
12+
<setting id="cleanup.remove_unused_local_variables" value="false"/>
13+
<setting id="cleanup.never_use_parentheses_in_expressions" value="true"/>
14+
<setting id="cleanup.remove_unused_private_members" value="false"/>
15+
<setting id="cleanup.remove_unnecessary_casts" value="true"/>
16+
<setting id="cleanup.make_parameters_final" value="true"/>
17+
<setting id="cleanup.use_this_for_non_static_field_access" value="false"/>
18+
<setting id="cleanup.remove_private_constructors" value="true"/>
19+
<setting id="cleanup.use_blocks" value="true"/>
20+
<setting id="cleanup.always_use_this_for_non_static_method_access" value="false"/>
21+
<setting id="cleanup.remove_trailing_whitespaces_all" value="true"/>
22+
<setting id="cleanup.always_use_this_for_non_static_field_access" value="false"/>
23+
<setting id="cleanup.use_this_for_non_static_field_access_only_if_necessary" value="true"/>
24+
<setting id="cleanup.add_default_serial_version_id" value="true"/>
25+
<setting id="cleanup.make_type_abstract_if_missing_method" value="false"/>
26+
<setting id="cleanup.qualify_static_member_accesses_through_subtypes_with_declaring_class" value="true"/>
27+
<setting id="cleanup.make_variable_declarations_final" value="true"/>
28+
<setting id="cleanup.add_missing_nls_tags" value="false"/>
29+
<setting id="cleanup.format_source_code" value="true"/>
30+
<setting id="cleanup.qualify_static_method_accesses_with_declaring_class" value="false"/>
31+
<setting id="cleanup.add_missing_override_annotations" value="true"/>
32+
<setting id="cleanup.remove_unused_private_types" value="true"/>
33+
<setting id="cleanup.add_missing_methods" value="false"/>
34+
<setting id="cleanup.make_local_variable_final" value="true"/>
35+
<setting id="cleanup.correct_indentation" value="true"/>
36+
<setting id="cleanup.add_missing_override_annotations_interface_methods" value="true"/>
37+
<setting id="cleanup.remove_unused_imports" value="true"/>
38+
<setting id="cleanup.remove_trailing_whitespaces_ignore_empty" value="false"/>
39+
<setting id="cleanup.make_private_fields_final" value="true"/>
40+
<setting id="cleanup.add_generated_serial_version_id" value="false"/>
41+
<setting id="cleanup.organize_imports" value="true"/>
42+
<setting id="cleanup.remove_trailing_whitespaces" value="true"/>
43+
<setting id="cleanup.sort_members_all" value="false"/>
44+
<setting id="cleanup.use_blocks_only_for_return_and_throw" value="false"/>
45+
<setting id="cleanup.add_missing_annotations" value="true"/>
46+
<setting id="cleanup.use_parentheses_in_expressions" value="false"/>
47+
<setting id="cleanup.qualify_static_field_accesses_with_declaring_class" value="false"/>
48+
<setting id="cleanup.use_this_for_non_static_method_access_only_if_necessary" value="true"/>
49+
<setting id="cleanup.use_this_for_non_static_method_access" value="false"/>
50+
<setting id="cleanup.qualify_static_member_accesses_through_instances_with_declaring_class" value="true"/>
51+
<setting id="cleanup.add_serial_version_id" value="false"/>
52+
<setting id="cleanup.format_source_code_changes_only" value="false"/>
53+
<setting id="cleanup.qualify_static_member_accesses_with_declaring_class" value="true"/>
54+
<setting id="cleanup.always_use_blocks" value="true"/>
55+
</profile>
56+
</profiles>

code_quality/codetemplates.xml

+30
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
<?xml version="1.0" encoding="UTF-8" standalone="no"?><templates><template autoinsert="true" context="gettercomment_context" deleted="false" description="Comment for getter method" enabled="true" id="org.eclipse.jdt.ui.text.codetemplates.gettercomment" name="gettercomment">/**
2+
* @return the ${bare_field_name}
3+
*/</template><template autoinsert="true" context="settercomment_context" deleted="false" description="Comment for setter method" enabled="true" id="org.eclipse.jdt.ui.text.codetemplates.settercomment" name="settercomment">/**
4+
* @param ${param} the ${bare_field_name} to set
5+
*/</template><template autoinsert="true" context="constructorcomment_context" deleted="false" description="Comment for created constructors" enabled="true" id="org.eclipse.jdt.ui.text.codetemplates.constructorcomment" name="constructorcomment">/**
6+
* ${tags}
7+
*/</template><template autoinsert="false" context="filecomment_context" deleted="false" description="Comment for created Java files" enabled="true" id="org.eclipse.jdt.ui.text.codetemplates.filecomment" name="filecomment"/><template autoinsert="true" context="typecomment_context" deleted="false" description="Comment for created types" enabled="true" id="org.eclipse.jdt.ui.text.codetemplates.typecomment" name="typecomment">/**
8+
* @author ${user}
9+
*
10+
* ${tags}
11+
*/</template><template autoinsert="true" context="fieldcomment_context" deleted="false" description="Comment for fields" enabled="true" id="org.eclipse.jdt.ui.text.codetemplates.fieldcomment" name="fieldcomment">/**
12+
*
13+
*/</template><template autoinsert="true" context="methodcomment_context" deleted="false" description="Comment for non-overriding methods" enabled="true" id="org.eclipse.jdt.ui.text.codetemplates.methodcomment" name="methodcomment">/**
14+
* ${tags}
15+
*/</template><template autoinsert="false" context="overridecomment_context" deleted="false" description="Comment for overriding methods" enabled="true" id="org.eclipse.jdt.ui.text.codetemplates.overridecomment" name="overridecomment"/><template autoinsert="false" context="delegatecomment_context" deleted="false" description="Comment for delegate methods" enabled="true" id="org.eclipse.jdt.ui.text.codetemplates.delegatecomment" name="delegatecomment">/**
16+
* This is a delegate method
17+
* ${tags}
18+
* ${see_to_target}
19+
*/</template><template autoinsert="true" context="newtype_context" deleted="false" description="Newly created files" enabled="true" id="org.eclipse.jdt.ui.text.codetemplates.newtype" name="newtype">${filecomment}
20+
${package_declaration}
21+
22+
${typecomment}
23+
${type_declaration}</template><template autoinsert="true" context="classbody_context" deleted="false" description="Code in new class type bodies" enabled="true" id="org.eclipse.jdt.ui.text.codetemplates.classbody" name="classbody">
24+
</template><template autoinsert="true" context="interfacebody_context" deleted="false" description="Code in new interface type bodies" enabled="true" id="org.eclipse.jdt.ui.text.codetemplates.interfacebody" name="interfacebody">
25+
</template><template autoinsert="true" context="enumbody_context" deleted="false" description="Code in new enum type bodies" enabled="true" id="org.eclipse.jdt.ui.text.codetemplates.enumbody" name="enumbody">
26+
</template><template autoinsert="true" context="annotationbody_context" deleted="false" description="Code in new annotation type bodies" enabled="true" id="org.eclipse.jdt.ui.text.codetemplates.annotationbody" name="annotationbody">
27+
</template><template autoinsert="true" context="catchblock_context" deleted="false" description="Code in new catch blocks" enabled="true" id="org.eclipse.jdt.ui.text.codetemplates.catchblock" name="catchblock">// ${todo} Auto-generated catch block
28+
${exception_var}.printStackTrace();</template><template autoinsert="true" context="methodbody_context" deleted="false" description="Code in created method stubs" enabled="true" id="org.eclipse.jdt.ui.text.codetemplates.methodbody" name="methodbody">// ${todo} Auto-generated method stub
29+
${body_statement}</template><template autoinsert="true" context="constructorbody_context" deleted="false" description="Code in created constructor stubs" enabled="true" id="org.eclipse.jdt.ui.text.codetemplates.constructorbody" name="constructorbody">${body_statement}
30+
// ${todo} Auto-generated constructor stub</template><template autoinsert="true" context="getterbody_context" deleted="false" description="Code in created getters" enabled="true" id="org.eclipse.jdt.ui.text.codetemplates.getterbody" name="getterbody">return ${field};</template><template autoinsert="true" context="setterbody_context" deleted="false" description="Code in created setters" enabled="true" id="org.eclipse.jdt.ui.text.codetemplates.setterbody" name="setterbody">${field} = ${param};</template></templates>

code_quality/findbugs-excludes.xml

+16
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
<FindBugsFilter>
2+
<!-- Provider matchers that define which classes should *NOT* be analyzed by find bugs.
3+
See http://findbugs.sourceforge.net/manual/filter.html
4+
for the docs on include and exclude filter files
5+
-->
6+
7+
<Match>
8+
<Class name="~.*\..*Test" />
9+
</Match>
10+
<!-- Example showing how to disable the redundant null check in all classes in org.fao.geonet package
11+
<Match>
12+
<Class name="~org\.fao\.geonet\..*" />
13+
<Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE" />
14+
</Match>
15+
-->
16+
</FindBugsFilter>

code_quality/findbugs-includes.xml

+6
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
<FindBugsFilter>
2+
<!-- Provider matchers that define which classes should be analyzed by find bugs.
3+
See http://findbugs.sourceforge.net/manual/filter.html
4+
for the docs on include and exclude filter files
5+
-->
6+
</FindBugsFilter>

0 commit comments

Comments
 (0)