Really correct octave

falkTX · falkTX · commit 1edead12487a · 2022-05-01T07:19:39.000+01:00
Signed-off-by: falkTX &lt;falktx@falktx.com&gt;
diff --git a/plugins/Cardinal/src/AudioToCVPitch.cpp b/plugins/Cardinal/src/AudioToCVPitch.cpp
@@ -120,7 +120,7 @@ struct AudioToCVPitch : Module {
 
             if (detectedPitchInHz > 0.f && pitchConfidence >=  params[PARAM_CONFIDENCETHRESHOLD].getValue() * 0.01f)
             {
-                const float linearPitch = 12.f * (log2f(detectedPitchInHz / 440.f) + octave - 6) + 69.f;
+                const float linearPitch = 12.f * (log2f(detectedPitchInHz / 440.f) + octave - 5) + 69.f;
                 cvPitch = std::max(-10.f, std::min(10.f, linearPitch * (1.f/12.f)));
                 lastKnownPitchInHz = detectedPitchInHz;
                 cvSignal = 10.f;

Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,7 @@ struct AudioToCVPitch : Module {`
`120`	`120`
`121`	`121`	`if (detectedPitchInHz > 0.f && pitchConfidence >= params[PARAM_CONFIDENCETHRESHOLD].getValue() * 0.01f)`
`122`	`122`	`{`
`123`		`- const float linearPitch = 12.f * (log2f(detectedPitchInHz / 440.f) + octave - 6) + 69.f;`
	`123`	`+ const float linearPitch = 12.f * (log2f(detectedPitchInHz / 440.f) + octave - 5) + 69.f;`
`124`	`124`	`cvPitch = std::max(-10.f, std::min(10.f, linearPitch * (1.f/12.f)));`
`125`	`125`	`lastKnownPitchInHz = detectedPitchInHz;`
`126`	`126`	`cvSignal = 10.f;`