Added RSpec tests for Conditional Questions.

John Pinto · John Pinto · commit c388aa6790dd · 2025-04-24T15:49:12.000+01:00
Changes:
         - added and updated tests for Conditional Questions.
         - Fixed a few broken RSpec tests  by replacing
              click_link 'Write plan'  --&gt;  click_link 'Write Plan'.
         - Updated  CHANGELOG.md.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
 # Changelog
 
+- Fix for bug in Conditional questions functionality. In the case of a conditional question with answers that removed questions, any answers of removed questions was not removed. Nor were the removed answers deleted in the database. The Rspec tests were also updated to reflect this change.
+
+
 ## v5.0.0
 
 - Updated app to Rails 7 [#3426](https://github.com/DMPRoadmap/roadmap/pull/3426), [#3496](https://github.com/DMPRoadmap/roadmap/pull/3496)
diff --git a/spec/controllers/answers_controller_with_conditional_questions_spec.rb b/spec/controllers/answers_controller_with_conditional_questions_spec.rb
diff --git a/spec/factories/answers.rb b/spec/factories/answers.rb
@@ -34,5 +34,11 @@
     plan
     user
     question
+    trait :question_options do
+      question_options { [create(:question_option)] }
+    end
+    trait :lock_version do
+      lock_version { 0 }
+    end
   end
 end
diff --git a/spec/factories/conditions.rb b/spec/factories/conditions.rb
@@ -26,7 +26,22 @@
 
 FactoryBot.define do
   factory :condition do
-    option_list { nil }
-    remove_data { nil }
+    option_list { [] }
+    remove_data { [] }
+    action_type { nil }
+    # the webhook_data is a Json string of form:
+    # '{"name":"Joe Bloggs","email":"joe.bloggs@example.com","subject":"Large data volume","message":"A message."}'
+    trait :webhook do
+      action_type { 'add_webhook' }
+      webhook_data do
+        #  Generates string from hash
+        JSON.generate({
+                        name: Faker::Name.name,
+                        email: Faker::Internet.email,
+                        subject: Faker::Lorem.sentence(word_count: 4),
+                        message: Faker::Lorem.paragraph(sentence_count: 2)
+                      })
+      end
+    end
   end
 end
diff --git a/spec/features/questions/checkbox_questions_spec.rb b/spec/features/questions/checkbox_questions_spec.rb
@@ -21,7 +21,7 @@
     visit overview_plan_path(@plan)
 
     # Action
-    click_link 'Write plan'
+    click_link 'Write Plan'
 
     # Expectations
     expect(current_path).to eql(edit_plan_path(@plan))
diff --git a/spec/features/questions/conditions_questions_spec.rb b/spec/features/questions/conditions_questions_spec.rb
diff --git a/spec/features/questions/dropdown_questions_spec.rb b/spec/features/questions/dropdown_questions_spec.rb
@@ -21,7 +21,7 @@
     visit overview_plan_path(@plan)
 
     # Action
-    click_link 'Write plan'
+    click_link 'Write Plan'
 
     # Expectations
     expect(current_path).to eql(edit_plan_path(@plan))
diff --git a/spec/features/questions/radiobuttons_questions_spec.rb b/spec/features/questions/radiobuttons_questions_spec.rb
@@ -21,7 +21,7 @@
     visit overview_plan_path(@plan)
 
     # Action
-    click_link 'Write plan'
+    click_link 'Write Plan'
 
     # Expectations
     expect(current_path).to eql(edit_plan_path(@plan))
diff --git a/spec/features/questions/textarea_questions_spec.rb b/spec/features/questions/textarea_questions_spec.rb
@@ -21,7 +21,7 @@
     visit overview_plan_path(@plan)
 
     # Action
-    click_link 'Write plan'
+    click_link 'Write Plan'
 
     # Expectations
     expect(current_path).to eql(edit_plan_path(@plan))
diff --git a/spec/features/questions/textfield_questions_spec.rb b/spec/features/questions/textfield_questions_spec.rb
@@ -21,7 +21,7 @@
     visit overview_plan_path(@plan)
 
     # Action
-    click_link 'Write plan'
+    click_link 'Write Plan'
 
     # Expectations
     expect(current_path).to eql(edit_plan_path(@plan))
diff --git a/spec/models/condition_spec.rb b/spec/models/condition_spec.rb
@@ -3,5 +3,142 @@
 require 'rails_helper'
 
 RSpec.describe Condition, type: :model do
-  pending "add some examples to (or delete) #{__FILE__}"
+  context 'associations' do
+    it { is_expected.to belong_to :question }
+  end
+
+  describe 'condition with action_type "remove"' do
+    describe '.deep_copy with no options passed in.' do
+      let!(:question) { build(:question) }
+
+      let!(:condition) do
+        build(:condition, question: question, option_list: [1, 5],
+                          action_type: 'remove',
+                          remove_data: [7, 8, 9])
+      end
+
+      subject { condition.deep_copy }
+
+      it 'creates a new record' do
+        expect(subject).not_to eql(condition)
+      end
+      it 'copies the option_list attribute' do
+        expect(subject.option_list).to contain_exactly(1, 5)
+      end
+
+      it 'copies the action_type attribute' do
+        expect(subject.action_type).to eql('remove')
+      end
+
+      it 'copies the remove_data attribute' do
+        expect(subject.remove_data).to contain_exactly(7, 8, 9)
+      end
+
+      it 'copies the  webhook_data attribute' do
+        expect(subject.webhook_data).to be nil
+      end
+    end
+
+    describe '.deep_copy with options passed in.' do
+      let!(:question) { build(:question) }
+
+      let!(:condition) do
+        build(:condition, question: question, option_list: [1, 5],
+                          action_type: 'remove',
+                          remove_data: [7, 8, 9])
+      end
+      let!(:options) { { option_list: [100, 101], action_type: 'remove', remove_data: [200, 220] } }
+
+      subject { condition.deep_copy(**options) }
+
+      it 'creates a new record' do
+        expect(subject).not_to eql(condition)
+      end
+      it 'replaces the option_list attribute with passed option_list' do
+        expect(subject.option_list).to contain_exactly(100, 101)
+      end
+
+      it 'replaces the action_type attribute with passed in action_type' do
+        expect(subject.action_type).to eql('remove')
+      end
+
+      it 'replaces the remove_data attribute with passed in remove_data' do
+        expect(subject.remove_data).to contain_exactly(200, 220)
+      end
+
+      it 'copies the webhook_data attribute' do
+        expect(subject.webhook_data).to eql(condition.webhook_data)
+      end
+    end
+  end
+
+  describe 'condition with action_type "add_webhook"' do
+    describe '.deep_copy with no options passed in.' do
+      let!(:question) { build(:question) }
+
+      # condition with action_type "add_webhook" using :webhook trait
+      let!(:condition) do
+        build(:condition, :webhook, question: question)
+      end
+
+      subject { condition.deep_copy }
+
+      it 'creates a new record' do
+        expect(subject).not_to eql(condition)
+      end
+      it 'copies the option_list attribute' do
+        expect(subject.option_list).to eq([])
+      end
+
+      it 'copies the action_type attribute' do
+        expect(subject.action_type).to eql('add_webhook')
+      end
+
+      it 'copies the remove_data attribute' do
+        expect(subject.remove_data).to eq([])
+      end
+
+      it 'copies the  webhook_data attribute' do
+        expect(subject.webhook_data).to eq(condition.webhook_data)
+      end
+    end
+
+    describe '.deep_copy with options passed in.' do
+      let!(:question) { build(:question) }
+
+      let!(:condition) do
+        build(:condition, :webhook, question: question)
+      end
+
+      # rubocop:disable Layout/LineLength
+      let!(:option_web_data) { '{"name":"Joe Bloggs","email":"joe.bloggs@example.com","subject":"Large data volume","message":"A message."}' }
+      # rubocop:enable Layout/LineLength
+
+      let!(:options) do
+        { option_list: [], action_type: 'add_webhook', remove_data: [],
+          webhook_data: option_web_data }
+      end
+
+      subject { condition.deep_copy(**options) }
+
+      it 'creates a new record' do
+        expect(subject).not_to eql(condition)
+      end
+      it 'replaces the option_list attribute with passed option_list' do
+        expect(subject.option_list).to eq([])
+      end
+
+      it 'replaces the action_type attribute with passed in action_type' do
+        expect(subject.action_type).to eql('add_webhook')
+      end
+
+      it 'replaces the remove_data attribute with passed in remove_data' do
+        expect(subject.remove_data).to eq([])
+      end
+
+      it 'copies the webhook_data attribute' do
+        expect(subject.webhook_data).to eq(option_web_data)
+      end
+    end
+  end
 end
diff --git a/spec/rails_helper.rb b/spec/rails_helper.rb
@@ -48,6 +48,7 @@
 RSpec.configure do |config|
   config.include(AutoCompleteHelper, type: :feature)
   config.include(CapybaraHelper, type: :feature)
+  config.include(LinksHelper, type: :feature)
   config.include(SessionsHelper, type: :feature)
   config.include(TinyMceHelper,  type: :feature)
 
