Skip to content

Commit b8d9eb7

Browse files
Renyong Wanshemminger
Renyong Wan
authored andcommitted
net/xsc: fix resource leaks
Fixed the Coverity-detected issue that resource leaks. Coverity issue: 457741 Fixes: 3d57851 ("net/xsc: check null pointer dereference") Signed-off-by: Rong Qian <[email protected]> Signed-off-by: Renyong Wan <[email protected]>
1 parent 8ab833f commit b8d9eb7

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

drivers/net/xsc/xsc_rx.c

+10-4
Original file line numberDiff line numberDiff line change
@@ -309,8 +309,11 @@ xsc_rss_qp_create(struct xsc_ethdev_priv *priv, int port_id)
309309

310310
for (i = 0; i < priv->num_rq; i++) {
311311
rxq_data = xsc_rxq_get(priv, i);
312-
if (rxq_data == NULL)
313-
return -EINVAL;
312+
if (rxq_data == NULL) {
313+
rte_errno = EINVAL;
314+
goto error;
315+
}
316+
314317
req = (struct xsc_cmd_create_qp_request *)(&in->data[0] + entry_len * i);
315318
req->input_qpn = rte_cpu_to_be_16(0); /* useless for eth */
316319
req->pa_num = rte_cpu_to_be_16(pa_num);
@@ -350,8 +353,11 @@ xsc_rss_qp_create(struct xsc_ethdev_priv *priv, int port_id)
350353

351354
for (i = 0; i < priv->num_rq; i++) {
352355
rxq_data = xsc_rxq_get(priv, i);
353-
if (rxq_data == NULL)
354-
return -EINVAL;
356+
if (rxq_data == NULL) {
357+
rte_errno = EINVAL;
358+
goto error;
359+
}
360+
355361
rxq_data->wqes = rxq_data->rq_pas->addr;
356362
if (!xsc_dev_is_vf(xdev))
357363
rxq_data->rq_db = (uint32_t *)((uint8_t *)xdev->bar_addr +

0 commit comments

Comments
 (0)