feat: add platform info to CLI version printout #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Panos Vagenas <[email protected]>
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Signed-off-by: Panos Vagenas <[email protected]>
PeterStaar-IBM
previously approved these changes
Jan 27, 2025
|
we could also add |
Signed-off-by: Panos Vagenas <[email protected]>
vagenas
dismissed stale reviews from dolfim-ibm and PeterStaar-IBM
via
a5c3601
@dolfim-ibm good point, added now. |
dolfim-ibm
approved these changes
Jan 27, 2025
vancura
pushed a commit
to vancura/docling
that referenced
this pull request
Feb 6, 2025
* feat: add platform info to CLI version printout Signed-off-by: Panos Vagenas <[email protected]> * Update main.py Signed-off-by: Panos Vagenas <[email protected]> * add Python implementation & language versions Signed-off-by: Panos Vagenas <[email protected]> --------- Signed-off-by: Panos Vagenas <[email protected]> Signed-off-by: Václav Vančura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding platform info based on platform.platform(), aiming to getting OS, OS version, and architecture out of the box with
docling --version(e.g. for debugging issues etc.)