Skip to content

Commit 52f11ff

Browse files
committed
Use docker.io prefix for images on Docker hub
Docker assumes docker.io by default, but there are other container runtimes (for example Podman) where this should be explicit. It is better to use fully-qualified image names to support other runtime environments in the future.
1 parent ea67a15 commit 52f11ff

File tree

6 files changed

+10
-10
lines changed

6 files changed

+10
-10
lines changed

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# This image will be published as dspace/dspace-angular
22
# See https://github.com/DSpace/dspace-angular/tree/main/docker for usage details
33

4-
FROM node:14-alpine
4+
FROM docker.io/node:14-alpine
55
WORKDIR /app
66
ADD . /app/
77
EXPOSE 4000

docker/cli.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ version: "3.7"
1616

1717
services:
1818
dspace-cli:
19-
image: "${DOCKER_OWNER:-dspace}/dspace-cli:${DSPACE_VER:-dspace-7_x}"
19+
image: "docker.io/${DOCKER_OWNER:-dspace}/dspace-cli:${DSPACE_VER:-dspace-7_x}"
2020
container_name: dspace-cli
2121
environment:
2222
# Below syntax may look odd, but it is how to override dspace.cfg settings via env variables.

docker/db.entities.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ version: "3.7"
1616

1717
services:
1818
dspacedb:
19-
image: dspace/dspace-postgres-pgcrypto:loadsql
19+
image: docker.io/dspace/dspace-postgres-pgcrypto:loadsql
2020
environment:
2121
# This LOADSQL should be kept in sync with the URL in DSpace/DSpace
2222
# This SQL is available from https://github.com/DSpace-Labs/AIP-Files/releases/tag/demo-entities-data

docker/docker-compose-ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ services:
3232
solr__P__server: http://dspacesolr:8983/solr
3333
depends_on:
3434
- dspacedb
35-
image: dspace/dspace:dspace-7_x-test
35+
image: docker.io/dspace/dspace:dspace-7_x-test
3636
networks:
3737
dspacenet:
3838
ports:
@@ -65,7 +65,7 @@ services:
6565
# This SQL is available from https://github.com/DSpace-Labs/AIP-Files/releases/tag/demo-entities-data
6666
LOADSQL: https://github.com/DSpace-Labs/AIP-Files/releases/download/demo-entities-data/dspace7-entities-data.sql
6767
PGDATA: /pgdata
68-
image: dspace/dspace-postgres-pgcrypto:loadsql
68+
image: docker.io/dspace/dspace-postgres-pgcrypto:loadsql
6969
networks:
7070
dspacenet:
7171
stdin_open: true
@@ -76,7 +76,7 @@ services:
7676
dspacesolr:
7777
container_name: dspacesolr
7878
# Uses official Solr image at https://hub.docker.com/_/solr/
79-
image: solr:8.11-slim
79+
image: docker.io/solr:8.11-slim
8080
# Needs main 'dspace' container to start first to guarantee access to solr_configs
8181
depends_on:
8282
- dspace

docker/docker-compose-rest.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ services:
3939
# proxies.trusted.ipranges: This setting is required for a REST API running in Docker to trust requests
4040
# from the host machine. This IP range MUST correspond to the 'dspacenet' subnet defined above.
4141
proxies__P__trusted__P__ipranges: '172.23.0'
42-
image: dspace/dspace:dspace-7_x-test
42+
image: docker.io/dspace/dspace:dspace-7_x-test
4343
depends_on:
4444
- dspacedb
4545
networks:
@@ -69,7 +69,7 @@ services:
6969
container_name: dspacedb
7070
environment:
7171
PGDATA: /pgdata
72-
image: dspace/dspace-postgres-pgcrypto
72+
image: docker.io/dspace/dspace-postgres-pgcrypto
7373
networks:
7474
dspacenet:
7575
ports:
@@ -83,7 +83,7 @@ services:
8383
dspacesolr:
8484
container_name: dspacesolr
8585
# Uses official Solr image at https://hub.docker.com/_/solr/
86-
image: solr:8.11-slim
86+
image: docker.io/solr:8.11-slim
8787
# Needs main 'dspace' container to start first to guarantee access to solr_configs
8888
depends_on:
8989
- dspace

docker/docker-compose.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ services:
2424
DSPACE_REST_HOST: localhost
2525
DSPACE_REST_PORT: 8080
2626
DSPACE_REST_NAMESPACE: /server
27-
image: dspace/dspace-angular:dspace-7_x
27+
image: docker.io/dspace/dspace-angular:dspace-7_x
2828
build:
2929
context: ..
3030
dockerfile: Dockerfile

0 commit comments

Comments
 (0)