Metadata representation components compare `BrowseByDataType` values to `ResourceType`

[ybnd]

Describe the bug
This discrepancy was highlighted by the @typescript-eslint/no-unsafe-enum-comparison rule in #2865
There is no overlap between the BrowseByDataType enum and the string value of VALUE_LIST_BROWSE_DEFINITION. Appears in

• dspace-angular/src/app/shared/object-list/metadata-representation-list-element/plain-text/plain-text-metadata-list-element.component.ts

  Line 25 in 0a1764c

  if (this.mdRepresentation.browseDefinition.getRenderType() === VALUE_LIST_BROWSE_DEFINITION.value) {

• dspace-angular/src/app/shared/object-list/metadata-representation-list-element/browse-link/browse-link-metadata-list-element.component.ts

  Line 25 in 0a1764c

  if (this.mdRepresentation.browseDefinition.getRenderType() === VALUE_LIST_BROWSE_DEFINITION.value) {

• dspace-angular/src/app/item-page/field-components/metadata-values/metadata-values.component.ts

  Line 120 in 0a1764c

  if (this.browseDefinition.getRenderType() === VALUE_LIST_BROWSE_DEFINITION.value) {

Expected behavior
The comparison should be consistent with the types on either side, possibly by using this.mdRepresentation.browseDefinition.type.

Related work

• @alexandrevryghem changed the return type of getRenderTypes from string to BrowseByDataType in Created abstract component loader class #2339 (line)
• @WWelling discovered a possibly related bug in Fix simple item view author link #2949 (before the type change)