Skip to content

Infinite loading for embargoed image in ImageViewer #4213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
GraziaQuercia opened this issue Apr 17, 2025 · 3 comments · May be fixed by #4284
Open

Infinite loading for embargoed image in ImageViewer #4213

GraziaQuercia opened this issue Apr 17, 2025 · 3 comments · May be fixed by #4284
Assignees
@VictorDuranEscire
Labels
affects: main Issue impacts "main" (latest release). affects: 8.x Issue impacts 8.x releases bug testathon Reported by a tester during Community Testathon

Comments

@GraziaQuercia
Copy link

Describe the bug

Starting from line 189 in Testathon file:

Images: Normal usage: Created item with two picture bitstreams, zooming and pagination controls are shown. Image: Image Viewer is not working when some bitstream has some restricted access condition Issue duplicated issue!

When an item has two bitstreams in image format (example: PNG) and one of them is embargoed, the Image Viewer remains stuck in infinite loading when trying to display the embargoed image.

To Reproduce

Steps to reproduce the behavior:

  1. Start a submission and attach two images
  2. Set the embargo on the second image
  3. Deposit the item
  4. Visit the same item as anonymous
  5. Open the image viewer by clicking on the image preview box
  6. Display the first non-embargoed image
  7. Click on "Next" arrow to display the second embargoed image
DSpace.Repository.__.Home.webm

Expected behavior

The functionality can be resolved in different ways.
One possible solution could be to skip the visualisation of embargoed images.
This means that only the non-embargoed images can be displayed in the viewer.
@GraziaQuercia GraziaQuercia added bug needs triage New issue needs triage and/or scheduling labels Apr 17, 2025
@github-project-automation github-project-automation bot moved this to 🆕 Triage in DSpace Backlog Apr 17, 2025
@kshepherd
Copy link
Member

it would be good to confirm this on demo.dspace.org so we know if this issue was introduced after 8.1, or already existed

@tdonohue tdonohue added the testathon Reported by a tester during Community Testathon label Apr 17, 2025
@VictorDuranEscire
Copy link
Contributor

Hi @kshepherd , I was able to replicate the issue in demo, I would like to work on it.
@tdonohue

Image

@kshepherd
Copy link
Member

ok thanks @VictorDuranEscire ! i'll assign you to this issue. feel free to request a review from me when you have a PR ready.
(the deadline for bugfix PR creation is May 2nd at this point)

@VictorDuranEscire VictorDuranEscire linked a pull request Apr 30, 2025 that will close this issue
Open
12 tasks
@tdonohue tdonohue added affects: main Issue impacts "main" (latest release). affects: 8.x Issue impacts 8.x releases and removed needs triage New issue needs triage and/or scheduling labels Apr 30, 2025
@tdonohue tdonohue moved this from 📋 To Do to 🏗 In Progress in DSpace 8.x and 7.6.x Maintenance Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VictorDuranEscire VictorDuranEscire

Labels
affects: main Issue impacts "main" (latest release). affects: 8.x Issue impacts 8.x releases bug testathon Reported by a tester during Community Testathon
Projects
DSpace 8.x and 7.6.x Maintenance
Status: 🏗 In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FIx - Infinite loading for embargoed image in ImageViewer VictorDuranEscire/dspace-lyrasis
4 participants
@kshepherd @tdonohue @GraziaQuercia @VictorDuranEscire