Eslint 9 upgrade #4823
Merged
Eslint 9 upgrade #4823
+204
−794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandrevryghem
added
the
dependencies
|
Hi @alexandrevryghem, |
- Replaced eslint-plugin-deprecation dependency with the new built-in @typescript-eslint/no-deprecated rule - Replaced unmaintained eslint-plugin-rxjs dependency with @smarttools/eslint-plugin-rxjs
alexandrevryghem
force-pushed
the
eslint-9-upgrade
branch
from
8f94217 to
034c467
Compare
tdonohue
approved these changes
Nov 25, 2025
Member
tdonohue
left a comment
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @alexandrevryghem ! This looks good to me and I see that all lint checks pass in GitHub CI. (As a sidenote, I cannot verify the behavior on Windows because I'm hitting this new error #4872...however, that error also exists on main, so it's unrelated to this PR)
I'm going to merge this as it looks to work well. Will also flag this for backport to dspace-9_x as it'd be good to backport this to 9.0 (especially since we backported the Angular 20 upgrade already)
github-project-automation
bot
moved this from 🙋 Needs Reviewers Assigned
to 👍 Reviewer Approved
in DSpace 10.0 Release
tdonohue
added
the
port to dspace-9_x
github-project-automation
bot
moved this from 👍 Reviewer Approved
to ✅ Done
in DSpace 10.0 Release
Contributor
|
Successfully created backport PR for |
tdonohue
removed
the
port to dspace-9_x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Description
Updated the ESLint version to v9, since ESLint v8 is now EOL. I also removed two unsupported dependencies and replaced them with supported rule equivalents. Some parts of this PR could be backported to older DSpace versions, but upgrading the ESLint version would require backporting the fixes made in #4804 as well.
Instructions for Reviewers
List of changes in this PR:
eslint-plugin-deprecationdependency. Starting from@[email protected], a similar rule was introduced which doesn't require any additional dependencies:@typescript-eslint/no-deprecatedeslint-plugin-rxjsdependency with@smarttools/eslint-plugin-rxjs, since the old dependency hasn't been updated for over four years and lacks ESLint 9 supportGuidance for how to review this PR:
Checklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.