[BUG] "Failed to draw thing entry!" for buildings on very big shelves

[abel1502]

Describe the bug
First of all, this is most likely a compatibility issue, but I couldn't pinpoint it to a particular mod.

The issue is that uninstalled buildings stored in very big shelves don't render properly. The icon is rendered, but the remaining part of the box is filled with a "Failed to draw thing entry!" label. The logs show a NullReferenceException in DSGUI_ListItem.DoDraw. Apparently, line

RW_DSGUI/Source/DSGUI/ListModal/DSGUI_ListItem.cs

Line 58 in 170ed85

DSGUI.Elements.DrawThingIcon(iconRect, Target, iconScale);

does run, since the icon can be seen.

To Reproduce

1. Have the modlist from the log (probably)
2. Place a Very Big Shelf from DeepStorage
3. Place a bedroll on it
4. Select a pawn and right-click the shelf
5. See error label

Expected behavior
The normal menu should pop up, as it does with other shelves (including Very Big ones) that don't have uninstalled buildings in them

Additional context
Full log.

Error:

System.NullReferenceException: Object reference not set to an instance of an object
  at DSGUI.DSGUI_ListItem.DoDraw (UnityEngine.Rect inRect, System.Single y, System.Boolean altBG) [0x000c1] in <1afc7d4faca84b699be039554bc4be03>:0 
  at DSGUI.DSGUI_ListModal.DoWindowContents (UnityEngine.Rect inRect) [0x004b0] in <1afc7d4faca84b699be039554bc4be03>:0  
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 39)

I understand the context I'm providing is way too general, so I'll try to debug it myself, and report the results here.

[abel1502]

Okay, the repo seems to be significantly outdated...

[abel1502]

I have fixed it by removing the following code:

RW_DSGUI/Source/DSGUI/ListModal/DSGUI_ListItem.cs

Lines 60 to 62 in 170ed85

	if (Target.Map.reservationManager.IsReservedByAnyoneOf(Target, Faction.OfPlayer)) {
	// DSGUI.Elements.DrawIconFitted(iconRect, thingIcon, thingColor, iconScale);
	}

. (I have, in fact, done that on the compiled DLL, since the source code only compiles the 1.3 version. But I'm pretty sure it's this same statement - in the DLL, it's also a standalone unused boolean expression)