Skip to content

Commit 0a42e6f

Browse files
committed
Use --ignore-platform-req=php+ in community build
--ignore-platform-reqs may accidentally install versions of dependencies that no longer support the given PHP version. --ignore-platform-req=php+ will only suppress errors for new PHP version but not change behavior for older versions. Thanks to Tim for the hint. Also skip the Laravel build for PHP 8.1, which is no longer supported on Laravel's default branch.
1 parent b508133 commit 0a42e6f

File tree

2 files changed

+13
-9
lines changed

2 files changed

+13
-9
lines changed

.github/workflows/nightly.yml

+12-9
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,9 @@ on:
2929
windows_version:
3030
required: true
3131
type: string
32+
skip_laravel:
33+
required: true
34+
type: boolean
3235
skip_symfony:
3336
required: true
3437
type: boolean
@@ -550,7 +553,7 @@ jobs:
550553
git clone "https://github.com/amphp/$repository.git" "amphp-$repository" --depth 1
551554
cd "amphp-$repository"
552555
git rev-parse HEAD
553-
php /usr/bin/composer install --no-progress --ignore-platform-reqs
556+
php /usr/bin/composer install --no-progress --ignore-platform-req=php+
554557
vendor/bin/phpunit || EXIT_CODE=$?
555558
if [ ${EXIT_CODE:-0} -gt 128 ]; then
556559
X=1;
@@ -559,12 +562,12 @@ jobs:
559562
done
560563
exit $X
561564
- name: Test Laravel
562-
if: ${{ !cancelled() }}
565+
if: ${{ !cancelled() && !inputs.skip_laravel }}
563566
run: |
564567
git clone https://github.com/laravel/framework.git --depth=1
565568
cd framework
566569
git rev-parse HEAD
567-
php /usr/bin/composer install --no-progress --ignore-platform-reqs
570+
php /usr/bin/composer install --no-progress --ignore-platform-req=php+
568571
# Hack to disable a test that hangs
569572
php -r '$c = file_get_contents("tests/Filesystem/FilesystemTest.php"); $c = str_replace("public function testSharedGet()", "#[\\PHPUnit\\Framework\\Attributes\\Group('"'"'skip'"'"')]\n public function testSharedGet()", $c); file_put_contents("tests/Filesystem/FilesystemTest.php", $c);'
570573
php vendor/bin/phpunit --exclude-group skip || EXIT_CODE=$?
@@ -581,7 +584,7 @@ jobs:
581584
git clone "https://github.com/reactphp/$repository.git" "reactphp-$repository" --depth 1
582585
cd "reactphp-$repository"
583586
git rev-parse HEAD
584-
php /usr/bin/composer install --no-progress --ignore-platform-reqs
587+
php /usr/bin/composer install --no-progress --ignore-platform-req=php+
585588
vendor/bin/phpunit || EXIT_CODE=$?
586589
if [ $[EXIT_CODE:-0} -gt 128 ]; then
587590
X=1;
@@ -595,7 +598,7 @@ jobs:
595598
git clone https://github.com/revoltphp/event-loop.git --depth=1
596599
cd event-loop
597600
git rev-parse HEAD
598-
php /usr/bin/composer install --no-progress --ignore-platform-reqs
601+
php /usr/bin/composer install --no-progress --ignore-platform-req=php+
599602
vendor/bin/phpunit || EXIT_CODE=$?
600603
if [ ${EXIT_CODE:-0} -gt 128 ]; then
601604
exit 1
@@ -606,7 +609,7 @@ jobs:
606609
git clone https://github.com/symfony/symfony.git --depth=1
607610
cd symfony
608611
git rev-parse HEAD
609-
php /usr/bin/composer install --no-progress --ignore-platform-reqs
612+
php /usr/bin/composer install --no-progress --ignore-platform-req=php+
610613
php ./phpunit install
611614
# Test causes a heap-buffer-overflow but I cannot reproduce it locally...
612615
php -r '$c = file_get_contents("src/Symfony/Component/HtmlSanitizer/Tests/HtmlSanitizerCustomTest.php"); $c = str_replace("public function testSanitizeDeepNestedString()", "/** @group skip */\n public function testSanitizeDeepNestedString()", $c); file_put_contents("src/Symfony/Component/HtmlSanitizer/Tests/HtmlSanitizerCustomTest.php", $c);'
@@ -627,15 +630,15 @@ jobs:
627630
git clone https://github.com/sebastianbergmann/phpunit.git --branch=main --depth=1
628631
cd phpunit
629632
git rev-parse HEAD
630-
php /usr/bin/composer install --no-progress --ignore-platform-reqs
633+
php /usr/bin/composer install --no-progress --ignore-platform-req=php+
631634
php ./phpunit || EXIT_CODE=$?
632635
if [ ${EXIT_CODE:-0} -gt 128 ]; then
633636
exit 1
634637
fi
635638
- name: 'Symfony Preloading'
636639
if: ${{ !cancelled() && !inputs.skip_symfony }}
637640
run: |
638-
php /usr/bin/composer create-project symfony/symfony-demo symfony_demo --no-progress --ignore-platform-reqs
641+
php /usr/bin/composer create-project symfony/symfony-demo symfony_demo --no-progress --ignore-platform-req=php+
639642
cd symfony_demo
640643
git rev-parse HEAD
641644
sed -i 's/PHP_SAPI/"cli-server"/g' var/cache/dev/App_KernelDevDebugContainer.preload.php
@@ -646,7 +649,7 @@ jobs:
646649
git clone https://github.com/WordPress/wordpress-develop.git wordpress --depth=1
647650
cd wordpress
648651
git rev-parse HEAD
649-
php /usr/bin/composer install --no-progress --ignore-platform-reqs
652+
php /usr/bin/composer install --no-progress --ignore-platform-req=php+
650653
cp wp-tests-config-sample.php wp-tests-config.php
651654
sed -i 's/youremptytestdbnamehere/test/g' wp-tests-config.php
652655
sed -i 's/yourusernamehere/root/g' wp-tests-config.php

.github/workflows/root.yml

+1
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ jobs:
5959
(((matrix.branch.version[0] == 8 && matrix.branch.version[1] >= 5) || matrix.branch.version[0] >= 9) && '24.04')
6060
|| '22.04' }}
6161
windows_version: ${{ ((matrix.branch.version[0] == 8 && matrix.branch.version[1] >= 4) || matrix.branch.version[0] >= 9) && '2022' || '2019' }}
62+
skip_laravel: ${{ matrix.branch.version[0] == 8 && matrix.branch.version[1] == 1 }}
6263
skip_symfony: ${{ matrix.branch.version[0] == 8 && matrix.branch.version[1] == 1 }}
6364
skip_wordpress: ${{ matrix.branch.version[0] == 8 && matrix.branch.version[1] == 1 }}
6465
secrets: inherit

0 commit comments

Comments
 (0)