From 900f8eb584942b50d2b54f331dc84222dc1e9bce Mon Sep 17 00:00:00 2001 From: Brad Lewis <22850972+BradLewis@users.noreply.github.com> Date: Wed, 3 Jun 2026 05:31:27 +1000 Subject: [PATCH] Missed responding MethodNotFound, add check for id --- src/server/requests.odin | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/server/requests.odin b/src/server/requests.odin index a2f34787..5db0a612 100644 --- a/src/server/requests.odin +++ b/src/server/requests.odin @@ -338,8 +338,11 @@ call :: proc(value: json.Value, id: RequestId, writer: ^Writer, config: ^common. if !ok { log.errorf("Failed to find method: %#v", root) - response := make_response_message_error(id = id, error = ResponseError{code = .MethodNotFound, message = ""}) - send_error(response, writer) + // nil id == notification - do not respond + if id != nil { + response := make_response_message_error(id = id, error = ResponseError{code = .MethodNotFound, message = ""}) + send_error(response, writer) + } return }