refactor(core/client): Move sync/hubServer setup to single ready event

Author: Danktuary

core/client.js

@@ -1,11 +1,7 @@
 const path = require('path')
 const { AkairoClient, CommandHandler, ListenerHandler } = require('discord-akairo')
-const Sync = require('./sync.js')
-const HubServer = require('./hubServer.js')
 const database = require('../database/index.js')
 const { ownerID, prefix } = require('../config.js')
-const EmojiVotingPoll = require('./poll/EmojiVotingPoll.js')
-const RenameVotingPoll = require('./poll/RenameVotingPoll.js')
 
 module.exports = class RinonClient extends AkairoClient {
 	constructor() {
@@ -45,13 +41,8 @@ module.exports = class RinonClient extends AkairoClient {
 		this.commandHandler.useListenerHandler(this.listenerHandler)
 		this.listenerHandler.loadAll()
 
-		this.once('ready', () => {
-			this.sync = new Sync(this)
-			this.hubServer = new HubServer(this)
-			// NOTE: This stays here because the 2 classes depend on the `hubServer[votingChannel]` props
-			this.hubServer.polls = { emoji: new EmojiVotingPoll(this), rename: new RenameVotingPoll(this) }
-			this.sync.status()
-		})
+		this.sync = null
+		this.hubServer = null
 	}
 
 	async login(token) {

core/hubServer.js

@@ -1,10 +1,16 @@
 const { hubServerID } = require('../config.js')
 const regexes = require('../util/regexes.js')
+const EmojiVotingPoll = require('./poll/EmojiVotingPoll.js')
+const RenameVotingPoll = require('./poll/RenameVotingPoll.js')
 
 module.exports = class HubServer {
 	constructor(client) {
 		this.client = client
 		this.guild = client.guilds.cache.get(hubServerID)
+		this.polls = {
+			emoji: new EmojiVotingPoll(client),
+			rename: new RenameVotingPoll(client),
+		}
 	}
 
 	_getChannel(name) {

listeners/ready.js

@@ -1,4 +1,6 @@
 const { Listener } = require('discord-akairo')
+const Sync = require('../core/sync.js')
+const HubServer = require('../core/hubServer.js')
 
 module.exports = class ReadyListener extends Listener {
 	constructor() {
@@ -10,6 +12,9 @@ module.exports = class ReadyListener extends Listener {
 	}
 
 	exec() {
+		this.client.sync = new Sync(this.client)
+		this.client.hubServer = new HubServer(this.client)
+		this.client.sync.status()
 		console.log(`${this.client.user.tag} ready!`)
 	}
 }