Skip to content

Commit 9a9908d

Browse files
Stojak139808SergiiDmytruk
Stojak139808
authored and
SergiiDmytruk
committed
soc/power9/: change logs in dump_cal_errors()
Change-Id: Idea5bd1ff8785da99f808e18b4dfa2765fe88788 Signed-off-by: Kacper Stojek <[email protected]> Signed-off-by: Sergii Dmytruk <[email protected]>
1 parent d9dfc5d commit 9a9908d

File tree

2 files changed

+55
-58
lines changed

2 files changed

+55
-58
lines changed

‎src/soc/ibm/power9/ccs.c‎

Lines changed: 36 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -104,55 +104,54 @@ static void dump_cal_errors(uint8_t chip, chiplet_id_t id, int mca_i)
104104
/* Stop CCS so it won't mess up with the values */
105105
write_scom_for_chiplet(chip, id, CCS_CNTLQ, PPC_BIT(CCS_CNTLQ_CCS_STOP));
106106

107-
#if CONFIG(DEBUG_RAM_SETUP)
108107
int dp;
109108

110109
for (dp = 0; dp < 5; dp++) {
111-
printk(BIOS_ERR, "DP %d\n", dp);
112-
printk(BIOS_ERR, "\t%#16.16llx - RD_VREF_CAL_ERROR\n",
113-
dp_mca_read(id, dp, mca_i, DDRPHY_DP16_RD_VREF_CAL_ERROR_P0_0));
114-
printk(BIOS_ERR, "\t%#16.16llx - DQ_BIT_DISABLE_RP0\n",
115-
dp_mca_read(id, dp, mca_i, DDRPHY_DP16_DQ_BIT_DISABLE_RP0_P0_0));
116-
printk(BIOS_ERR, "\t%#16.16llx - DQS_BIT_DISABLE_RP0\n",
117-
dp_mca_read(id, dp, mca_i, DDRPHY_DP16_DQS_BIT_DISABLE_RP0_P0_0));
118-
printk(BIOS_ERR, "\t%#16.16llx - WR_ERROR0\n",
119-
dp_mca_read(id, dp, mca_i, DDRPHY_DP16_WR_ERROR0_P0_0));
120-
printk(BIOS_ERR, "\t%#16.16llx - RD_STATUS0\n",
121-
dp_mca_read(id, dp, mca_i, DDRPHY_DP16_RD_STATUS0_P0_0));
122-
printk(BIOS_ERR, "\t%#16.16llx - RD_LVL_STATUS2\n",
123-
dp_mca_read(id, dp, mca_i, DDRPHY_DP16_RD_LVL_STATUS2_P0_0));
124-
printk(BIOS_ERR, "\t%#16.16llx - RD_LVL_STATUS0\n",
125-
dp_mca_read(id, dp, mca_i, DDRPHY_DP16_RD_LVL_STATUS0_P0_0));
126-
printk(BIOS_ERR, "\t%#16.16llx - WR_VREF_ERROR0\n",
127-
dp_mca_read(id, dp, mca_i, DDRPHY_DP16_WR_VREF_ERROR0_P0_0));
128-
printk(BIOS_ERR, "\t%#16.16llx - WR_VREF_ERROR1\n",
129-
dp_mca_read(id, dp, mca_i, DDRPHY_DP16_WR_VREF_ERROR1_P0_0));
110+
printk(RAM_SPEW, "DP %d\n", dp);
111+
printk(RAM_SPEW, "\t%#16.16llx - RD_VREF_CAL_ERROR\n",
112+
dp_mca_read(chip, id, dp, mca_i, DDRPHY_DP16_RD_VREF_CAL_ERROR_P0_0));
113+
printk(RAM_SPEW, "\t%#16.16llx - DQ_BIT_DISABLE_RP0\n",
114+
dp_mca_read(chip, id, dp, mca_i, DDRPHY_DP16_DQ_BIT_DISABLE_RP0_P0_0));
115+
printk(RAM_SPEW, "\t%#16.16llx - DQS_BIT_DISABLE_RP0\n",
116+
dp_mca_read(chip, id, dp, mca_i, DDRPHY_DP16_DQS_BIT_DISABLE_RP0_P0_0));
117+
printk(RAM_SPEW, "\t%#16.16llx - WR_ERROR0\n",
118+
dp_mca_read(chip, id, dp, mca_i, DDRPHY_DP16_WR_ERROR0_P0_0));
119+
printk(RAM_SPEW, "\t%#16.16llx - RD_STATUS0\n",
120+
dp_mca_read(chip, id, dp, mca_i, DDRPHY_DP16_RD_STATUS0_P0_0));
121+
printk(RAM_SPEW, "\t%#16.16llx - RD_LVL_STATUS2\n",
122+
dp_mca_read(chip, id, dp, mca_i, DDRPHY_DP16_RD_LVL_STATUS2_P0_0));
123+
printk(RAM_SPEW, "\t%#16.16llx - RD_LVL_STATUS0\n",
124+
dp_mca_read(chip, id, dp, mca_i, DDRPHY_DP16_RD_LVL_STATUS0_P0_0));
125+
printk(RAM_SPEW, "\t%#16.16llx - WR_VREF_ERROR0\n",
126+
dp_mca_read(chip, id, dp, mca_i, DDRPHY_DP16_WR_VREF_ERROR0_P0_0));
127+
printk(RAM_SPEW, "\t%#16.16llx - WR_VREF_ERROR1\n",
128+
dp_mca_read(chip, id, dp, mca_i, DDRPHY_DP16_WR_VREF_ERROR1_P0_0));
130129
}
131130

132-
printk(BIOS_ERR, "%#16.16llx - APB_ERROR_STATUS0\n",
133-
mca_read(id, mca_i, DDRPHY_APB_ERROR_STATUS0_P0));
131+
printk(RAM_SPEW, "%#16.16llx - APB_ERROR_STATUS0\n",
132+
mca_read(chip, id, mca_i, DDRPHY_APB_ERROR_STATUS0_P0));
134133

135-
printk(BIOS_ERR, "%#16.16llx - RC_ERROR_STATUS0\n",
136-
mca_read(id, mca_i, DDRPHY_RC_ERROR_STATUS0_P0));
134+
printk(RAM_SPEW, "%#16.16llx - RC_ERROR_STATUS0\n",
135+
mca_read(chip, id, mca_i, DDRPHY_RC_ERROR_STATUS0_P0));
137136

138-
printk(BIOS_ERR, "%#16.16llx - SEQ_ERROR_STATUS0\n",
139-
mca_read(id, mca_i, DDRPHY_SEQ_ERROR_STATUS0_P0));
137+
printk(RAM_SPEW, "%#16.16llx - SEQ_ERROR_STATUS0\n",
138+
mca_read(chip, id, mca_i, DDRPHY_SEQ_ERROR_STATUS0_P0));
140139

141-
printk(BIOS_ERR, "%#16.16llx - WC_ERROR_STATUS0\n",
142-
mca_read(id, mca_i, DDRPHY_WC_ERROR_STATUS0_P0));
140+
printk(RAM_SPEW, "%#16.16llx - WC_ERROR_STATUS0\n",
141+
mca_read(chip, id, mca_i, DDRPHY_WC_ERROR_STATUS0_P0));
143142

144-
printk(BIOS_ERR, "%#16.16llx - PC_ERROR_STATUS0\n",
145-
mca_read(id, mca_i, DDRPHY_PC_ERROR_STATUS0_P0));
143+
printk(RAM_SPEW, "%#16.16llx - PC_ERROR_STATUS0\n",
144+
mca_read(chip, id, mca_i, DDRPHY_PC_ERROR_STATUS0_P0));
146145

147-
printk(BIOS_ERR, "%#16.16llx - PC_INIT_CAL_ERROR\n",
148-
mca_read(id, mca_i, DDRPHY_PC_INIT_CAL_ERROR_P0));
146+
printk(RAM_SPEW, "%#16.16llx - PC_INIT_CAL_ERROR\n",
147+
mca_read(chip, id, mca_i, DDRPHY_PC_INIT_CAL_ERROR_P0));
149148

150-
printk(BIOS_ERR, "%#16.16llx - PC_INIT_CAL_STATUS\n",
151-
mca_read(id, mca_i, DDRPHY_PC_INIT_CAL_STATUS_P0));
149+
printk(RAM_SPEW, "%#16.16llx - PC_INIT_CAL_STATUS\n",
150+
mca_read(chip, id, mca_i, DDRPHY_PC_INIT_CAL_STATUS_P0));
151+
152+
printk(RAM_SPEW, "%#16.16llx - IOM_PHY0_DDRPHY_FIR_REG\n",
153+
mca_read(chip, id, mca_i, IOM_PHY0_DDRPHY_FIR_REG));
152154

153-
printk(BIOS_ERR, "%#16.16llx - IOM_PHY0_DDRPHY_FIR_REG\n",
154-
mca_read(id, mca_i, IOM_PHY0_DDRPHY_FIR_REG));
155-
#endif
156155
die("CCS execution timeout\n");
157156
}
158157

‎src/soc/ibm/power9/istep_13_11.c‎

Lines changed: 19 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,6 @@ static void clear_initial_cal_errors(uint8_t chip, int mcs_i, int mca_i)
130130

131131
static void dump_cal_errors(uint8_t chip, int mcs_i, int mca_i)
132132
{
133-
#if CONFIG(DEBUG_RAM_SETUP)
134133
chiplet_id_t id = mcs_ids[mcs_i];
135134
int dp;
136135

@@ -141,55 +140,54 @@ static void dump_cal_errors(uint8_t chip, int mcs_i, int mca_i)
141140
* Serial over LAN and may not print few last characters.
142141
*/
143142
for (dp = 0; dp < 5; dp++) {
144-
printk(BIOS_ERR, "DP %d\n", dp);
145-
printk(BIOS_ERR, "\t%#16.16llx - RD_VREF_CAL_ERROR\n",
143+
printk(RAM_SPEW, "DP %d\n", dp);
144+
printk(RAM_SPEW, "\t%#16.16llx - RD_VREF_CAL_ERROR\n",
146145
dp_mca_read(chip, id, dp, mca_i, DDRPHY_DP16_RD_VREF_CAL_ERROR_P0_0));
147-
printk(RAM_DEBUG, "\t%#16.16llx - DQ_BIT_DISABLE_RP0\n",
146+
printk(RAM_SPEW, "\t%#16.16llx - DQ_BIT_DISABLE_RP0\n",
148147
dp_mca_read(chip, id, dp, mca_i, DDRPHY_DP16_DQ_BIT_DISABLE_RP0_P0_0));
149-
printk(BIOS_ERR, "\t%#16.16llx - DQS_BIT_DISABLE_RP0\n",
148+
printk(RAM_SPEW, "\t%#16.16llx - DQS_BIT_DISABLE_RP0\n",
150149
dp_mca_read(chip, id, dp, mca_i, DDRPHY_DP16_DQS_BIT_DISABLE_RP0_P0_0));
151-
printk(BIOS_ERR, "\t%#16.16llx - WR_ERROR0\n",
150+
printk(RAM_SPEW, "\t%#16.16llx - WR_ERROR0\n",
152151
dp_mca_read(chip, id, dp, mca_i, DDRPHY_DP16_WR_ERROR0_P0_0));
153-
printk(BIOS_ERR, "\t%#16.16llx - RD_STATUS0\n",
152+
printk(RAM_SPEW, "\t%#16.16llx - RD_STATUS0\n",
154153
dp_mca_read(chip, id, dp, mca_i, DDRPHY_DP16_RD_STATUS0_P0_0));
155-
printk(BIOS_ERR, "\t%#16.16llx - RD_LVL_STATUS2\n",
154+
printk(RAM_SPEW, "\t%#16.16llx - RD_LVL_STATUS2\n",
156155
dp_mca_read(chip, id, dp, mca_i, DDRPHY_DP16_RD_LVL_STATUS2_P0_0));
157-
printk(BIOS_ERR, "\t%#16.16llx - RD_LVL_STATUS0\n",
156+
printk(RAM_SPEW, "\t%#16.16llx - RD_LVL_STATUS0\n",
158157
dp_mca_read(chip, id, dp, mca_i, DDRPHY_DP16_RD_LVL_STATUS0_P0_0));
159-
printk(BIOS_ERR, "\t%#16.16llx - WR_VREF_ERROR0\n",
158+
printk(RAM_SPEW, "\t%#16.16llx - WR_VREF_ERROR0\n",
160159
dp_mca_read(chip, id, dp, mca_i, DDRPHY_DP16_WR_VREF_ERROR0_P0_0));
161-
printk(BIOS_ERR, "\t%#16.16llx - WR_VREF_ERROR1\n",
160+
printk(RAM_SPEW, "\t%#16.16llx - WR_VREF_ERROR1\n",
162161
dp_mca_read(chip, id, dp, mca_i, DDRPHY_DP16_WR_VREF_ERROR1_P0_0));
163162
}
164163

165-
printk(BIOS_ERR, "%#16.16llx - APB_ERROR_STATUS0\n",
164+
printk(RAM_SPEW, "%#16.16llx - APB_ERROR_STATUS0\n",
166165
mca_read(chip, id, mca_i, DDRPHY_APB_ERROR_STATUS0_P0));
167166

168-
printk(BIOS_ERR, "%#16.16llx - RC_ERROR_STATUS0\n",
167+
printk(RAM_SPEW, "%#16.16llx - RC_ERROR_STATUS0\n",
169168
mca_read(chip, id, mca_i, DDRPHY_RC_ERROR_STATUS0_P0));
170169

171-
printk(BIOS_ERR, "%#16.16llx - SEQ_ERROR_STATUS0\n",
170+
printk(RAM_SPEW, "%#16.16llx - SEQ_ERROR_STATUS0\n",
172171
mca_read(chip, id, mca_i, DDRPHY_SEQ_ERROR_STATUS0_P0));
173172

174-
printk(BIOS_ERR, "%#16.16llx - WC_ERROR_STATUS0\n",
173+
printk(RAM_SPEW, "%#16.16llx - WC_ERROR_STATUS0\n",
175174
mca_read(chip, id, mca_i, DDRPHY_WC_ERROR_STATUS0_P0));
176175

177-
printk(BIOS_ERR, "%#16.16llx - PC_ERROR_STATUS0\n",
176+
printk(RAM_SPEW, "%#16.16llx - PC_ERROR_STATUS0\n",
178177
mca_read(chip, id, mca_i, DDRPHY_PC_ERROR_STATUS0_P0));
179178

180-
printk(BIOS_ERR, "%#16.16llx - PC_INIT_CAL_ERROR\n",
179+
printk(RAM_SPEW, "%#16.16llx - PC_INIT_CAL_ERROR\n",
181180
mca_read(chip, id, mca_i, DDRPHY_PC_INIT_CAL_ERROR_P0));
182181

183182
/* 0x8000 on success for first rank, 0x4000 for second */
184-
printk(BIOS_ERR, "%#16.16llx - PC_INIT_CAL_STATUS\n",
183+
printk(RAM_SPEW, "%#16.16llx - PC_INIT_CAL_STATUS\n",
185184
mca_read(chip, id, mca_i, DDRPHY_PC_INIT_CAL_STATUS_P0));
186185

187-
printk(BIOS_ERR, "%#16.16llx - IOM_PHY0_DDRPHY_FIR_REG\n",
186+
printk(RAM_SPEW, "%#16.16llx - IOM_PHY0_DDRPHY_FIR_REG\n",
188187
mca_read(chip, id, mca_i, IOM_PHY0_DDRPHY_FIR_REG));
189188

190-
printk(BIOS_ERR, "%#16.16llx - MBACALFIRQ\n",
189+
printk(RAM_SPEW, "%#16.16llx - MBACALFIRQ\n",
191190
mca_read(chip, id, mca_i, MBACALFIR));
192-
#endif
193191
}
194192

195193
/* Based on ATTR_MSS_MRW_RESET_DELAY_BEFORE_CAL, by default do it. */

0 commit comments

Comments
 (0)