bash-ui-lib: testing claude v2

Signed-off-by: Maciej Pijanowski <[email protected]>

Author: macpijan

bash-ui-lib/README.md

@@ -11,6 +11,7 @@ A reusable Bash library for creating interactive text-based user interfaces with
 - **Submenus**: Support for nested menu structures
 - **Customizable**: Override default rendering with custom callbacks
 - **Well-Tested**: Comprehensive test suite using BATS
+- **Safe**: Gracefully handles non-interactive terminals
 
 ## Installation
 
@@ -24,6 +25,14 @@ git clone <repository-url>
 cp -r bash-ui-lib/lib /path/to/your/project/
 ```
 
+## Requirements
+
+- **Interactive Terminal**: The library requires a TTY (interactive terminal) to function properly
+- **Bash 4.0+**: Uses associative arrays and other modern bash features
+- **Standard utilities**: `tput`, `grep`, `sed` (usually pre-installed)
+
+**Note**: The library will detect non-interactive terminals and exit gracefully with appropriate warnings.
+
 ## Quick Start
 
 Here's a minimal example:

bash-ui-lib/lib/dts-ui-adapter.sh

@@ -137,13 +137,8 @@ _setup_default_dts_menu() {
 # show_footer
 # Show footer with actions using UI library
 show_footer() {
-  # Check if footer is set up
-  if [[ "${#UI_FOOTER_ACTIONS_KEYS[@]}" -eq 0 ]]; then
-    _setup_default_dts_footer
-  fi
-
-  # Render footer using UI library
-  ui_render_footer
+  # Render DTS-style footer directly (don't call ui_render_footer to avoid recursion)
+  _setup_default_dts_footer
 }
 
 # _setup_default_dts_footer
@@ -155,7 +150,13 @@ _setup_default_dts_footer() {
   echo -ne "${RED}${POWEROFF_OPT_UP:-P}${NORMAL} to poweroff  ${NORMAL}"
   echo -e "${RED}${SHELL_OPT_UP:-S}${NORMAL} to enter shell  ${NORMAL}"
 
-  if systemctl is-active sshd.service >/dev/null 2>&1; then
+  # Safely check SSH status - avoid segfault from systemctl issues
+  local ssh_status="inactive"
+  if command -v systemctl &>/dev/null; then
+    ssh_status=$(systemctl is-active sshd.service 2>/dev/null || echo "inactive")
+  fi
+
+  if [[ "$ssh_status" == "active" ]]; then
     echo -ne "${RED}${SSH_OPT_UP:-K}${NORMAL} to stop SSH server  ${NORMAL}"
   else
     echo -ne "${RED}${SSH_OPT_UP:-K}${NORMAL} to launch SSH server  ${NORMAL}"

bash-ui-lib/lib/ui-core.sh

@@ -88,11 +88,18 @@ ui_set_post_render_callback() {
 ui_read_input() {
   UI_INPUT=""
 
+  # Check if terminal is interactive
+  if ! [[ -t 0 ]]; then
+    # Not interactive, exit the loop
+    ui_exit 1
+    return 1
+  fi
+
   if [[ "$UI_INPUT_MODE" == "single" ]]; then
-    read -r -n 1 UI_INPUT
+    read -r -n 1 UI_INPUT || { ui_exit 1; return 1; }
     echo
   else
-    read -r UI_INPUT
+    read -r UI_INPUT || { ui_exit 1; return 1; }
   fi
 }
 

bash-ui-lib/lib/ui-render.sh

@@ -296,6 +296,11 @@ ui_render_screen() {
 ui_handle_menu_selection() {
   local key="$1"
 
+  # Return early if key is empty or invalid
+  if [[ -z "$key" ]]; then
+    return 1
+  fi
+
   # Check if key exists in menu items
   if [[ -n "${UI_MENU_ITEMS_HANDLER[$key]+isset}" ]]; then
     local condition="${UI_MENU_ITEMS_CONDITION[$key]}"
@@ -327,6 +332,11 @@ ui_handle_menu_selection() {
 ui_handle_footer_selection() {
   local key="$1"
 
+  # Return early if key is empty or invalid
+  if [[ -z "$key" ]]; then
+    return 1
+  fi
+
   # Check if key exists in footer actions
   if [[ -n "${UI_FOOTER_ACTIONS_HANDLER[$key]+isset}" ]]; then
     local condition="${UI_FOOTER_ACTIONS_CONDITION[$key]}"

bash-ui-lib/lib/ui-utils.sh

@@ -141,7 +141,13 @@ ui_confirm() {
 # Pause and wait for user to press Enter
 ui_pause() {
   local message="${1:-Press Enter to continue.}"
-  read -r -p "$message"
+  # Check if stdin is available and terminal is interactive
+  if [[ -t 0 ]]; then
+    read -r -p "$message" || true
+  else
+    # Non-interactive, just print message and return
+    echo "$message"
+  fi
 }
 
 # ui_wait_seconds <seconds> [message]