BOOTED_OS_ID: Change all occurrences to global

The Booted OS does not magically return back to the default one after a
suite ends. The variable must be global in every context.

Signed-off-by: Filip Gołaś <[email protected]>

Author: philipanda

lib/bios/menus.robot

@@ -1290,7 +1290,7 @@ Boot System Or From Connected Disk    # robocop: off=too-long-keyword
     [Arguments]    ${env_id}    ${boot_menu}=NOT_SET
     ${system_name}=    Get From Dictionary    ${ENV_ID_OS_BOOTMENU_NAMES}    ${env_id}
 
-    VAR    ${BOOTED_OS_ID}=    ${env_id}    scope=SUITE
+    VAR    ${BOOTED_OS_ID}=    ${env_id}    scope=GLOBAL
     Import Variables    ${CURDIR}/../../os-config/${env_id}-credentials.py
 
     IF    '${DUT_CONNECTION_METHOD}' == 'SSH'    RETURN

lib/bsd.robot

@@ -17,7 +17,7 @@ Boot PfSense Installer
     Write Into Terminal    vt100
     Read From Terminal Until    [Accept]
     Press Enter
-    VAR    ${BOOTED_OS_ID}=    ${ENV_ID_PFSENSE}    scope=SUITE
+    VAR    ${BOOTED_OS_ID}=    ${ENV_ID_PFSENSE}    scope=GLOBAL
     Import Variables    ${CURDIR}/../os-config/${BOOTED_OS_ID}-credentials.py
 
 Boot OPNsense Installer
@@ -29,7 +29,7 @@ Boot OPNsense Installer
     Execute File In File Explorer    bootx64.efi
     Read From Terminal Until    FreeBSD/amd64 (OPNsense.localdomain) (ttyu0)
     Read From Terminal Until    login:
-    VAR    ${BOOTED_OS_ID}=    ${ENV_ID_OPNSENSE}    scope=SUITE
+    VAR    ${BOOTED_OS_ID}=    ${ENV_ID_OPNSENSE}    scope=GLOBAL
     Import Variables    ${CURDIR}/../os-config/${BOOTED_OS_ID}-credentials.py
 
 Enter PfSense Shell
@@ -65,7 +65,7 @@ Boot PfSense
     Execute File In File Explorer    boot
     Execute File In File Explorer    bootx64.efi
     Read From Terminal Until    Enter an option:
-    VAR    ${BOOTED_OS_ID}=    ${ENV_ID_PFSENSE}    scope=SUITE
+    VAR    ${BOOTED_OS_ID}=    ${ENV_ID_PFSENSE}    scope=GLOBAL
     Import Variables    ${CURDIR}/../os-config/${BOOTED_OS_ID}-credentials.py
 
 Boot OPNsense
@@ -76,5 +76,5 @@ Boot OPNsense
     Execute File In File Explorer    boot
     Execute File In File Explorer    bootx64.efi
     Read From Terminal Until    FreeBSD/amd64 (OPNsense.localdomain) (ttyu0)
-    VAR    ${BOOTED_OS_ID}=    ${ENV_ID_OPNSENSE}    scope=SUITE
+    VAR    ${BOOTED_OS_ID}=    ${ENV_ID_OPNSENSE}    scope=GLOBAL
     Import Variables    ${CURDIR}/../os-config/${BOOTED_OS_ID}-credentials.py

lib/dcu.robot

@@ -95,7 +95,7 @@ DCU Variable Set UEFI Option In DUT
     DCU Variable Set UEFI Option In File    tpm.rom    ${option_name}    ${value}
     DCU Variable Flash SMMSTORE    tpm.rom
     Execute Reboot Command
-    VAR    ${BOOTED_OS_ID}=    ${DEFAULT_BOOT_OS_ID}    scope=SUITE
+    VAR    ${BOOTED_OS_ID}=    ${DEFAULT_BOOT_OS_ID}    scope=GLOBAL
     Import Variables    ${CURDIR}/../os-config/${BOOTED_OS_ID}-credentials.py
     Sleep    20s
 

lib/options/options-lib_dcu.robot

@@ -202,7 +202,7 @@ Boot System Or From Connected Disk
     Write Into Terminal    reboot
 
     Import Variables    ${CURDIR}/../../os-config/${env_id}-credentials.py
-    VAR    ${BOOTED_OS_ID}=    ${env_id}    scope=SUITE
+    VAR    ${BOOTED_OS_ID}=    ${env_id}    scope=GLOBAL
     Sleep    30s
 
 Login To Windows Via SSH