lib/bios: make Boot System Or From Connected Disk more generic

Signed-off-by: Filip Lewiński <[email protected]>

Author: filipleple

lib/bios/common.robot

@@ -156,11 +156,14 @@ Boot System Or From Connected Disk    # robocop: disable=too-long-keyword
         ELSE
             ${disk_name}=    Set Variable    ${ssd_list[0]}
         END
-        ${system_index}=    Get Index From List    ${menu_construction}    ${disk_name}
+        # Search the menu for disk name occurrence
+        ${system_index}=    Set Variable    -1
+        ${system_index}=    Evaluate
+        ...    next((i for i, entry in enumerate(${menu_construction}) if "${disk_name}" in entry), -1)
         IF    ${system_index} == -1
             Fail    Disk: ${disk_name} not found in Boot Menu
         END
     ELSE
         ${system_index}=    Get Index Of Matching Option In Menu    ${menu_construction}    ${system_name}
     END
-    Press Key N Times And Enter    ${system_index}    ${ARROW_DOWN}
+    Select Boot Menu Option    ${system_index}    ${ARROW_DOWN}

lib/bios/edk2.robot

@@ -496,3 +496,8 @@ Get Firmware Version From Tianocore Setup Menu
     ${firmware_line}=    Get Lines Containing String    ${output}    Dasharo (coreboot+UEFI)
     ${firmware_version}=    Get Regexp Matches    ${firmware_line}    v\\d{1,}\.\\d{1,}\.\\d{1,}
     RETURN    ${firmware_version}
+
+Select Boot Menu Option
+    [Documentation]    Select the boot menu option using the given index.
+    [Arguments]    ${index}    ${key}
+    Press Key N Times    ${index}    ${key}

lib/bios/seabios.robot

@@ -111,3 +111,15 @@ Enter IPXE
     Enter Boot Menu
     ${menu}=    Get Boot Menu Construction
     Enter Menu From Snapshot    ${menu}    iPXE
+
+# robocop: disable=unused-argument
+
+Select Boot Menu Option
+    [Documentation]    Select the boot menu option using the given index.
+    ...    Accounts for indices counting from zero, and SeaBIOS options counting
+    ...    from '1.'. Has to take a dummy parameter for compatibility with the
+    ...    EDK2 version of this keyword.
+    [Arguments]    ${index}    ${dummy}
+    ${option}=    Evaluate    ${index} + 1
+    Write Bare Into Terminal    '${option}'
+# robocop: disable=unused-argument

platform-configs/optiplex-7010-seabios.robot

@@ -5,7 +5,7 @@ Resource    optiplex-7010.robot
 *** Variables ***
 ${BIOS_LIB}=                        seabios
 ${FW_STRING}=                       ESC
-${SEABIOS_BOOT_DEVICE}=             2
+# ${SEABIOS_BOOT_DEVICE}=    2
 ${BOOT_MENU_KEY}=                   ${ESC}
 ${DMIDECODE_FIRMWARE_VERSION}=      Dasharo (coreboot+SeaBIOS) v0.1.0
 ${DMIDECODE_RELEASE_DATE}=          11/27/2024