Skip to content

Commit a417a54

Browse files
committed
scripts/ci/test_ids/test_id_checking_lib.py: follow test ID convention
In regex we have allowed for an arbitraty characters in the end. In the documentation [1] (and in practice), we are more strict about that. This was the cause of false-positive check: 4e1bfa8, and further issues with syncing to DB. [1] https://github.com/Dasharo/open-source-firmware-validation/blob/develop/docs/adding-and-naming-test-cases.md Signed-off-by: Maciej Pijanowski <[email protected]>
1 parent 4e1bfa8 commit a417a54

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

scripts/ci/test_ids/test_id_checking_lib.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ def get_test_cases_from_dir(directory):
104104

105105

106106
def get_id(test):
107-
res = re.search("^([A-Z]{3,9}[0-9]{3}\\.[0-9]{3}).*", test.name)
107+
res = re.search("^([A-Z]{3,9}[0-9]{3}\\.[0-9]{3})", test.name)
108108
if res:
109109
return res.group(1)
110110
return None

0 commit comments

Comments
 (0)