Skip to content

Commit

Permalink
CI: don't block the pipeline while waiting for a manual job (#555)
Browse files Browse the repository at this point in the history
* CI: don't block the pipeline while waiting for a manual job

* CI: ensure 'change' rule behaves appropriately

When used in a new branch, `changes` always evaluates to true in the
absence of a `compare_to` clause.
This caused all our branch pipelines to happily run the build_ci_image
which hide the blocked pipeline issue when this job is setup as manual.
  • Loading branch information
chouquette authored Apr 3, 2024
1 parent 717ed10 commit 4135b1c
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,12 @@ build_ci_image:
--push \
.
rules:
- changes: ["ci/Dockerfile"]
- changes:
paths:
- "ci/Dockerfile"
compare_to: 'main'
- when: manual
allow_failure: true

build_deb_x64:
extends: [.build, .x64]
Expand Down

0 comments on commit 4135b1c

Please sign in to comment.