Add new variables in advance to work with both versions #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CelianR
reviewed
Apr 24, 2024
.gitlab-ci.yml
Outdated
| :git: Branch <$BRANCH_URL|$CI_COMMIT_BRANCH> for commit \`$CI_COMMIT_TITLE\` (<$COMMIT_URL|$CI_COMMIT_SHORT_SHA>) | ||
| :idea: You can test them in the datadog-agent repository by running: | ||
| \`\`\`inv pipeline.update-buildimages -i v$CI_PIPELINE_ID-${CI_COMMIT_SHORT_SHA} [--no-test-version] [--branch-name <your_branch>]\`\`\` | ||
| \`\`\`inv buildimages.update --v ${IMAGE_VERSION} [--no-test]\`\`\` |
There was a problem hiding this comment.
Should this be either :
\`\`\`inv buildimages.update --version ${IMAGE_VERSION} [--no-test]\`\`\`
or
\`\`\`inv buildimages.update -v ${IMAGE_VERSION} [--no-test]\`\`\`
?
CelianR
approved these changes
May 2, 2024
|
/ping |
|
🚂 Devflow: Pong 🏓 |
|
/status |
|
🚂 Devflow: This pull request is not in the merge queue, type MergeQueue status for DataDog/datadog-agent-buildimages branch main There is currently no merge request being processed. There is no merge request queued There is no merge request waiting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to DataDog/datadog-agent#24638 and #578
Objective is to be able to build only modified images on buildimage PR to have a faster feedback when images are modified