feat(trigger): Update configuration to pass a branch for datadog-agent execution
#748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+371
to
+374
| sed -i -e "s/CI_PIPELINE_ID/${CI_PIPELINE_ID}/g" \ | ||
| -e "s/CI_COMMIT_SHORT_SHA/${CI_COMMIT_SHORT_SHA}/g" \ | ||
| -e "s/ECR_TEST_ONLY/${ECR_TEST_ONLY}/g" \ | ||
| -e "s/GIT_BRANCH/${GIT_BRANCH}/g" .gitlab/trigger_datadog_agent.yml |
There was a problem hiding this comment.
Why do you need that? Wasn't just switching the job to manual with the addition of the GIT_BRANCH variable enough?
There was a problem hiding this comment.
The job was already manual. But as a trigger job, you don't have access to the UI where you can set a variable. I might be wrong though, if you have a better solution I'm happy to use it
There was a problem hiding this comment.
Did not know that trigger job do not let you change the value of the variable 😢
KevinFairise2
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
"Tweak" the gitlab configuration to be able to run the downstream
datadog-agentpipeline on a specific branch.Motivation
Have a more flexible workflow
Possible Drawbacks / Trade-offs
Additional Notes