Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACIX-487] Add linter tooling (shellcheck) #764

Merged
merged 2 commits into from
Feb 19, 2025
Merged

[ACIX-487] Add linter tooling (shellcheck) #764

merged 2 commits into from
Feb 19, 2025

Conversation

CelianR
Copy link
Contributor

@CelianR CelianR commented Feb 18, 2025 •
edited
Loading

What does this PR do?

Adds shellcheck to images to be used in DataDog/datadog-agent#34099.

Motivation

Possible Drawbacks / Trade-offs

Additional Notes

@CelianR CelianR self-assigned this Feb 18, 2025
@CelianR CelianR changed the title [ACIX-487] Add linter tooling [ACIX-487] Add linter tooling (shellcheck) Feb 19, 2025
@CelianR CelianR marked this pull request as ready for review February 19, 2025 09:10
@CelianR CelianR requested review from a team as code owners February 19, 2025 09:10
chouetz
chouetz approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@chouetz chouetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these the only places where you will need this?
Otherwise LGTM, thanks!

@CelianR CelianR merged commit 2781d43 into main Feb 19, 2025
31 checks passed
@CelianR CelianR deleted the celian/shellcheck-acix-487 branch February 19, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chouetz chouetz chouetz approved these changes

Assignees

@CelianR CelianR

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CelianR @chouetz