-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow excluding EC2 tags (implement exclude_ec2_tags configuration option) #13588
Comments
Hi @moleskin-smile do you think this is similar / the same as #3130 ? |
Thanks for looking at this. It's definitely similar, but some of issues described there can be solved now with Metrics Without Limits. The tag collision can't. |
Thanks, agree: We require tags to be filtered/removed at source(ingest) also. Metrics without limits only removes tags during indexing not ingest. |
Hi @moleskin-smile, A The new option works in the same way as Thanks for reporting this feature request ! |
Hi @hush-hush. That's awesome! Thank you. |
@hush-hush, when can we expect the public release of 7.42.0? is it already released? |
@nijogeorgep, |
I'm closing this issue since Agent version |
We're using
collect_ec2_tags
configuration option to tag our Datadog metrics and events with AWS EC2 Instance tags. It's an useful option to tag cloud resources and Datadog events and metrics in a consistent manner.Not all tags are that useful. It's a default and common practice that EC2 instances are tagged with "Name" tags. The purpose of these tags is to help navigate through EC2 instances in AWS Console, but they don't have any semantic meaning in AWS.
The "Name" tag name is so generic it doesn't bring that much value attached to all metrics and events produced on EC2 instances. Moreover some of Datadog metrics and events contain actually useful "name" tags creating problems with dashboards and especially monitors (grouping). This is quite serious issue we can't deal with easily using Datadog in-app configuration.
Examples of tag collision:
source:kubernetes name:*
in Events explorer)We also can't easily remove these tags without sacrificing their usefulness in AWS Console and without maintaining a burden of having a forked Terraform module we use to provision Kubernetes nodes. My attempt of allowing Name tag removal was recently rejected: terraform-aws-modules/terraform-aws-eks#2229.
Unwanted tags could also affect custom metric costs which could in turn affect customer satisfaction negatively.
We'd like to have an ability to configure list of EC2 tags to exclude in Datadog agents (i.e.
exclude_ec2_tags
). "Name" tags are only one example of tag collision that can happen.There's similar option for GCE –
exclude_gce_tags
.(I've requested this via a support request already, but this is sort of a bug – we can't create monitors based on metrics and events mentioned above with grouping by
name
).The text was updated successfully, but these errors were encountered: