Register otlp_config.metrics.sums.initial_cumulative_monotonic_value with Viper #27910
Conversation
|
|
github-actions
bot
added
the
[deprecated] team/agent-shared-components
Regression DetectorRegression Detector ResultsRun ID: 15a88396-762d-4676-8ce3-e9519c9a85b5 Metrics dashboard Target profiles Baseline: 32d0461 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | links |
|---|---|---|---|---|---|
| ➖ | idle | memory utilization | +0.89 | [+0.85, +0.94] | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | +0.28 | [-0.53, +1.09] | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.12 | [-12.81, +13.04] | Logs |
| ➖ | file_tree | memory utilization | +0.07 | [-0.03, +0.17] | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.00, +0.00] | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.06 | [-0.95, +0.84] | Logs |
| ➖ | pycheck_1000_100byte_tags | % cpu utilization | -0.08 | [-4.95, +4.79] | Logs |
| ➖ | basic_py_check | % cpu utilization | -0.47 | [-3.10, +2.15] | Logs |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
pgimalac
added
changelog/no-changelog
qa/done
|
Added some missing labels to avoid generating QA cards for this |
|
/merge |
|
🚂 MergeQueue: waiting for PR to be ready This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
|
/merge |
|
🚂 MergeQueue: waiting for PR to be ready This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
|
/merge |
|
🚂 MergeQueue: waiting for PR to be ready This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
|
/merge |
|
🚂 MergeQueue: waiting for PR to be ready This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
|
/merge |
|
🚂 MergeQueue: waiting for PR to be ready This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
|
This merge request was unqueued If you need support, contact us on Slack #devflow! |
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=40044467 --os-family=ubuntuNote: This applies to commit 6c258d1 |
|
/merge |
|
🚂 MergeQueue: waiting for PR to be ready This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
|
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
What does this PR do?
Register this value with Viper - prevents spurious error messages when the config is used.
Refers to
datadog-agent/comp/otelcol/otlp/components/exporter/serializerexporter/config.go
Line 192 in d6018ec