CWS-3904 - Add DNS Context to Events #33935

kovagsm · 2025-02-11T16:25:12Z

What does this PR do?

Parses incoming DNS responses and caches its values so it can resolve find out what are the IP addresses behind usernames.

They're now being reported in the Connect and Accept syscall events as a string list.

Motivation

To make it possible to filter events using hostnames
In the future it will be possible to filter and create alerts based on known malicious hostnames

Describe how you validated your changes

Manually

Possible Drawbacks / Trade-offs

If the agent is deployed in a server with too much DNS traffic, it could fill up the eBPF buffer and make us lose other events. Possible mitigation: Used the pcap mechanism to capture this traffic
This is also being mitigated by only parsing incoming DNS packets with the field QR=1, so the agent on a DNS server won't be overwhelmed by requests when they're producing mostly outgoing packets.

cit-pr-commenter · 2025-02-11T16:27:49Z

Go Package Import Differences

Baseline: 8a9ff47
Comparison: 64f6779

binary	os	arch	change
security-agent	linux	amd64	+1, -0 +github.com/DataDog/datadog-agent/pkg/security/resolvers/dns
security-agent	linux	arm64	+1, -0 +github.com/DataDog/datadog-agent/pkg/security/resolvers/dns
system-probe	linux	amd64	+1, -0 +github.com/DataDog/datadog-agent/pkg/security/resolvers/dns
system-probe	linux	arm64	+1, -0 +github.com/DataDog/datadog-agent/pkg/security/resolvers/dns

cit-pr-commenter · 2025-02-11T17:10:18Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 818cfc4f-1137-40a8-92ca-c345a73b52ea

Baseline: 8a9ff47
Comparison: f5e9c9d
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.50	[-0.40, +1.39]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.28	[-0.20, +0.75]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.28	[-0.50, +1.06]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.21	[+0.16, +0.27]	1	Logs bounds checks dashboard
➖	file_tree	memory utilization	+0.15	[+0.09, +0.22]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.02	[-0.77, +0.82]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	+0.01	[-0.74, +0.77]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.01	[-0.02, +0.05]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	+0.00	[-0.62, +0.63]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	-0.00	[-0.82, +0.82]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.00	[-0.64, +0.64]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.30, +0.29]	1	Logs
➖	quality_gate_idle	memory utilization	-0.16	[-0.21, -0.12]	1	Logs bounds checks dashboard
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.72	[-1.50, +0.06]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.89	[-0.95, -0.83]	1	Logs
➖	quality_gate_logs	% cpu utilization	-1.70	[-4.59, +1.18]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

agent-platform-auto-pr · 2025-02-11T17:20:13Z

Uncompressed package size comparison

Comparison with ancestor 8a9ff479c9d3e15a5002a54c4cef4468a026dca7

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-aarch64-rpm	0.21MB	⚠️	818.96MB	818.75MB	0.50MB
datadog-agent-x86_64-rpm	0.21MB	⚠️	828.01MB	827.80MB	0.50MB
datadog-agent-x86_64-suse	0.21MB	⚠️	828.01MB	827.80MB	0.50MB
datadog-agent-amd64-deb	0.21MB	⚠️	818.21MB	818.00MB	0.50MB
datadog-agent-arm64-deb	0.21MB	⚠️	809.19MB	808.98MB	0.50MB
datadog-iot-agent-arm64-deb	0.00MB	✅	59.29MB	59.29MB	0.50MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	59.36MB	59.36MB	0.50MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	39.42MB	39.42MB	0.50MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	39.50MB	39.50MB	0.50MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	39.50MB	39.50MB	0.50MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	37.96MB	37.96MB	0.50MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	443.42MB	443.42MB	0.50MB
datadog-iot-agent-amd64-deb	0.00MB	✅	62.06MB	62.06MB	0.50MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	62.13MB	62.13MB	0.50MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	62.13MB	62.13MB	0.50MB

Decision

⚠️ Warning

agent-platform-auto-pr · 2025-02-13T09:59:16Z

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=57196873 --os-family=ubuntu

Note: This applies to commit 64f6779

agent-platform-auto-pr · 2025-02-13T10:02:58Z

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result	Quality gate	On disk size	On disk size limit	On wire size	On wire size limit
✅	static_quality_gate_agent_deb_amd64	792.12MiB	801.8MiB	192.66MiB	202.62MiB
✅	static_quality_gate_agent_deb_arm64	783.36MiB	793.14MiB	174.82MiB	184.51MiB
✅	static_quality_gate_agent_rpm_amd64	792.14MiB	801.79MiB	195.11MiB	205.03MiB
✅	static_quality_gate_agent_rpm_arm64	783.38MiB	793.09MiB	176.49MiB	186.44MiB
✅	static_quality_gate_agent_suse_amd64	792.03MiB	801.81MiB	195.11MiB	205.03MiB
✅	static_quality_gate_agent_suse_arm64	783.34MiB	793.14MiB	176.49MiB	186.44MiB
✅	static_quality_gate_dogstatsd_deb_amd64	37.67MiB	47.67MiB	9.78MiB	19.78MiB
✅	static_quality_gate_dogstatsd_deb_arm64	36.28MiB	46.27MiB	8.48MiB	18.49MiB
✅	static_quality_gate_dogstatsd_rpm_amd64	37.67MiB	47.67MiB	9.79MiB	19.79MiB
✅	static_quality_gate_dogstatsd_suse_amd64	37.67MiB	47.67MiB	9.79MiB	19.79MiB
✅	static_quality_gate_iot_agent_deb_amd64	59.26MiB	69.0MiB	14.89MiB	24.8MiB
✅	static_quality_gate_iot_agent_deb_arm64	56.62MiB	66.4MiB	12.84MiB	22.8MiB
✅	static_quality_gate_iot_agent_rpm_amd64	59.26MiB	69.0MiB	14.91MiB	24.8MiB
✅	static_quality_gate_iot_agent_rpm_arm64	56.62MiB	66.4MiB	12.86MiB	22.8MiB
✅	static_quality_gate_iot_agent_suse_amd64	59.26MiB	69.0MiB	14.91MiB	24.8MiB
✅	static_quality_gate_docker_agent_amd64	876.46MiB	886.12MiB	294.31MiB	304.21MiB
✅	static_quality_gate_docker_agent_arm64	891.11MiB	900.79MiB	280.57MiB	290.47MiB
✅	static_quality_gate_docker_agent_jmx_amd64	1.05GiB	1.06GiB	369.43MiB	379.33MiB
✅	static_quality_gate_docker_agent_jmx_arm64	1.05GiB	1.06GiB	351.65MiB	361.55MiB
✅	static_quality_gate_docker_dogstatsd_amd64	45.82MiB	55.78MiB	17.28MiB	27.28MiB
✅	static_quality_gate_docker_dogstatsd_arm64	44.45MiB	54.45MiB	16.16MiB	26.16MiB
✅	static_quality_gate_docker_cluster_agent_amd64	264.96MiB	274.78MiB	106.36MiB	116.28MiB
✅	static_quality_gate_docker_cluster_agent_arm64	280.92MiB	290.82MiB	101.18MiB	111.12MiB

dustmop

LGTM for agent-configuration

docs/cloud-workload-security/linux_expressions.md

pkg/config/setup/system_probe.go

pkg/security/ebpf/c/include/constants/custom.h

pkg/security/ebpf/c/include/helpers/network/router.h

pkg/security/secl/model/model_unix.go

pkg/security/resolvers/dns/resolver.go

pkg/security/tests/dns_resolver_test.go

agent-platform-auto-pr · 2025-02-27T12:30:15Z

Static quality checks ❌

Please find below the results from static quality gates

Error

Result	Quality gate	On disk size	On disk size limit	On wire size	On wire size limit
❌	static_quality_gate_agent_suse_arm64	DataNotFound	793.14MiB	DataNotFound	186.44MiB

Gate failure full details

Quality gate	Error type	Error message
static_quality_gate_agent_suse_arm64	StackTrace	Traceback (most recent call last): File "/go/src/github.com/DataDog/datadog-agent/tasks/quality_gates.py", line 121, in parse_and_trigger_gates gate_mod.entrypoint(**gate_inputs) File "/go/src/github.com/DataDog/datadog-agent/tasks/static_quality_gates/static_quality_gate_agent_suse_arm64.py", line 5, in entrypoint generic_package_agent_quality_gate( File "/go/src/github.com/DataDog/datadog-agent/tasks/static_quality_gates/lib/package_agent_lib.py", line 69, in generic_package_agent_quality_gate package_on_wire_size, package_on_disk_size = calculate_package_size( ^^^^^^^^^^^^^^^^^^^^^^^ File "/go/src/github.com/DataDog/datadog-agent/tasks/static_quality_gates/lib/package_agent_lib.py", line 10, in calculate_package_size extract_package(ctx=ctx, package_os=package_os, package_path=package_path, extract_dir=extract_dir) File "/go/src/github.com/DataDog/datadog-agent/tasks/libs/package/size.py", line 72, in extract_package return extract_rpm_package(ctx, package_path, extract_dir) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/go/src/github.com/DataDog/datadog-agent/tasks/libs/package/size.py", line 65, in extract_rpm_package ctx.run(f"rpm2cpio {package_path}

Successful checks

Info

Result	Quality gate	On disk size	On disk size limit	On wire size	On wire size limit
✅	static_quality_gate_agent_deb_amd64	792.18MiB	801.8MiB	192.7MiB	202.62MiB
✅	static_quality_gate_agent_deb_arm64	783.54MiB	793.14MiB	174.82MiB	184.51MiB
✅	static_quality_gate_agent_rpm_amd64	792.18MiB	801.79MiB	195.12MiB	205.03MiB
✅	static_quality_gate_agent_rpm_arm64	783.55MiB	793.09MiB	176.49MiB	186.44MiB
✅	static_quality_gate_agent_suse_amd64	792.2MiB	801.81MiB	195.12MiB	205.03MiB
✅	static_quality_gate_dogstatsd_deb_amd64	37.67MiB	47.67MiB	9.78MiB	19.78MiB
✅	static_quality_gate_dogstatsd_deb_arm64	36.28MiB	46.27MiB	8.48MiB	18.49MiB
✅	static_quality_gate_dogstatsd_rpm_amd64	37.67MiB	47.67MiB	9.79MiB	19.79MiB
✅	static_quality_gate_dogstatsd_suse_amd64	37.67MiB	47.67MiB	9.79MiB	19.79MiB
✅	static_quality_gate_iot_agent_deb_amd64	59.26MiB	69.0MiB	14.89MiB	24.8MiB
✅	static_quality_gate_iot_agent_deb_arm64	56.62MiB	66.4MiB	12.83MiB	22.8MiB
✅	static_quality_gate_iot_agent_rpm_amd64	59.26MiB	69.0MiB	14.91MiB	24.8MiB
✅	static_quality_gate_iot_agent_rpm_arm64	56.62MiB	66.4MiB	12.86MiB	22.8MiB
✅	static_quality_gate_iot_agent_suse_amd64	59.26MiB	69.0MiB	14.91MiB	24.8MiB
✅	static_quality_gate_docker_agent_amd64	876.46MiB	886.12MiB	294.31MiB	304.21MiB
✅	static_quality_gate_docker_agent_arm64	891.11MiB	900.79MiB	280.57MiB	290.47MiB
✅	static_quality_gate_docker_agent_jmx_amd64	1.05GiB	1.06GiB	369.43MiB	379.33MiB
✅	static_quality_gate_docker_agent_jmx_arm64	1.05GiB	1.06GiB	351.64MiB	361.55MiB
✅	static_quality_gate_docker_dogstatsd_amd64	45.82MiB	55.78MiB	17.28MiB	27.28MiB
✅	static_quality_gate_docker_dogstatsd_arm64	44.45MiB	54.45MiB	16.16MiB	26.16MiB
✅	static_quality_gate_docker_cluster_agent_amd64	264.96MiB	274.78MiB	106.36MiB	116.28MiB
✅	static_quality_gate_docker_cluster_agent_arm64	280.92MiB	290.82MiB	101.18MiB	111.12MiB

spikat · 2025-02-27T14:08:26Z

pkg/config/setup/system_probe.go

-	eventMonitorBindEnvAndSetDefault(cfg, join(evNS, "network.ingress.enabled"), true)
+	eventMonitorBindEnvAndSetDefault(cfg, join(evNS, "network.ingress.enabled"), false)


now that the other PR is merge we should rebase this one :)

github-actions bot added component/system-probe long review PR is complex, plan time to review it team/agent-security labels Feb 11, 2025

kovagsm force-pushed the CWS-3904_Add_DNS_Context_to_Events branch from e7504a7 to 7549c4a Compare February 13, 2025 09:31

kovagsm force-pushed the CWS-3904_Add_DNS_Context_to_Events branch 11 times, most recently from bc0bb2f to cc5775a Compare February 21, 2025 10:02

kovagsm marked this pull request as ready for review February 21, 2025 10:38

kovagsm requested review from a team as code owners February 21, 2025 10:38

kovagsm requested a review from dustmop February 21, 2025 10:38

kovagsm added the changelog/no-changelog label Feb 21, 2025

kovagsm force-pushed the CWS-3904_Add_DNS_Context_to_Events branch 2 times, most recently from ae9bc6d to 1a5ce90 Compare February 21, 2025 13:15

kovagsm added the qa/done QA done before merge and regressions are covered by tests label Feb 21, 2025

kovagsm force-pushed the CWS-3904_Add_DNS_Context_to_Events branch from 1a5ce90 to b7963a9 Compare February 21, 2025 14:25

dustmop approved these changes Feb 21, 2025

View reviewed changes

kovagsm force-pushed the CWS-3904_Add_DNS_Context_to_Events branch from b7963a9 to 4a2d3f0 Compare February 21, 2025 15:47

hestonhoffman approved these changes Feb 21, 2025

View reviewed changes

spikat reviewed Feb 25, 2025

View reviewed changes

kovagsm force-pushed the CWS-3904_Add_DNS_Context_to_Events branch 5 times, most recently from 6f5381c to f5e9c9d Compare February 27, 2025 12:02

CWS-3904 Add DNS context to events

64f6779

kovagsm force-pushed the CWS-3904_Add_DNS_Context_to_Events branch from f5e9c9d to 64f6779 Compare February 27, 2025 13:45

spikat approved these changes Feb 27, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CWS-3904 - Add DNS Context to Events #33935

CWS-3904 - Add DNS Context to Events #33935

kovagsm commented Feb 11, 2025

cit-pr-commenter bot commented Feb 11, 2025 •

edited

Loading

cit-pr-commenter bot commented Feb 11, 2025 •

edited

Loading

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

agent-platform-auto-pr bot commented Feb 11, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 13, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 13, 2025 •

edited

Loading

Info

dustmop left a comment

agent-platform-auto-pr bot commented Feb 27, 2025

Info

spikat Feb 27, 2025

		eventMonitorBindEnvAndSetDefault(cfg, join(evNS, "network.ingress.enabled"), true)
		eventMonitorBindEnvAndSetDefault(cfg, join(evNS, "network.ingress.enabled"), false)

CWS-3904 - Add DNS Context to Events #33935

Are you sure you want to change the base?

CWS-3904 - Add DNS Context to Events #33935

Conversation

kovagsm commented Feb 11, 2025

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

cit-pr-commenter bot commented Feb 11, 2025 • edited Loading

Go Package Import Differences

cit-pr-commenter bot commented Feb 11, 2025 • edited Loading

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

agent-platform-auto-pr bot commented Feb 11, 2025 • edited Loading

Uncompressed package size comparison

Decision

agent-platform-auto-pr bot commented Feb 13, 2025 • edited Loading

Test changes on VM

agent-platform-auto-pr bot commented Feb 13, 2025 • edited Loading

Static quality checks ✅

Info

dustmop left a comment

Choose a reason for hiding this comment

agent-platform-auto-pr bot commented Feb 27, 2025

Static quality checks ❌

Error

Info

spikat Feb 27, 2025

Choose a reason for hiding this comment

cit-pr-commenter bot commented Feb 11, 2025 •

edited

Loading

cit-pr-commenter bot commented Feb 11, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 11, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 13, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 13, 2025 •

edited

Loading