-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CONTP-656] wmeta kubelet unknown envvar handling #34450
base: main
Are you sure you want to change the base?
Conversation
f8eef53
to
856f458
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small suggestions, approving to not block merge.
releasenotes/notes/kubelet-envvar-handling-55657ebfaa0702b8.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: May Lee <[email protected]>
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv aws.create-vm --pipeline-id=57143914 --os-family=ubuntu Note: This applies to commit bbe4a94 |
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision |
Static quality checks ✅Please find below the results from static quality gates Successful checksInfo
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: e1841bc Optimization Goals: ✅ No significant changes detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +1.24 | [+0.37, +2.11] | 1 | Logs |
➖ | quality_gate_logs | % cpu utilization | +0.62 | [-2.28, +3.51] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | +0.02 | [-0.60, +0.65] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | +0.02 | [-0.79, +0.83] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | +0.01 | [-0.77, +0.80] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.01 | [-0.01, +0.03] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | -0.00 | [-0.46, +0.46] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | -0.00 | [-0.81, +0.80] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.30, +0.27] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | -0.03 | [-0.71, +0.65] | 1 | Logs |
➖ | file_to_blackhole_500ms_latency | egress throughput | -0.13 | [-0.91, +0.64] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.17 | [-0.94, +0.61] | 1 | Logs |
➖ | quality_gate_idle_all_features | memory utilization | -0.26 | [-0.31, -0.22] | 1 | Logs bounds checks dashboard |
➖ | file_tree | memory utilization | -0.48 | [-0.54, -0.41] | 1 | Logs |
➖ | quality_gate_idle | memory utilization | -0.77 | [-0.81, -0.73] | 1 | Logs bounds checks dashboard |
➖ | tcp_syslog_to_blackhole | ingress throughput | -1.13 | [-1.19, -1.07] | 1 | Logs |
Bounds Checks: ✅ Passed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | intake_connections | 10/10 | |
✅ | quality_gate_logs | lost_bytes | 10/10 | |
✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
@@ -19,23 +19,23 @@ func syntaxWrap(input string) string { | |||
// implements the expansion semantics defined in the expansion spec; it | |||
// returns the input string wrapped in the expansion syntax if no mapping | |||
// for the input is found. | |||
func MappingFuncFor(context ...map[string]string) func(string) string { | |||
return func(input string) string { | |||
func MappingFuncFor(context ...map[string]string) func(string) (string, bool) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this file is in the third_party
directory, it was likely copy-pasted. It might be helpful to add a brief comment explaining any modifications to ensure we remember the changes.
What does this PR do?
Modifies pod parsing from Kubelet collector to discard environment variables that it can't resolve.
The Agent's Kubelet collector does not support environment variables that are externally sourced. This includes ConfigMap, Secrets, FieldRef, etc. If the customer has a runtime collector running, the value will be properly sourced and fully resolved from there instead.
Motivation
Customer support case where they used ConfigMap envvars to define another envvar. The Configmap envvars are unresolvable and were creating issues since they expanded in a poor manner and was overwriting the correct value from the runtime collector. By ignoring the value the kubelet collector can't resolve, the runtime collector (docker/containerd) will have the full value and place it into wmeta/tagger correctly.
Describe how you validated your changes
Unit tests should cover all these cases. Additional tests were also written. Plus a quick manual QA with the following spec
Possible Drawbacks / Trade-offs
We will need to iterate through every environment variable in every container in order to know which ones need to be dropped. The collector cache is frequently invalidated and thus this will execute often. However, there are many other operations that also execute at this frequency/level.
Additional Notes