Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle nil as the zero value for node values #34454

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

dustmop
Copy link
Contributor

@dustmop dustmop commented Feb 25, 2025

What does this PR do?

Handle nil values in the config yaml by converting them to zero values for each type

Motivation

Prevents a segfault in the config parser

Describe how you validated your changes

Behavior change covered by unit tests

Possible Drawbacks / Trade-offs

Additional Notes

@dustmop dustmop requested a review from a team as a code owner February 25, 2025 22:47
@dustmop dustmop requested a review from hush-hush February 25, 2025 22:47
@dustmop dustmop added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests team/agent-configuration labels Feb 25, 2025
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Feb 25, 2025
@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=56965418 --os-family=ubuntu

Note: This applies to commit 7f7068b

@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor affd2a9911516e4e5c0ee6d65487108241bfa02e

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 817.95MB 817.95MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB 827.74MB 827.74MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 827.74MB 827.74MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 443.36MB 443.35MB 0.50MB
datadog-agent-arm64-deb 0.00MB 808.92MB 808.92MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 818.70MB 818.70MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 39.42MB 39.42MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 39.50MB 39.50MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 39.50MB 39.50MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 37.96MB 37.96MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 62.03MB 62.03MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 62.10MB 62.10MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 62.10MB 62.10MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 59.27MB 59.27MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 59.34MB 59.34MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 791.89MiB 801.8MiB 192.62MiB 202.62MiB
static_quality_gate_agent_deb_arm64 783.13MiB 793.14MiB 174.56MiB 184.51MiB
static_quality_gate_agent_rpm_amd64 791.75MiB 801.79MiB 195.06MiB 205.03MiB
static_quality_gate_agent_rpm_arm64 783.24MiB 793.09MiB 176.41MiB 186.44MiB
static_quality_gate_agent_suse_amd64 791.72MiB 801.81MiB 195.06MiB 205.03MiB
static_quality_gate_agent_suse_arm64 783.22MiB 793.14MiB 176.41MiB 186.44MiB
static_quality_gate_dogstatsd_deb_amd64 37.67MiB 47.67MiB 9.78MiB 19.78MiB
static_quality_gate_dogstatsd_deb_arm64 36.27MiB 46.27MiB 8.49MiB 18.49MiB
static_quality_gate_dogstatsd_rpm_amd64 37.67MiB 47.67MiB 9.79MiB 19.79MiB
static_quality_gate_dogstatsd_suse_amd64 37.67MiB 47.67MiB 9.79MiB 19.79MiB
static_quality_gate_iot_agent_deb_amd64 59.23MiB 69.0MiB 14.89MiB 24.8MiB
static_quality_gate_iot_agent_deb_arm64 56.6MiB 66.4MiB 12.85MiB 22.8MiB
static_quality_gate_iot_agent_rpm_amd64 59.23MiB 69.0MiB 14.9MiB 24.8MiB
static_quality_gate_iot_agent_rpm_arm64 56.6MiB 66.4MiB 12.85MiB 22.8MiB
static_quality_gate_iot_agent_suse_amd64 59.23MiB 69.0MiB 14.9MiB 24.8MiB
static_quality_gate_docker_agent_amd64 876.2MiB 886.12MiB 294.23MiB 304.21MiB
static_quality_gate_docker_agent_arm64 890.86MiB 900.79MiB 280.49MiB 290.47MiB
static_quality_gate_docker_agent_jmx_amd64 1.05GiB 1.06GiB 369.35MiB 379.33MiB
static_quality_gate_docker_agent_jmx_arm64 1.05GiB 1.06GiB 351.6MiB 361.55MiB
static_quality_gate_docker_dogstatsd_amd64 45.81MiB 55.78MiB 17.28MiB 27.28MiB
static_quality_gate_docker_dogstatsd_arm64 44.46MiB 54.45MiB 16.16MiB 26.16MiB
static_quality_gate_docker_cluster_agent_amd64 264.95MiB 274.78MiB 106.34MiB 116.28MiB
static_quality_gate_docker_cluster_agent_arm64 280.93MiB 290.82MiB 101.19MiB 111.12MiB

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: fdca376f-ce06-472c-a139-9c7989c8a9e3

Baseline: affd2a9
Comparison: 7f7068b
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
tcp_syslog_to_blackhole ingress throughput +1.85 [+1.79, +1.91] 1 Logs
quality_gate_idle_all_features memory utilization +0.40 [+0.35, +0.45] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.11 [-0.36, +0.58] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.11 [-0.67, +0.89] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.02 [-0.80, +0.85] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.01 [-0.84, +0.86] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.01 [-0.62, +0.64] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.02, +0.03] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.29, +0.29] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.00 [-0.81, +0.81] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.01 [-0.65, +0.63] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.05 [-0.82, +0.73] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.06 [-0.95, +0.82] 1 Logs
quality_gate_idle memory utilization -0.41 [-0.46, -0.36] 1 Logs bounds checks dashboard
file_tree memory utilization -0.47 [-0.52, -0.42] 1 Logs
quality_gate_logs % cpu utilization -0.52 [-3.41, +2.38] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@hush-hush
Copy link
Member

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 26, 2025

View all feedbacks in Devflow UI.
2025-02-26 11:05:46 UTC ℹ️ Start processing command /merge


2025-02-26 11:05:49 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 29m.


2025-02-26 12:00:20 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit c8bfbef into main Feb 26, 2025
265 checks passed
@dd-mergequeue dd-mergequeue bot deleted the dustin.long/nil-zero-value branch February 26, 2025 12:00
@github-actions github-actions bot added this to the 7.65.0 milestone Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/agent-configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants