Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CWS] sysctl event #34482

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[CWS] sysctl event #34482

wants to merge 1 commit into from

Conversation

Gui774ume
Copy link
Contributor

@Gui774ume Gui774ume commented Feb 26, 2025

What does this PR do?

This PR introduces the sysctl event type by leveraging BPF_PROG_TYPE_CGROUP_SYSCTL programs. New rules can be written on the sysctl event type, so that you can capture changes to kernel configuration parameters.

For example: sysctl.action == SYSCTL_WRITE && sysctl.name == "kernel.yama.ptrace_scope" && sysctl.new_value="0" monitors when changes are made to the Yama LSM configuration, and more specifically when its restrictions on the ptrace scope is disabled.

Motivation

This new event type provides visibility into changes in some kernel configurations that are relevant for security use cases.

Describe how you validated your changes

Run the CI test 🎉

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 26, 2025

Uncompressed package size comparison

Comparison with ancestor 7c2c93d3cb7406f36d91c1ff9e2baebafe6e50c5

Diff per package
package diff status size ancestor threshold
datadog-agent-arm64-deb 0.20MB ⚠️ 809.04MB 808.85MB 0.50MB
datadog-agent-aarch64-rpm 0.20MB ⚠️ 818.82MB 818.62MB 0.50MB
datadog-agent-x86_64-rpm 0.19MB ⚠️ 827.85MB 827.66MB 0.50MB
datadog-agent-x86_64-suse 0.19MB ⚠️ 827.85MB 827.66MB 0.50MB
datadog-agent-amd64-deb 0.19MB ⚠️ 818.06MB 817.87MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 39.42MB 39.42MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 39.50MB 39.50MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 39.50MB 39.50MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 37.96MB 37.96MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 443.28MB 443.28MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 62.02MB 62.02MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 62.09MB 62.09MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 62.09MB 62.09MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 59.27MB 59.27MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 59.33MB 59.33MB 0.50MB

Decision

⚠️ Warning

Copy link

cit-pr-commenter bot commented Feb 26, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 61322b61-09ac-44a5-a36b-0e61e43d065a

Baseline: 7c2c93d
Comparison: d0a96bd
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +1.60 [+0.72, +2.48] 1 Logs
quality_gate_logs % cpu utilization +0.94 [-1.96, +3.84] 1 Logs
file_tree memory utilization +0.28 [+0.22, +0.34] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.09 [-0.37, +0.56] 1 Logs
quality_gate_idle_all_features memory utilization +0.09 [+0.02, +0.15] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency egress throughput +0.02 [-0.81, +0.85] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.02 [-0.77, +0.81] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.02 [-0.28, +0.31] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.02, +0.03] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.00 [-0.76, +0.76] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.00 [-0.07, +0.07] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.00 [-0.66, +0.66] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.00 [-0.63, +0.62] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.07 [-0.85, +0.71] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.17 [-0.94, +0.60] 1 Logs
quality_gate_idle memory utilization -0.52 [-0.55, -0.48] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@Gui774ume Gui774ume added the qa/done QA done before merge and regressions are covered by tests label Feb 27, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 27, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=57199640 --os-family=ubuntu

Note: This applies to commit b294cce

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 27, 2025

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 791.99MiB 817.79MiB 192.67MiB 204.92MiB
static_quality_gate_agent_deb_arm64 783.25MiB 808.76MiB 174.59MiB 186.5MiB
static_quality_gate_agent_rpm_amd64 791.84MiB 817.82MiB 195.0MiB 208.12MiB
static_quality_gate_agent_rpm_arm64 783.25MiB 808.76MiB 176.43MiB 188.34MiB
static_quality_gate_agent_suse_amd64 791.87MiB 817.82MiB 195.0MiB 208.12MiB
static_quality_gate_agent_suse_arm64 783.25MiB 808.86MiB 176.43MiB 188.33MiB
static_quality_gate_dogstatsd_deb_amd64 37.67MiB 47.7MiB 9.78MiB 19.8MiB
static_quality_gate_dogstatsd_deb_arm64 36.27MiB 46.3MiB 8.49MiB 18.5MiB
static_quality_gate_dogstatsd_rpm_amd64 37.67MiB 47.7MiB 9.79MiB 19.8MiB
static_quality_gate_dogstatsd_suse_amd64 37.67MiB 47.7MiB 9.79MiB 19.8MiB
static_quality_gate_iot_agent_deb_amd64 59.23MiB 69.0MiB 14.89MiB 24.8MiB
static_quality_gate_iot_agent_deb_arm64 56.59MiB 66.4MiB 12.85MiB 22.8MiB
static_quality_gate_iot_agent_rpm_amd64 59.23MiB 69.0MiB 14.9MiB 24.8MiB
static_quality_gate_iot_agent_rpm_arm64 56.6MiB 66.4MiB 12.85MiB 22.8MiB
static_quality_gate_iot_agent_suse_amd64 59.23MiB 69.0MiB 14.9MiB 24.8MiB
static_quality_gate_docker_agent_amd64 876.31MiB 902.2MiB 294.25MiB 308.43MiB
static_quality_gate_docker_agent_arm64 890.97MiB 916.47MiB 280.52MiB 294.23MiB
static_quality_gate_docker_agent_jmx_amd64 1.05GiB 1.07GiB 369.36MiB 383.54MiB
static_quality_gate_docker_agent_jmx_arm64 1.05GiB 1.08GiB 351.58MiB 365.31MiB
static_quality_gate_docker_dogstatsd_amd64 45.81MiB 55.78MiB 17.28MiB 27.29MiB
static_quality_gate_docker_dogstatsd_arm64 44.45MiB 54.47MiB 16.16MiB 26.16MiB
static_quality_gate_docker_cluster_agent_amd64 264.95MiB 274.78MiB 106.36MiB 116.28MiB
static_quality_gate_docker_cluster_agent_arm64 280.92MiB 290.82MiB 101.18MiB 111.12MiB

@Gui774ume Gui774ume force-pushed the will/sysctl-event branch 3 times, most recently from dd180d7 to d0a96bd Compare February 27, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/agent-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant