Combine rss shrinker and base check lazy imports #34483
Closed
+147
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go Package Import DifferencesBaseline: 407d013
|
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv aws.create-vm --pipeline-id=57080008 --os-family=ubuntuNote: This applies to commit 6ddccf2 |
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision |
:seesomethingsaysomething: Your PR is a tiny bit behind, is that expected? |
hush-hush
reviewed
Feb 27, 2025
| @@ -0,0 +1,109 @@ | |||
| // Unless explicitly stated otherwise all files in this repository are licensed | |||
There was a problem hiding this comment.
Could we update the CODEOWNERS list so the right team own this.
There was a problem hiding this comment.
@hush-hush I realized too late that this PR is based on some old changes. if the codeowners is still out of date in main, you may be in a better position to update it than me. I don't know who the new owner is supposed to be ;)
|
Closing to avoid confusion, will open a new one based on more recent main state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I set this to draft too late, sorry about reviewer pings!
Motivation
Describe how you validated your changes
Possible Drawbacks / Trade-offs
Additional Notes