-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
omnibus: add a systemd recipe #21468
Conversation
And point cgo to our dependencies include dir
This will allow us to drop the systemd-dev or equivalent package from the build images. Co-authored-by: David du Colombier <[email protected]>
Bloop Bleep... Dogbot HereRegression Detector ResultsRun ID: 302c879d-e755-4f75-bd15-2b4d48fab6fb Performance changes are noted in the perf column of each table:
|
perf | experiment | goal | Δ mean % | Δ mean % CI | confidence |
---|---|---|---|---|---|
❌ | otel_to_otel_logs | ingress throughput | -1.39 | [-2.11, -0.67] | 99.85% |
Experiments with missing or malformed data
- idle
Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.
Fine details of change detection per experiment
perf | experiment | goal | Δ mean % | Δ mean % CI | confidence |
---|---|---|---|---|---|
✅ | tcp_syslog_to_blackhole | ingress throughput | +0.12 | [+0.06, +0.18] | 99.89% |
❌ | trace_agent_msgpack | ingress throughput | +0.00 | [-0.00, +0.00] | 0.00% |
❌ | dogstatsd_string_interner_64MiB_1k | ingress throughput | +0.00 | [-0.00, +0.00] | 0.00% |
❌ | dogstatsd_string_interner_8MiB_50k | ingress throughput | +0.00 | [-0.00, +0.00] | 0.00% |
❌ | dogstatsd_string_interner_8MiB_1k | ingress throughput | +0.00 | [-0.00, +0.00] | 0.00% |
❌ | dogstatsd_string_interner_64MiB_100 | ingress throughput | +0.00 | [-0.00, +0.00] | 0.00% |
❌ | dogstatsd_string_interner_128MiB_1k | ingress throughput | +0.00 | [-0.00, +0.00] | 0.00% |
❌ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.00, +0.00] | 0.00% |
❌ | dogstatsd_string_interner_128MiB_100 | ingress throughput | +0.00 | [-0.00, +0.00] | 0.00% |
❌ | dogstatsd_string_interner_8MiB_100 | ingress throughput | +0.00 | [-0.00, +0.00] | 0.00% |
❌ | dogstatsd_string_interner_8MiB_10k | ingress throughput | +0.00 | [-0.00, +0.00] | 0.00% |
❌ | trace_agent_json | ingress throughput | +0.00 | [-0.01, +0.01] | 0.00% |
❌ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] | 0.00% |
❌ | dogstatsd_string_interner_8MiB_100k | ingress throughput | -0.00 | [-0.03, +0.03] | 0.00% |
❌ | file_tree | egress throughput | -0.30 | [-2.10, +1.49] | 21.78% |
❌ | otel_to_otel_logs | ingress throughput | -1.39 | [-2.11, -0.67] | 99.85% |
❌ | file_to_blackhole | egress throughput | -5.25 | [-11.25, +0.74] | 85.04% |
What does this PR do?
This PR removes systemd-dev or equivalent packages from our build images.
Motivation
We need our dependencies to be available to the build system. They shouldn't be installed in
/usr/include
as this folder might be ignored when using a custom toolchain, cross compiling, [...]Should we need different versions of the headers on different platform, it's easier to adjust the version in the omnibus recipe rather than having to rebuild the build images
Additional Notes
Linked PR in buildimages repo: DataDog/datadog-agent-buildimages#493
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
systemd headers are required by
go-systemd
which in turn is used by thejournald
integration.If the agent is able to fetch logs from journald, then everything is fine.
Reviewer's Checklist
Triage
milestone is set.major_change
label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changelog
label has been applied.qa/skip-qa
label is not applied.team/..
label has been applied, indicating the team(s) that should QA this change.need-change/operator
andneed-change/helm
labels have been applied.k8s/<min-version>
label, indicating the lowest Kubernetes version compatible with this feature.