[CWS] Run TestAgentSuite on GCP #30516

lebauce · 2024-10-25T13:49:16Z

What does this PR do?

Run the TestAgentSuite test on GCP (in addition to AWS)

Motivation

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

agent-platform-auto-pr · 2024-10-25T14:11:03Z

[Fast Unit Tests Report]

On pipeline 56859358 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

tests_deb-arm64-py3
tests_deb-x64-py3
tests_flavor_dogstatsd_deb-x64
tests_flavor_heroku_deb-x64
tests_flavor_iot_deb-x64
tests_rpm-arm64-py3
tests_rpm-x64-py3
tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

agent-platform-auto-pr · 2024-10-25T14:17:47Z

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=56859358 --os-family=ubuntu

Note: This applies to commit 3e3bc45

cit-pr-commenter · 2024-10-25T15:29:57Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 47085e5e-3046-421f-b596-b75b5fff7af8

Baseline: 7549bc4
Comparison: 3e3bc45
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+1.78	[+0.88, +2.68]	1	Logs
➖	quality_gate_idle	memory utilization	+1.05	[+1.01, +1.08]	1	Logs bounds checks dashboard
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.29	[-0.49, +1.07]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.22	[-0.25, +0.69]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.11	[-0.68, +0.89]	1	Logs
➖	quality_gate_logs	% cpu utilization	+0.09	[-2.82, +3.00]	1	Logs
➖	file_tree	memory utilization	+0.08	[+0.02, +0.15]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.03	[-0.02, +0.09]	1	Logs bounds checks dashboard
➖	file_to_blackhole_0ms_latency	egress throughput	+0.00	[-0.68, +0.69]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.01, +0.01]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.00	[-0.70, +0.70]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.30, +0.29]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	-0.01	[-0.77, +0.75]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.01	[-0.64, +0.62]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	-0.01	[-0.86, +0.83]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.12	[-0.18, -0.05]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

KevinFairise2 · 2024-10-29T14:12:01Z

test/new-e2e/tests/cws/gcp_test.go

+		e2e.WithProvisioner(
+			gcphost.ProvisionerNoFakeIntake(
+				gcphost.WithAgentOptions(
+					agentparams.WithAgentConfig(agentConfig),
+					agentparams.WithSecurityAgentConfig(securityAgentConfig),
+					agentparams.WithSystemProbeConfig(systemProbeConfig),
+				),
+			),
+		),
+	)


Suggested change

e2e.WithProvisioner(

gcphost.ProvisionerNoFakeIntake(

gcphost.WithAgentOptions(

agentparams.WithAgentConfig(agentConfig),

agentparams.WithSecurityAgentConfig(securityAgentConfig),

agentparams.WithSystemProbeConfig(systemProbeConfig),

),

),

),

)

e2e.WithStackName(fmt.Sprintf("cws-agentSuite-gcp")),

e2e.WithProvisioner(

gcphost.ProvisionerNoFakeIntake(

gcphost.WithAgentOptions(

agentparams.WithAgentConfig(agentConfig),

agentparams.WithSecurityAgentConfig(securityAgentConfig),

agentparams.WithSystemProbeConfig(systemProbeConfig),

),

),

),

)

agent-platform-auto-pr · 2025-02-24T18:02:45Z

Uncompressed package size comparison

Comparison with ancestor 7549bc4907446bf5117ad8450806cde4204e4e1e

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-amd64-deb	0.00MB	✅	841.12MB	841.12MB	0.50MB
datadog-agent-x86_64-rpm	0.00MB	✅	850.91MB	850.91MB	0.50MB
datadog-agent-x86_64-suse	0.00MB	✅	850.91MB	850.91MB	0.50MB
datadog-agent-arm64-deb	0.00MB	✅	831.16MB	831.16MB	0.50MB
datadog-agent-aarch64-rpm	0.00MB	✅	840.94MB	840.94MB	0.50MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	39.42MB	39.42MB	0.50MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	39.50MB	39.50MB	0.50MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	39.50MB	39.50MB	0.50MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	37.96MB	37.96MB	0.50MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	443.27MB	443.27MB	0.50MB
datadog-iot-agent-amd64-deb	0.00MB	✅	62.02MB	62.02MB	0.50MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	62.09MB	62.09MB	0.50MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	62.09MB	62.09MB	0.50MB
datadog-iot-agent-arm64-deb	0.00MB	✅	59.26MB	59.26MB	0.50MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	59.33MB	59.33MB	0.50MB

Decision

✅ Passed

agent-platform-auto-pr · 2025-02-24T18:08:24Z

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result	Quality gate	On disk size	On disk size limit	On wire size	On wire size limit
✅	static_quality_gate_agent_deb_amd64	813.82MiB	841.59MiB	197.25MiB	210.72MiB
✅	static_quality_gate_agent_deb_arm64	804.42MiB	830.66MiB	178.83MiB	192.1MiB
✅	static_quality_gate_agent_rpm_amd64	813.88MiB	841.52MiB	199.67MiB	214.52MiB
✅	static_quality_gate_agent_rpm_arm64	804.42MiB	830.66MiB	180.94MiB	193.64MiB
✅	static_quality_gate_agent_suse_amd64	813.95MiB	841.52MiB	199.67MiB	214.52MiB
✅	static_quality_gate_agent_suse_arm64	804.43MiB	830.66MiB	180.94MiB	194.03MiB
✅	static_quality_gate_dogstatsd_deb_amd64	37.67MiB	49.7MiB	9.78MiB	20.6MiB
✅	static_quality_gate_dogstatsd_deb_arm64	36.27MiB	48.1MiB	8.48MiB	19.1MiB
✅	static_quality_gate_dogstatsd_rpm_amd64	37.67MiB	49.7MiB	9.79MiB	20.6MiB
✅	static_quality_gate_dogstatsd_suse_amd64	37.67MiB	49.7MiB	9.79MiB	20.6MiB
✅	static_quality_gate_iot_agent_deb_amd64	59.23MiB	69.0MiB	14.89MiB	24.8MiB
✅	static_quality_gate_iot_agent_deb_arm64	56.59MiB	66.4MiB	12.84MiB	22.8MiB
✅	static_quality_gate_iot_agent_rpm_amd64	59.23MiB	69.0MiB	14.9MiB	24.8MiB
✅	static_quality_gate_iot_agent_rpm_arm64	56.59MiB	66.4MiB	12.85MiB	22.8MiB
✅	static_quality_gate_iot_agent_suse_amd64	59.23MiB	69.0MiB	14.9MiB	24.8MiB
✅	static_quality_gate_docker_agent_amd64	898.3MiB	926.0MiB	301.28MiB	317.43MiB
✅	static_quality_gate_docker_agent_arm64	912.07MiB	939.07MiB	286.74MiB	302.43MiB
✅	static_quality_gate_docker_agent_jmx_amd64	1.07GiB	1.1GiB	376.38MiB	392.54MiB
✅	static_quality_gate_docker_agent_jmx_arm64	1.07GiB	1.1GiB	357.84MiB	373.21MiB
✅	static_quality_gate_docker_dogstatsd_amd64	45.81MiB	57.88MiB	17.28MiB	28.29MiB
✅	static_quality_gate_docker_dogstatsd_arm64	44.45MiB	56.27MiB	16.16MiB	27.06MiB
✅	static_quality_gate_docker_cluster_agent_amd64	264.94MiB	274.78MiB	106.34MiB	116.28MiB
✅	static_quality_gate_docker_cluster_agent_arm64	280.92MiB	290.82MiB	101.19MiB	111.12MiB

lebauce · 2025-02-25T11:11:07Z

/merge

dd-devflow · 2025-02-25T11:11:13Z

View all feedbacks in Devflow UI.
2025-02-25 11:11:13 UTC ℹ️ Start processing command /merge

2025-02-25 11:11:19 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-02-25 11:41:09 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 28m.

2025-02-25 12:06:17 UTC ℹ️ MergeQueue: This merge request was merged

lebauce added changelog/no-changelog team/agent-security qa/no-code-change No code change in Agent code requiring validation labels Oct 25, 2024

lebauce added this to the Triage milestone Oct 25, 2024

KevinFairise2 reviewed Oct 29, 2024

View reviewed changes

github-actions bot added the long review PR is complex, plan time to review it label Oct 29, 2024

lebauce force-pushed the lebauce/gce-cws-e2e branch from 806282e to 6d7b095 Compare November 4, 2024 15:39

lebauce force-pushed the lebauce/gce-cws-e2e branch from 6d7b095 to 7f7d626 Compare February 18, 2025 17:07

github-actions bot added medium review PR review might take time and removed long review PR is complex, plan time to review it labels Feb 18, 2025

lebauce force-pushed the lebauce/gce-cws-e2e branch from 7f7d626 to 3ca731d Compare February 24, 2025 17:35

lebauce marked this pull request as ready for review February 24, 2025 17:42

lebauce requested a review from a team as a code owner February 24, 2025 17:42

lebauce requested a review from KevinFairise2 February 24, 2025 17:42

lebauce and others added 2 commits February 25, 2025 11:51

Run TestAgentSuite on GCP

8d1805c

Set stack name for TestAgentSuiteGCP and TestAgentSuiteEC2

3e3bc45

lebauce force-pushed the lebauce/gce-cws-e2e branch from 3ca731d to 3e3bc45 Compare February 25, 2025 10:51

spikat approved these changes Feb 25, 2025

View reviewed changes

dd-mergequeue bot merged commit 61215d5 into main Feb 25, 2025
220 of 221 checks passed

dd-mergequeue bot deleted the lebauce/gce-cws-e2e branch February 25, 2025 12:06

github-actions bot modified the milestones: Triage, 7.65.0 Feb 25, 2025

wdhif pushed a commit that referenced this pull request Feb 25, 2025

[CWS] Run TestAgentSuite on GCP (#30516)

d60bd1e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CWS] Run TestAgentSuite on GCP #30516

[CWS] Run TestAgentSuite on GCP #30516

lebauce commented Oct 25, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Oct 25, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Oct 25, 2024 •

edited

Loading

cit-pr-commenter bot commented Oct 25, 2024 •

edited

Loading

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

KevinFairise2 Oct 29, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Feb 24, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 24, 2025 •

edited

Loading

Info

lebauce commented Feb 25, 2025

dd-devflow bot commented Feb 25, 2025 •

edited

Loading

[CWS] Run TestAgentSuite on GCP #30516

[CWS] Run TestAgentSuite on GCP #30516

Conversation

lebauce commented Oct 25, 2024 • edited Loading

What does this PR do?

Motivation

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

agent-platform-auto-pr bot commented Oct 25, 2024 • edited Loading

agent-platform-auto-pr bot commented Oct 25, 2024 • edited Loading

Test changes on VM

cit-pr-commenter bot commented Oct 25, 2024 • edited Loading

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

KevinFairise2 Oct 29, 2024 • edited Loading

Choose a reason for hiding this comment

agent-platform-auto-pr bot commented Feb 24, 2025 • edited Loading

Uncompressed package size comparison

Decision

agent-platform-auto-pr bot commented Feb 24, 2025 • edited Loading

Static quality checks ✅

Info

lebauce commented Feb 25, 2025

dd-devflow bot commented Feb 25, 2025 • edited Loading

lebauce commented Oct 25, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Oct 25, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Oct 25, 2024 •

edited

Loading

cit-pr-commenter bot commented Oct 25, 2024 •

edited

Loading

KevinFairise2 Oct 29, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Feb 24, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 24, 2025 •

edited

Loading

dd-devflow bot commented Feb 25, 2025 •

edited

Loading