Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add new otel-agent standalone image #34092

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Conversation

AliDatadog
Copy link
Contributor

@AliDatadog AliDatadog commented Feb 17, 2025

What does this PR do?

This PR introduces an otel-agent standalone image and new jobs to:

  • Deploy it to otel-agent-dev
  • Deploy it internally

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Feb 17, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 17, 2025

[Fast Unit Tests Report]

On pipeline 57196639 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 17, 2025

Gitlab CI Configuration Changes

Updated: .gitlab-ci.yml

⚠️ Diff too large to display on Github.

Changes Summary

Removed Modified Added Renamed
0 87 5 0

Updated: .gitlab/deploy_containers/deploy_containers_a7.yml

⚠️ Diff too large to display on Github.

Changes Summary

Removed Modified Added Renamed
0 28 0 0

ℹ️ Diff available in the job log.

@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Feb 17, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 17, 2025

Uncompressed package size comparison

Comparison with ancestor 4034dc7c53e4197038874010d3e49839cb605093

Diff per package
package diff status size ancestor threshold
datadog-agent-x86_64-rpm 0.04MB ⚠️ 869.40MB 869.36MB 0.50MB
datadog-agent-x86_64-suse 0.04MB ⚠️ 869.40MB 869.36MB 0.50MB
datadog-agent-aarch64-rpm 0.03MB ⚠️ 858.68MB 858.65MB 0.50MB
datadog-agent-amd64-deb 0.02MB ⚠️ 859.60MB 859.59MB 0.50MB
datadog-agent-arm64-deb 0.01MB ⚠️ 848.91MB 848.90MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 41.40MB 41.40MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 41.48MB 41.48MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 41.48MB 41.48MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 39.66MB 39.66MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 443.43MB 443.43MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 62.03MB 62.03MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 62.10MB 62.10MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 62.10MB 62.10MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 59.27MB 59.27MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 59.34MB 59.34MB 0.50MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 17, 2025

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 831.6MiB 847.49MiB 201.79MiB 212.33MiB
static_quality_gate_agent_deb_arm64 821.38MiB 836.66MiB 182.08MiB 192.5MiB
static_quality_gate_agent_rpm_amd64 831.49MiB 847.82MiB 204.55MiB 215.76MiB
static_quality_gate_agent_rpm_arm64 821.36MiB 836.66MiB 184.08MiB 194.24MiB
static_quality_gate_agent_suse_amd64 831.6MiB 847.82MiB 204.55MiB 215.76MiB
static_quality_gate_agent_suse_arm64 821.34MiB 836.66MiB 184.08MiB 194.24MiB
static_quality_gate_dogstatsd_deb_amd64 39.56MiB 49.7MiB 10.55MiB 20.6MiB
static_quality_gate_dogstatsd_deb_arm64 37.9MiB 48.1MiB 9.13MiB 19.1MiB
static_quality_gate_dogstatsd_rpm_amd64 39.56MiB 49.7MiB 10.56MiB 20.6MiB
static_quality_gate_dogstatsd_suse_amd64 39.56MiB 49.7MiB 10.56MiB 20.6MiB
static_quality_gate_iot_agent_deb_amd64 59.23MiB 69.0MiB 14.88MiB 24.8MiB
static_quality_gate_iot_agent_deb_arm64 56.6MiB 66.4MiB 12.83MiB 22.8MiB
static_quality_gate_iot_agent_rpm_amd64 59.23MiB 69.0MiB 14.9MiB 24.8MiB
static_quality_gate_iot_agent_rpm_arm64 56.6MiB 66.4MiB 12.85MiB 22.8MiB
static_quality_gate_iot_agent_suse_amd64 59.23MiB 69.0MiB 14.9MiB 24.8MiB
static_quality_gate_docker_agent_amd64 915.93MiB 931.7MiB 307.45MiB 318.67MiB
static_quality_gate_docker_agent_arm64 928.99MiB 944.08MiB 292.43MiB 303.0MiB
static_quality_gate_docker_agent_jmx_amd64 1.09GiB 1.1GiB 382.56MiB 393.75MiB
static_quality_gate_docker_agent_jmx_arm64 1.09GiB 1.1GiB 363.53MiB 373.71MiB
static_quality_gate_docker_dogstatsd_amd64 47.7MiB 57.88MiB 18.26MiB 28.29MiB
static_quality_gate_docker_dogstatsd_arm64 46.09MiB 56.27MiB 17.02MiB 27.06MiB
static_quality_gate_docker_cluster_agent_amd64 264.95MiB 274.78MiB 106.33MiB 116.28MiB
static_quality_gate_docker_cluster_agent_arm64 280.91MiB 290.82MiB 101.19MiB 111.12MiB

Copy link

cit-pr-commenter bot commented Feb 17, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 9dc1af71-8f30-4d4f-b047-28d851e40abd

Baseline: 4034dc7
Comparison: b222a58
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +2.21 [+1.28, +3.14] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.62 [+0.56, +0.67] 1 Logs
quality_gate_idle_all_features memory utilization +0.21 [+0.16, +0.26] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization +0.17 [-2.86, +3.20] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.17 [-0.61, +0.95] 1 Logs
file_tree memory utilization +0.10 [+0.03, +0.16] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.04 [-0.74, +0.82] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.02 [-0.28, +0.32] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.02 [-0.82, +0.86] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.01, +0.03] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.00 [-0.63, +0.64] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.01 [-0.65, +0.63] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.02 [-0.87, +0.83] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.02 [-0.84, +0.79] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.15 [-0.62, +0.32] 1 Logs
quality_gate_idle memory utilization -0.21 [-0.26, -0.17] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@AliDatadog AliDatadog added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests labels Feb 17, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 19, 2025

Static quality checks ❌

Please find below the results from static quality gates

Error

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_suse_amd64 DataNotFound 847.82MiB DataNotFound 215.76MiB
Gate failure full details
Quality gate Error type Error message
static_quality_gate_agent_suse_amd64 StackTrace Traceback (most recent call last):
File "/go/src/github.com/DataDog/datadog-agent/tasks/quality_gates.py", line 121, in parse_and_trigger_gates
gate_mod.entrypoint(**gate_inputs)
File "/go/src/github.com/DataDog/datadog-agent/tasks/static_quality_gates/static_quality_gate_agent_suse_amd64.py", line 5, in entrypoint
generic_package_agent_quality_gate(
File "/go/src/github.com/DataDog/datadog-agent/tasks/static_quality_gates/lib/package_agent_lib.py", line 69, in generic_package_agent_quality_gate
package_on_wire_size, package_on_disk_size = calculate_package_size(
^^^^^^^^^^^^^^^^^^^^^^^
File "/go/src/github.com/DataDog/datadog-agent/tasks/static_quality_gates/lib/package_agent_lib.py", line 10, in calculate_package_size
extract_package(ctx=ctx, package_os=package_os, package_path=package_path, extract_dir=extract_dir)
File "/go/src/github.com/DataDog/datadog-agent/tasks/libs/package/size.py", line 72, in extract_package
return extract_rpm_package(ctx, package_path, extract_dir)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/go/src/github.com/DataDog/datadog-agent/tasks/libs/package/size.py", line 65, in extract_rpm_package
ctx.run(f"rpm2cpio {package_path}
Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 831.08MiB 847.49MiB 201.79MiB 212.33MiB
static_quality_gate_agent_deb_arm64 820.85MiB 836.66MiB 182.78MiB 192.5MiB
static_quality_gate_agent_rpm_amd64 831.07MiB 847.82MiB 204.6MiB 215.76MiB
static_quality_gate_agent_rpm_arm64 820.84MiB 836.66MiB 184.06MiB 194.24MiB
static_quality_gate_agent_suse_arm64 820.84MiB 836.66MiB 184.06MiB 194.24MiB
static_quality_gate_dogstatsd_deb_amd64 39.56MiB 49.7MiB 10.55MiB 20.6MiB
static_quality_gate_dogstatsd_deb_arm64 37.9MiB 48.1MiB 9.13MiB 19.1MiB
static_quality_gate_dogstatsd_rpm_amd64 39.56MiB 49.7MiB 10.56MiB 20.6MiB
static_quality_gate_dogstatsd_suse_amd64 39.56MiB 49.7MiB 10.56MiB 20.6MiB
static_quality_gate_iot_agent_deb_amd64 59.23MiB 69.0MiB 14.88MiB 24.8MiB
static_quality_gate_iot_agent_deb_arm64 56.59MiB 66.4MiB 12.85MiB 22.8MiB
static_quality_gate_iot_agent_rpm_amd64 59.23MiB 69.0MiB 14.9MiB 24.8MiB
static_quality_gate_iot_agent_rpm_arm64 56.59MiB 66.4MiB 12.85MiB 22.8MiB
static_quality_gate_iot_agent_suse_amd64 59.23MiB 69.0MiB 14.9MiB 24.8MiB
static_quality_gate_docker_agent_amd64 915.93MiB 931.7MiB 307.45MiB 318.67MiB
static_quality_gate_docker_agent_arm64 928.99MiB 944.08MiB 292.43MiB 303.0MiB
static_quality_gate_docker_agent_jmx_amd64 1.09GiB 1.1GiB 382.56MiB 393.75MiB
static_quality_gate_docker_agent_jmx_arm64 1.09GiB 1.1GiB 363.53MiB 373.71MiB
static_quality_gate_docker_dogstatsd_amd64 47.7MiB 57.88MiB 18.26MiB 28.29MiB
static_quality_gate_docker_dogstatsd_arm64 46.09MiB 56.27MiB 17.02MiB 27.06MiB
static_quality_gate_docker_cluster_agent_amd64 264.95MiB 274.78MiB 106.33MiB 116.28MiB
static_quality_gate_docker_cluster_agent_arm64 280.91MiB 290.82MiB 101.19MiB 111.12MiB

@AliDatadog AliDatadog force-pushed the ali/otel-image branch 2 times, most recently from 5e1d57f to b288e90 Compare February 24, 2025 11:21
@AliDatadog AliDatadog force-pushed the ali/otel-image branch 2 times, most recently from 64015bb to 3c2d590 Compare February 25, 2025 12:22
@AliDatadog AliDatadog changed the title [WIP] Add new otel-agent distroless image [WIP] Add new otel-agent standalone image Feb 25, 2025
@AliDatadog AliDatadog force-pushed the ali/otel-image branch 5 times, most recently from 650b340 to 6989eb1 Compare February 27, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-delivery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant