use `github.com/mattn/go-sqlite3` instead of modernc for trivy #34363

paulcacheux · 2025-02-24T15:25:11Z

What does this PR do?

Similar to #34358 but for the trivy use case.

Reasons for the Change:

Alignment with Podman collector: related to the PR linked above.
Reduction in binary size ([podman] Change sqlite backend #34358 (comment)): the trivy import was the last one for modernc.org/sqlite so this PR removes the dependency fully.

The part of the code that uses this is not highly performance-sensitive, as it only executes a simple query to retrieve the list of packages on some red hat based distributions.

Motivation

Describe how you validated your changes

This was tested manually on some redhat based distribution.

Possible Drawbacks / Trade-offs

Additional Notes

cit-pr-commenter · 2025-02-24T16:16:55Z

Go Package Import Differences

Baseline: e3f7cad
Comparison: 14b372e

binary	os	arch	change
agent	linux	amd64	+0, -8 -github.com/remyoudompheng/bigfft -modernc.org/libc -modernc.org/libc/sys/types -modernc.org/libc/uuid/uuid -modernc.org/mathutil -modernc.org/memory -modernc.org/sqlite -modernc.org/sqlite/lib
agent	linux	arm64	+0, -8 -github.com/remyoudompheng/bigfft -modernc.org/libc -modernc.org/libc/sys/types -modernc.org/libc/uuid/uuid -modernc.org/mathutil -modernc.org/memory -modernc.org/sqlite -modernc.org/sqlite/lib
system-probe	linux	amd64	+1, -8 +github.com/mattn/go-sqlite3 -github.com/remyoudompheng/bigfft -modernc.org/libc -modernc.org/libc/sys/types -modernc.org/libc/uuid/uuid -modernc.org/mathutil -modernc.org/memory -modernc.org/sqlite -modernc.org/sqlite/lib
system-probe	linux	arm64	+1, -8 +github.com/mattn/go-sqlite3 -github.com/remyoudompheng/bigfft -modernc.org/libc -modernc.org/libc/sys/types -modernc.org/libc/uuid/uuid -modernc.org/mathutil -modernc.org/memory -modernc.org/sqlite -modernc.org/sqlite/lib

agent-platform-auto-pr · 2025-02-24T16:34:01Z

Uncompressed package size comparison

Comparison with ancestor e3f7cade9bcec8d5cf32910b6ed8856eb0b68156

Diff per package

package	diff	status	size	ancestor	threshold
datadog-dogstatsd-amd64-deb	0.00MB	✅	39.42MB	39.42MB	0.50MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	39.50MB	39.50MB	0.50MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	39.50MB	39.50MB	0.50MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	37.96MB	37.96MB	0.50MB
datadog-iot-agent-amd64-deb	0.00MB	✅	62.02MB	62.02MB	0.50MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	62.09MB	62.09MB	0.50MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	62.09MB	62.09MB	0.50MB
datadog-iot-agent-arm64-deb	0.00MB	✅	59.26MB	59.26MB	0.50MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	59.33MB	59.33MB	0.50MB
datadog-heroku-agent-amd64-deb	-0.00MB	✅	443.27MB	443.28MB	0.50MB
datadog-agent-arm64-deb	-5.00MB	✅	825.16MB	830.17MB	0.50MB
datadog-agent-aarch64-rpm	-5.01MB	✅	834.91MB	839.92MB	0.50MB
datadog-agent-x86_64-rpm	-5.47MB	✅	844.36MB	849.83MB	0.50MB
datadog-agent-x86_64-suse	-5.47MB	✅	844.36MB	849.83MB	0.50MB
datadog-agent-amd64-deb	-5.48MB	✅	834.59MB	840.06MB	0.50MB

Decision

✅ Passed

agent-platform-auto-pr · 2025-02-24T16:34:44Z

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=56786938 --os-family=ubuntu

Note: This applies to commit 14b372e

agent-platform-auto-pr · 2025-02-24T16:38:32Z

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result	Quality gate	On disk size	On disk size limit	On wire size	On wire size limit
✅	static_quality_gate_agent_deb_amd64	807.63MiB	847.49MiB	194.97MiB	212.33MiB
✅	static_quality_gate_agent_deb_arm64	798.56MiB	836.66MiB	177.16MiB	192.5MiB
✅	static_quality_gate_agent_rpm_amd64	807.71MiB	847.82MiB	198.01MiB	215.76MiB
✅	static_quality_gate_agent_rpm_arm64	798.66MiB	836.66MiB	178.31MiB	194.24MiB
✅	static_quality_gate_agent_suse_amd64	807.69MiB	847.82MiB	198.01MiB	215.76MiB
✅	static_quality_gate_agent_suse_arm64	798.56MiB	836.66MiB	178.31MiB	194.24MiB
✅	static_quality_gate_dogstatsd_deb_amd64	37.67MiB	49.7MiB	9.78MiB	20.6MiB
✅	static_quality_gate_dogstatsd_deb_arm64	36.27MiB	48.1MiB	8.49MiB	19.1MiB
✅	static_quality_gate_dogstatsd_rpm_amd64	37.67MiB	49.7MiB	9.79MiB	20.6MiB
✅	static_quality_gate_dogstatsd_suse_amd64	37.67MiB	49.7MiB	9.79MiB	20.6MiB
✅	static_quality_gate_iot_agent_deb_amd64	59.23MiB	69.0MiB	14.89MiB	24.8MiB
✅	static_quality_gate_iot_agent_deb_arm64	56.59MiB	66.4MiB	12.82MiB	22.8MiB
✅	static_quality_gate_iot_agent_rpm_amd64	59.23MiB	69.0MiB	14.9MiB	24.8MiB
✅	static_quality_gate_iot_agent_rpm_arm64	56.59MiB	66.4MiB	12.85MiB	22.8MiB
✅	static_quality_gate_iot_agent_suse_amd64	59.22MiB	69.0MiB	14.9MiB	24.8MiB
✅	static_quality_gate_docker_agent_amd64	892.05MiB	931.7MiB	298.42MiB	318.67MiB
✅	static_quality_gate_docker_agent_arm64	906.32MiB	944.08MiB	284.17MiB	303.0MiB
✅	static_quality_gate_docker_agent_jmx_amd64	1.06GiB	1.1GiB	373.51MiB	393.75MiB
✅	static_quality_gate_docker_agent_jmx_arm64	1.07GiB	1.1GiB	355.25MiB	373.71MiB
✅	static_quality_gate_docker_dogstatsd_amd64	45.81MiB	57.88MiB	17.28MiB	28.29MiB
✅	static_quality_gate_docker_dogstatsd_arm64	44.45MiB	56.27MiB	16.16MiB	27.06MiB
✅	static_quality_gate_docker_cluster_agent_amd64	264.94MiB	274.78MiB	106.33MiB	116.28MiB
✅	static_quality_gate_docker_cluster_agent_arm64	280.9MiB	290.82MiB	101.19MiB	111.12MiB

cit-pr-commenter · 2025-02-24T17:02:45Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 8a3a962e-9fab-4cea-a3ed-d410ad0c81ee

Baseline: e3f7cad
Comparison: 14b372e
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	file_to_blackhole_0ms_latency	egress throughput	+0.00	[-0.74, +0.74]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.28, +0.28]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.00	[-0.63, +0.63]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.02, +0.02]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.01	[-0.63, +0.62]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	-0.01	[-0.79, +0.77]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	-0.01	[-0.79, +0.77]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.05	[-0.83, +0.73]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	-0.08	[-0.55, +0.38]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.26	[-1.13, +0.61]	1	Logs
➖	quality_gate_logs	% cpu utilization	-0.32	[-3.23, +2.60]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.47	[-1.24, +0.31]	1	Logs
➖	quality_gate_idle	memory utilization	-0.50	[-0.53, -0.46]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	-0.56	[-0.61, -0.50]	1	Logs bounds checks dashboard
➖	file_tree	memory utilization	-0.63	[-0.70, -0.56]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-1.31	[-1.39, -1.23]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

paulcacheux · 2025-02-25T10:40:17Z

/merge

dd-devflow · 2025-02-25T10:40:24Z

View all feedbacks in Devflow UI.
2025-02-25 10:40:23 UTC ℹ️ Start processing command /merge

2025-02-25 10:40:30 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-02-25 10:58:10 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 28m.

2025-02-25 11:30:32 UTC ℹ️ MergeQueue: This merge request was merged

#34363)" This reverts commit 565c054.

github-actions bot added medium review PR review might take time team/agent-security labels Feb 24, 2025

use github.com/mattn/go-sqlite3 instead of modernc for trivy

14b372e

paulcacheux force-pushed the paulcacheux/sqlite-backend-trivy branch from a222f9e to 14b372e Compare February 24, 2025 18:11

paulcacheux added qa/done QA done before merge and regressions are covered by tests changelog/no-changelog labels Feb 24, 2025

paulcacheux marked this pull request as ready for review February 25, 2025 10:23

paulcacheux requested review from a team as code owners February 25, 2025 10:23

davidor approved these changes Feb 25, 2025

View reviewed changes

spikat approved these changes Feb 25, 2025

View reviewed changes

dd-mergequeue bot merged commit 565c054 into main Feb 25, 2025
272 of 275 checks passed

dd-mergequeue bot deleted the paulcacheux/sqlite-backend-trivy branch February 25, 2025 11:30

github-actions bot added this to the 7.65.0 milestone Feb 25, 2025

wdhif pushed a commit that referenced this pull request Feb 25, 2025

use github.com/mattn/go-sqlite3 instead of modernc for trivy (#34363)

aa28746

paulcacheux added a commit that referenced this pull request Feb 26, 2025

Revert "use github.com/mattn/go-sqlite3 instead of modernc for trivy (

0bb7bfc

#34363)" This reverts commit 565c054.

paulcacheux mentioned this pull request Feb 26, 2025

Revert "use github.com/mattn/go-sqlite3 instead of modernc for trivy" #34468

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use `github.com/mattn/go-sqlite3` instead of modernc for trivy #34363

use `github.com/mattn/go-sqlite3` instead of modernc for trivy #34363

paulcacheux commented Feb 24, 2025 •

edited

Loading

cit-pr-commenter bot commented Feb 24, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 24, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 24, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 24, 2025 •

edited

Loading

Info

cit-pr-commenter bot commented Feb 24, 2025 •

edited

Loading

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

paulcacheux commented Feb 25, 2025

dd-devflow bot commented Feb 25, 2025 •

edited

Loading

use github.com/mattn/go-sqlite3 instead of modernc for trivy #34363

use github.com/mattn/go-sqlite3 instead of modernc for trivy #34363

Conversation

paulcacheux commented Feb 24, 2025 • edited Loading

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

cit-pr-commenter bot commented Feb 24, 2025 • edited Loading

Go Package Import Differences

agent-platform-auto-pr bot commented Feb 24, 2025 • edited Loading

Uncompressed package size comparison

Decision

agent-platform-auto-pr bot commented Feb 24, 2025 • edited Loading

Test changes on VM

agent-platform-auto-pr bot commented Feb 24, 2025 • edited Loading

Static quality checks ✅

Info

cit-pr-commenter bot commented Feb 24, 2025 • edited Loading

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

paulcacheux commented Feb 25, 2025

dd-devflow bot commented Feb 25, 2025 • edited Loading

use `github.com/mattn/go-sqlite3` instead of modernc for trivy #34363

use `github.com/mattn/go-sqlite3` instead of modernc for trivy #34363

paulcacheux commented Feb 24, 2025 •

edited

Loading

cit-pr-commenter bot commented Feb 24, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 24, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 24, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 24, 2025 •

edited

Loading

cit-pr-commenter bot commented Feb 24, 2025 •

edited

Loading

dd-devflow bot commented Feb 25, 2025 •

edited

Loading